Florian Bruhin
73587b1e16
Add SQLITE_CORRUPT to environmental SQL errors
2017-11-28 06:55:55 +01:00
Florian Bruhin
4fed8518e1
Handle "out of memory" error in sql.init()
2017-11-28 06:53:41 +01:00
Ryan Roden-Corrent
40e4e73e36
Ensure HistoryCategory works in isolation.
...
While QSortFilterProxyModel emits layoutChanged when changing the
pattern, QSqlQueryModel emits modelReset. As only layoutChanged was
connected, a HistoryCategory would only work in a model that also had at
least one ListCategory.
The simplest solution is to have the parent model emit the signal
directly. This also emits a single signal on a pattern change rather
that one for each child model.
Resolves #3016 .
2017-11-27 11:49:32 -05:00
Jimmy
0381d74e9a
Greasemonkey: privatise some utility functions
2017-11-27 20:10:38 +13:00
Florian Bruhin
db353c4030
Connect the page signal for GreaseMonkey
...
Looks like we don't get the mainFrame's loadFinished signal properly.
2017-11-27 20:10:38 +13:00
Florian Bruhin
6933bc05b4
Add some debug logging for GreaseMonkey with QtWebKit
2017-11-27 20:10:38 +13:00
Jimmy
df624944f9
Greasemonkey: webkit: injected all scripts on loadFinished.
...
The signal we were using to inject greasemonkey scripts registered to
run at document-start (javaScriptWindowObjectCleared) was unreliable to
non-existant. The initialLayoutCompleted signal is a bit of an odd duck
too I suppose. Anyway, we don't anticipate any scripts would break from
being injected when the page is finished loaded that wouldn't already
have been flaky due to the complexities of the modern web. If there is
an issue hopefully someone raises an issue and we can look into it.
2017-11-27 20:10:38 +13:00
Jimmy
8a5b42ffbd
Greasemonkey: es6ify the greasemonkey wrapper js.
...
Because backwards compatibility sucks I guess.
2017-11-27 20:10:38 +13:00
Jimmy
361a1ed6e4
Greasemonkey: change PROPS_REGEX to handle non-value keys.
...
We weren't actually picking up the @noframes greasemonkey directive
because of this. I haven't tested this very extensively but it seems to
work for making the property value optional.
2017-11-27 19:27:31 +13:00
Jimmy
9aeb5775c1
greasemonkey: run scripts on subframes on webkit
...
Use the `QWebPage.frameCreated` signal to get notifications of subframes
and connect the javascript injection triggering signals on those frames
too.
I had to add a `url = url() or requestedUrl()` bit in there because the
inject_userjs method was getting called to early or something when
frame.url() wasn't set or was set to the previous page so we were
passing the wrong url to greasemonkey.scripts_for().
I ran into a bizarre (I maybe it is completely obvious and I just don't
see it) issue where the signals attached to the main frame that were
connected to a partial function with the main frame as an argument were
not getting emitted, or at least those partial functions were not being
called. I worked around it by using None to mean defaulting to the main
frame in a couple of places.
2017-11-27 19:27:31 +13:00
Jimmy
7c497427ce
Greasemonkey: various javascript fixups to GM wrapper template.
...
Thanks to @sandrosc. A few breaking changes fixed (default method to
GM_xhr not working, GM_listvalues not cleaning up output, GM_setvalue
param checking logic wrong) and a few hygenic changes made.
2017-11-27 19:27:31 +13:00
Jimmy
c0832eb04b
Greasemonkey: support @nosubframes.
...
And run on frames by default. At least on webengine. There is probably
some api to enumerate frames on a webkit page.
Not tested.
2017-11-27 19:27:31 +13:00
Jimmy
fb019b2dab
Address second round line comments.
...
Add qute version to GM_info object in GM wrapper.
Support using the greasemonkey @namespace metadata for its intended
purpose of avoiding name collisions.
Get a nice utf8 encoded string from a QUrl more better.
2017-11-27 19:27:31 +13:00
Jimmy
efde31aa57
Greasemonkey: Support QTWebEngine versions < 5.8
...
QTWebEngine 5.8 added support for parsing greasemonkey metadata blocks
and scripts added to the QWebEngineScriptCollection of a page or its
profile and then deciding what urls to run those scripts on and at what
point in the load process to run them. For earlier versions we must do
that work ourselves. But with the additional handicap of the less rich
qtwebengine api.
We have acceptNavigationRequest, loadStarted, loadProgress,
loadFinished, urlChanged to choose from regarding points at which to
register scripts for the current page.
Adding scripts on acceptNavigation loadStarted and loadFinished causes
scripts to run too early or too late (eg on the pages being navigated
from/to) and not run on the desired page at the time they are inserted.
We could maybe do some more sophisticated stuff with loadProgress but it
didn't have any better behaviour in the brief testing I gave it.
Registering scripts on the urlChanged event seems to work fine. Even if
it seems like there could be problems with the signal firing too often,
due to not necessarily being tied to the page load progress, that
doesn't seem to have an effect in practice. The event is fired when, for
example, the url fragment changes and even if we add a new script to the
collection (or remove an existing one) it doesn't have an effect on what
is running on the page.
I suspect all of those timing issues is due to the signals being
forwarded fairly directly from the underlying chomium/blink code but the
webengine script stuff only being pushed back to the implementation on
certain events.
Anyway, using urlChanged seems to work fine due to some quirk(s) of the
implementation. That might change with later development but this
codepath is only ever going to be used for version 5.7.
There are other potential optimizations like not removing and then
re-adding scripts for the current page. But they probably wouldn't do
anything anyway, or at least anything that you would expect.
2017-11-27 19:27:31 +13:00
Jimmy
209e43e0ba
Greasemonkey: Match against percent encoded urls only.
...
This change requires urls specified in @include, @exclude and @matches
directives in metadata blocks to be in the same form that
QUrl.toEncoded() returns. That is a punycoded domain and percent encoded
path and query. This seems to be what Tampermonkey on chrome expects to.
Also changes the scripts_for() function to take a QUrl arg so the caller
doesn't need to worry about encodings.
2017-11-27 19:27:31 +13:00
Jimmy
d318178567
Greasemonkey: Fix metadata block regex.
...
This regex was broken since the original PR and subsequent code seemed to be
working around it. Before re.split was returning [everything up to
/UserScript, everything else], now it returns [before UserScript, metadata,
after /UserScript], which is good.
Also I added the check for the UserScript line starting at column 0 as per
spec.
2017-11-27 19:27:31 +13:00
Jimmy
5e49e7eef2
Greasemonkey: Throw Errors if GM_ function args wrong type.
...
These argument type restrictions are mentioned on the greasespot pages for
these value storage functions. We could call JSON.dumps() instead but better
to push that onto the caller so we don't have to try handle deserialization.
Also removes the check for localstorage because everyone has supported that
for years.
2017-11-27 19:27:31 +13:00
Jimmy
d93c583c0d
Greasemonkey: Escape jinja variables for JS strings.
2017-11-27 19:27:31 +13:00
Jimmy
a7f41b4564
Greasemonkey: ensure only GM scripts are cleaned up on reload.
...
WebEngine only. Previously we were just removing every script from the
main world. But some other scripts might got here in the future so new
we are overriding the name field to add a GM- prefix so hopefully we
only remove greasemonkey scripts before adding new ones.
2017-11-27 19:27:31 +13:00
Jimmy
fd5d44182b
Greasemonkey: move GM_* template into seperate file.
...
Also ported it to jinja rather than str.format().
Also ran the js through jslint and fixed up a few very minor things.
2017-11-27 19:27:31 +13:00
Jimmy
c1b912f567
Greasemonkey: move inject_userscripts into webenginesettings
2017-11-27 19:27:31 +13:00
Jimmy
edf737ff7d
Greasemonkey: move scripts for a domain into data class.
...
Also makes scripts that don't include a greasemonkey metadata block
match any url. QWebEngine already has that behaviour.
2017-11-27 19:27:31 +13:00
Jimmy
41035cb5ca
Greasemonkey: restrict page schemes that scripts can run on
...
Scripts shouldn't run on qute://settings or source:// etc.
Whitelist from:
https://wiki.greasespot.net/Include_and_exclude_rules
2017-11-27 19:27:31 +13:00
Jimmy
799730f686
Remove GM_ and userscript variables from global scope.
2017-11-27 19:27:31 +13:00
Jimmy
325c595b89
Greasemonkey: Don't strip gm metadata from scripts when loading.
...
Since we just pass them to webenginescriptcollection on that backend and
that wants to parse it itself to figure out injection point etc.
2017-11-27 19:27:31 +13:00
Jimmy
f26377351c
Greasemonkey: Add greasemonkey hooks for webengine.
...
For qtwebengine 5.8+ only. This is because as of 5.8 some greasemonkey
script support is in upstream. That is, qtwebenginescript(collection)
parses the greasemonkey metadata block and uses @include/match/exclude
to decide what sites to inject a script onto and @run-at to decide when
to inject it, which saves us the trouble. Notes on doing this in <5.8
are below.
Scripts are currently injected into the main "world", that is the same
world as the javascript from the page. This is good because it means
userscripts can modify more stuff on the page but it would be nice if we
could have more isolation without sacrificing functionality. I'm still
looking into why my more feature-full scripts are not having any effect
on the page while running in a separate world.
Userscripts are added to both the default and private profile because I
that if people have scripts installed they want them to run in private mode
too.
We are grabbing the scripts from the greasemonkey module, as opposed to
reading them directly from disk, because the module adds some GM_* functions
that the scripts may expect, and because that is used for webkit anyway.
I have code to support qtwebengine <5.8 but didn't because I am not
happy with the timing of some of the signals that we are provided
regarding page load state, and the actual load state. While the
difference between document-end and document-idle isn't so bad,
injecting document-start scripts when a urlChanged event is emitted
results in the script being injected into the environment for the page
being navigated away from. Anyway, if anyone wants this for earlier
webengines I can oblige them.
2017-11-27 19:27:31 +13:00
Jimmy
be9f8bd0de
Greasemonkey: Lift greasemonkey init app.py
...
To prepare for multiple-backend support.
2017-11-27 19:27:31 +13:00
Jimmy
25f626a436
Greasemonkey: Add run-at document-idle.
...
Supposed to be after all the assets have finished loading and in page js
has run. Not that we can garuntee that last bit. If a script misbehaves
because a precondition isn't yet met I suggest adding a defer method to
the script that adds a timer until the precondition is met.
Also changed the map/filter calls to use list comprehensions to keep
pylint happy. Even if it does look uglier.
2017-11-27 19:27:31 +13:00
Jimmy
13728387d7
Greasemonkey: Fix crash on undefined metadata.
2017-11-27 19:27:31 +13:00
Jimmy
ecdde7663f
Add greasemonkey-reload command.
...
Also add a signal to emit when scripts are reloaded. Had to make
GreasemonkeyManager inherit from QObject to get signals to work.
2017-11-27 19:27:31 +13:00
Andor Uhlár
568d60753e
Add greasemonkey compatible userscript module.
...
WebKit backend only for now. Loads all .js files from a directory,
specified in the greasemonkey-directory key in the storage section,
defaulting to data/greasemonkey, and wraps them in a minimal environment
providing some GM_* functions. Makes those scripts available via the
"greasemonkey" registered object in objreg and injects scripts at appropriate
times in a page load base on @run-at directives.
2017-11-27 19:27:31 +13:00
Florian Bruhin
248a12a8b9
Add flake8-comprehensions
2017-11-26 21:42:50 +01:00
Florian Bruhin
b5dd647678
Upgrade pydocstyle/flake8-docstrings
...
See #3320
2017-11-26 20:30:32 +01:00
Florian Bruhin
0f3cff60fa
Merge remote-tracking branch 'origin/pr/3335'
2017-11-26 19:42:54 +01:00
Florian Bruhin
38f8cacd2b
Merge remote-tracking branch 'origin/pr/3336'
2017-11-26 19:35:26 +01:00
Florian Bruhin
67253726fa
Handle empty messages in qt_message_handler
...
I can't reproduce this, but someone on KDE reported always getting a crash (as
msg.splitlines()[0] gives an IndexError) when trying to select a file with
Qt 5.9.3.
2017-11-26 17:31:07 +01:00
Ryan Roden-Corrent
54fffc8264
Resolve crash when editor tab is closed.
...
If an editor is open on a form in a tab and that tab is closed, rewire
the callback to print a warning. Previously, the callback would access a
deleted C++ object and cause a crash.
Resolves #2758 .
2017-11-26 07:50:49 -05:00
Panagiotis Ktistakis
e05dabefdf
Show default keybinding in :bind completion
2017-11-26 13:34:18 +02:00
Ryan Farley
5ed8019115
update flake8 and flake8-deprecated
...
Updated requirements and adjusted the configuration in `.flake8`; other
files have been modified where the lack of per-file auto-ignore caused
problems, where putty's `# flake8: disable=` syntax could be replaced
with a simpler `noqa`, or where pylint directives already suppressed the
same error.
2017-11-26 00:16:14 -06:00
mhm@mhm.com
9df149fe8f
urlencode fix
2017-11-24 17:15:26 +01:00
Artur Shaikhullin
72040a3bbb
Position caret on top element
2017-11-24 17:32:23 +06:00
Florian Bruhin
0afd6b23c9
Add the option name to the backend error message
2017-11-24 09:25:45 +01:00
Florian Bruhin
28d7c5e204
Fix lint
2017-11-24 07:25:10 +01:00
Jay Kamat
739cfc03ba
Fix undercounting short hints
2017-11-23 23:14:21 -05:00
Artur Shaikhullin
8a64ce19c3
Fetch selection for userscripts
2017-11-23 20:18:43 +06:00
Ryan Roden-Corrent
8eab402820
Abort :edit-command on invalid input.
...
Show an error message if the user edits the command such that it is
missing a start character (:, /, or ?). Previously, this would cause the
browser to crash.
Resolves #3326 .
2017-11-23 08:15:27 -05:00
Florian Bruhin
b31360b6e3
Fix line break
2017-11-22 17:19:21 +01:00
Florian Bruhin
750d2c490f
Fix :completion-item-focus --history with / or ?
...
If we have no completion (like when searching), we can just always go through
history with up/down.
2017-11-22 15:34:48 +01:00
Artur Shaikhullin
e7a66d92a8
Selection implentation
2017-11-22 19:56:05 +06:00
Florian Bruhin
487951cd31
Fix joining :jseval path
2017-11-22 10:57:48 +01:00
Florian Bruhin
12f4940ef3
Make :jseval use a fixed path with relative paths
2017-11-22 09:37:17 +01:00
Florian Bruhin
3b3acba34e
Edit description of tabs.persist_mode_on_change
2017-11-22 09:11:17 +01:00
Florian Bruhin
2581be051f
Always leave hint/caret mode when switching tabs
...
See #3323
2017-11-22 08:53:01 +01:00
mhm@mhm.com
e2d5a443cc
lazy sessions
2017-11-21 23:57:06 +01:00
Vladimir Shulyak
358c888760
Fix long line
2017-11-21 22:35:19 +00:00
Vladimir Shulyak
7532db83c4
Add option to persist current mode on tab change
2017-11-21 18:57:41 +00:00
Artur Shaikhullin
8aca37e5d5
Implement all caret browsing methods
2017-11-21 19:56:00 +06:00
Florian Bruhin
203b6c354f
Fix content.cache.size overflow with QtWebEngine
...
While 64-bit values are allowed with QtWebKit/QNetworkDiskCache, QtWebEngine
only allows 32-bit values here. With the updated sip's strict overflow checking,
that means we get an exception when setting a too big value.
2017-11-21 14:07:49 +01:00
mhm@mhm.com
607cd9ba6e
indent adjusted
2017-11-21 01:19:04 +01:00
mhm@mhm.com
aa40842848
lazy sessions, docstring formatted, settings renamed, javascript notice changed, insert method changed
2017-11-21 00:38:51 +01:00
Ryan Roden-Corrent
5495380580
Exit command mode after :edit-command --run.
...
Resolves #3317 , where the command prompt was left open and populated
with text after running the command.
2017-11-20 11:46:26 -05:00
Artur Shaikhullin
82b1bd10ec
Add some movement caret actions
2017-11-20 17:49:42 +06:00
Florian Bruhin
a2c549b954
Merge remote-tracking branch 'origin/pr/3313'
2017-11-19 21:09:19 +01:00
Florian Bruhin
87b174b418
Simplify :completion-item-focus
2017-11-19 21:07:33 +01:00
Florian Bruhin
62f37df573
Make cursor keys go through completion if a text was entered
...
This hopefully helps with people who try to use arrow keys for the completion,
while still making the command history somewhat discoverable.
2017-11-19 20:35:16 +01:00
akhilkpdasan
740d629b36
Update utilcmds.py
2017-11-20 00:56:09 +05:30
akhilkpdasan
9a58fe229c
fixed spelling error
2017-11-19 19:32:24 +05:30
akhilkpdasan
ba6d90aa7a
fixed docmentation for pyeval
2017-11-19 19:08:52 +05:30
Florian Bruhin
91c909cb80
Merge remote-tracking branch 'origin/pr/3212'
2017-11-19 14:24:40 +01:00
Florian Bruhin
8c7bf12b88
Merge remote-tracking branch 'origin/pr/3306'
2017-11-19 14:08:58 +01:00
Florian Bruhin
2b063f577e
Handle OSError in :config-write-py
2017-11-19 14:06:11 +01:00
Florian Bruhin
8fb03208e7
Improve parsing of fatal stacktraces
...
We now also recognize "Windows fatal exception: ..." message and refuse to
send empty Windows access violation messages.
2017-11-19 14:06:11 +01:00
Akhil kp
c5eab53a87
Added --file for :debug-pyeval
2017-11-19 18:20:58 +05:30
Ryan Roden-Corrent
d145b304d0
Remove maxsplit from edit_command.
...
This was a copy-paste typo, no need for maxsplit as this command takes
no positional args.
2017-11-18 20:41:23 -05:00
mhm@mhm.com
13dc24f6ca
debug code removed
2017-11-18 14:31:55 +01:00
mhm@mhm.com
cf8130bd22
lazy session, fix: active entry is not the end of the history
2017-11-18 14:28:44 +01:00
mhm@mhm.com
2debeafe1b
lazy sessions, dont save qute://back
2017-11-18 13:51:30 +01:00
mhm@mhm.com
1a33c88c96
lazy sessions, dont save qute://back
2017-11-18 13:47:57 +01:00
mhm@mhm.com
c150c5481a
lazy sessions, dont save qute://back
2017-11-18 13:46:50 +01:00
mhm@mhm.com
c4bb134313
lazy sessions, improved version
2017-11-18 11:05:54 +01:00
mhm@mhm.com
51dea053f4
lazy sessions
2017-11-18 01:00:16 +01:00
mhm@mhm.com
ade7004f8f
lazy sessions
2017-11-18 00:48:31 +01:00
mhm@mhm.com
95f8c07d7f
lazy sessions
2017-11-18 00:31:53 +01:00
Ryan Roden-Corrent
0f93d53210
Implement :edit-command.
...
:edit-command opens the current command line in an editor, and updates
the command line if the editor exits successfully. If --run is passed,
the command is executed when the editor exits sucessfully.
Resolves #2453 .
2017-11-17 11:16:42 -05:00
Artur Shaikhullin
b184d2f94d
dirty initial port of chrome caretbrowser extension
2017-11-16 19:25:15 +06:00
Florian Bruhin
b26f2290bc
Merge remote-tracking branch 'origin/pr/3097'
2017-11-16 11:14:59 +01:00
Florian Bruhin
b3085f5d60
Merge remote-tracking branch 'origin/pr/3291'
2017-11-16 10:17:02 +01:00
dwagle
233cea4b62
discarded unnecessary comment and adjusted some code to make pylint happy, also made adjustments to pytest scenarios
2017-11-15 15:48:21 +05:45
Florian Bruhin
ea71f0e318
Merge remote-tracking branch 'origin/pr/3285'
2017-11-15 07:32:04 +01:00
Florian Bruhin
404f9ea1d0
Merge remote-tracking branch 'origin/pr/3290'
2017-11-15 07:31:10 +01:00
dwagle
b3b768f4a8
normalize url path and strip trailing slashes when doing gu/gU, normalize every qute://* urls and raise OSError when a url redirects to a directory in qute://help/ pages
2017-11-14 21:23:40 +05:45
Florian Bruhin
e72e8b8556
Revert "Hide quickmark/bookmark completion if empty."
...
This reverts commit 23716f1212
.
See #3016
Fixes #3288
Reopens #960
2017-11-14 13:29:58 +01:00
Florian Bruhin
62f35ee064
Fix lint
2017-11-14 09:05:28 +01:00
Dasith Gunawardhana
ea70a0dea1
changed setting name and reverted non-issue fix
2017-11-14 01:41:15 -05:00
Florian Bruhin
1203be2a44
Remove unnecessary str() call
2017-11-14 06:19:42 +01:00
Dasith Gunawardhana
4419e59d46
prevent WM fullscreen from being unset when desktop_fullscreen is false
2017-11-13 23:25:10 -05:00
Jay Kamat
ae48fa68a8
Add an uptime section to qute:version
2017-11-13 21:58:00 -05:00
Dasith Gunawardhana
36c8ca9790
added option to limit fullscreen to window only
2017-11-13 21:38:02 -05:00
Florian Bruhin
408ceefad1
Merge branch 'none-position'
2017-11-13 20:42:22 +01:00
Florian Bruhin
870c15a02c
Merge remote-tracking branch 'origin/pr/3264'
2017-11-13 20:40:23 +01:00
Ryan Roden-Corrent
b72343d126
Yank selected text with completion-item-yank.
...
If text is highlighted in the status command bar, completion-item-yank
should yank that rather than the selected completion item.
Resolves #3281 .
2017-11-13 13:25:18 -05:00
Jay Kamat
0f17e6633d
Stop calling _register automatically for StyleSheetObservers
2017-11-13 12:04:31 -05:00
Florian Bruhin
df4a011d48
Put files into the config dir with :config-write-py and rel. paths
2017-11-13 10:58:51 +01:00
Florian Bruhin
5c43dca0da
Improve error message for files which don't exist
2017-11-13 10:47:37 +01:00
Florian Bruhin
f6cc6677dd
Remove hiding of commands
...
This was often confusing for people - let's instead just hide commands which are
not available in normal mode.
2017-11-13 09:02:16 +01:00
Florian Bruhin
ec6017b3b2
Remove unneeded parens
2017-11-13 07:09:59 +01:00
Florian Bruhin
7f0ecaa89e
Merge remote-tracking branch 'origin/pr/3266'
2017-11-13 07:09:49 +01:00
Florian Bruhin
fc8f2090f0
Merge remote-tracking branch 'origin/pr/3271'
2017-11-13 07:09:29 +01:00
Florian Bruhin
ccb564de36
Merge remote-tracking branch 'origin/pr/3279'
2017-11-13 07:08:53 +01:00
Ryan Roden-Corrent
23716f1212
Hide quickmark/bookmark completion if empty.
...
If there are no quickmarks/bookmarks, hide the entire category in url
completion. Note that this only hides the category if
quickmarks/bookmarks is empty to begin with. An empty category is still
shown if the completion pattern filters out all items in that category.
See #960 .
2017-11-12 22:28:49 -05:00
Florian Bruhin
f6e6f9d27b
Make qutebrowser aware of settings requiring a restart
...
See #3270
2017-11-12 17:17:19 +01:00
Jay Kamat
c1fcabe846
Remove default config-cycle bindings
...
Many people accidentally hit 'x{x,t,b}', hiding their statusbar by mistake
2017-11-11 16:16:26 -05:00
Jay Kamat
f242fc5cd7
Add setting to avoid shrinking pinned tabs
2017-11-11 11:33:33 -05:00
Jay Kamat
e00a072d15
Fix garbage collection of StyleSheetObserver objects
2017-11-10 23:25:46 -05:00
Florian Bruhin
c47f0402ab
Fix lint
2017-11-10 13:14:51 +01:00
Florian Bruhin
456c854f06
Improve documentation for :hint --rapid
2017-11-10 10:23:16 +01:00
Florian Bruhin
8df759ecad
Merge remote-tracking branch 'origin/pr/3259'
2017-11-10 09:42:05 +01:00
Ulrik de Muelenaere
b37517e55f
Fix error in stylesheet.js on older QtWebEngine
2017-11-09 19:28:36 +02:00
dkanada
6ecd429d8f
group indicator preferences
2017-11-08 15:27:16 -07:00
dkanada
b8b49637e2
replace changes to desc
2017-11-08 14:46:00 -07:00
dkanada
785bf24652
change the code for the renamed preferences
2017-11-08 14:42:09 -07:00
Panagiotis K
59cebae28e
Remove redundant import.
2017-11-08 18:23:51 +02:00
Florian Bruhin
180fb0d65a
Fix handling of caret position with Qt 5.10
...
With Chromium 61 in Qt 5.10, we get null when getting .selectionStart on a
non-text element, like changed in the WhatWG HTML standard:
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#dom-textarea/input-selectionstart
See https://www.chromestatus.com/feature/5740194741354496
Older QtWebEngines and QtWebKit raise InvalidStateError instead.
This also changes the surrounding code and API so None is used to say "there's
no caret position available", which seems like a nicer API.
2017-11-08 16:27:26 +01:00
cryzed
6e719d1796
Fix issue #3251
2017-11-08 15:08:36 +01:00
Florian Bruhin
fdc9dfdf87
Merge remote-tracking branch 'origin/pr/3175'
2017-11-07 11:24:41 +01:00
Florian Bruhin
9f898611f3
Add missing path assignment
2017-11-07 11:24:00 +01:00
Florian Bruhin
32914cfaf8
Remove unneeded backslash
2017-11-07 11:17:18 +01:00
Florian Bruhin
3eafdc13d7
Merge remote-tracking branch 'origin/pr/3177'
2017-11-07 11:17:00 +01:00
Florian Bruhin
4f0d8a84ee
Merge remote-tracking branch 'origin/pr/3253'
2017-11-07 07:46:30 +01:00
Joel Bradshaw
52be2dd665
Update documents to reflect new dictcli.py script
2017-11-06 22:21:07 -08:00
Jay Kamat
ecf6f4bca0
Fix Qt Mnemonics affecting min tab width
...
See #3245
2017-11-06 15:05:26 -05:00
Jan Verbeek
3e8c84c018
Make :undo re-open all tabs closed by :tab-only
...
This changes the undo stack from a list of UndoEntry objects to a list
of lists of UndoEntry objects, so groups of tabs can be added. Only
:tab-only does that, but it's exposed by TabbedBrowser.close_tab as a
keyword argument.
2017-11-06 19:32:10 +01:00
Florian Bruhin
0053b10e4d
Merge remote-tracking branch 'origin/pr/3243'
2017-11-06 16:26:21 +01:00
Florian Bruhin
e7da2142f3
Merge remote-tracking branch 'origin/pr/3249'
2017-11-06 13:52:19 +01:00
Florian Bruhin
29cbf75615
Merge remote-tracking branch 'origin/pr/3249'
2017-11-06 13:46:24 +01:00
Ryan Roden-Corrent
c74cb22374
Improve completion-item-yank documentation.
2017-11-06 07:34:31 -05:00
Florian Bruhin
378b280f9a
Fix qute://gpl
2017-11-06 12:13:54 +01:00
Florian Bruhin
55815bd17b
Add some debug logging for #3219
2017-11-06 10:53:37 +01:00
Florian Bruhin
b55bb5dc6f
Work around QUrl::query() not being available with PyQt 5.9.1
...
See https://www.riverbankcomputing.com/pipermail/pyqt/2017-November/039702.html
2017-11-06 08:50:03 +01:00
Florian Bruhin
2514b009af
Use QUrlQuery to get log level on qute://log
...
This helps with
https://www.riverbankcomputing.com/pipermail/pyqt/2017-November/039702.html
2017-11-06 08:42:59 +01:00
Florian Bruhin
4d8ac7486c
Go back to using subprocess.Popen for :restart
...
With subprocess.run, we wait until the subprocess has completed, which means the
parent process will hang on :restart.
Since we *don't* want to wait for the subprocess here, using subprocess.Popen
seems the right thing to do.
This was introduced in bb54a954fe
/ #3203
Probably doesn't affect #3210 and #3220 .
2017-11-06 07:45:17 +01:00
Florian Bruhin
22f3fade24
Bump up default font size to 10pt
...
See #1585
2017-11-06 07:36:52 +01:00
Florian Bruhin
f52930c857
Make the window.hide_wayland_decoration option less special
2017-11-06 07:33:13 +01:00
Florian Bruhin
4fdf2d6f40
Update docs
2017-11-06 07:11:00 +01:00
Florian Bruhin
341e8ca864
Add a qt.highdpi setting
...
See #1585
2017-11-06 07:02:07 +01:00
Florian Bruhin
f222aa30a6
Merge remote-tracking branch 'origin/pr/3250'
2017-11-06 06:53:11 +01:00
Jay Kamat
ca0aa68f74
Fix icon width calculation for pinned tabs
2017-11-05 23:23:33 -05:00
Michal Siedlaczek
855d0312b5
Review fixes
2017-11-05 18:12:15 -05:00
Michael Hoang
966aa810df
Set maxsplit to 0 on :buffer
...
Remove double quotes from tests
2017-11-06 06:41:43 +11:00
Ryan Roden-Corrent
db3b1aee0d
Add default ctrl+c binding for completion yank.
...
By default, ctrl+c will yank the selection from the completion menu onto
the clipboard, and ctrl+shift+c will yank it onto the primary selection.
Unfortunately ctrl+y was already taken by rl-yank (which,
counter-intuitively to vim users, will paste the last deleted text).
2017-11-05 11:14:28 -05:00
Ryan Roden-Corrent
bb63f9fd92
Implement completion-item-yank.
...
Yank the text from the first column of the completion menu.
Resolves #1588 .
2017-11-05 11:07:38 -05:00
Michal Siedlaczek
3ac2cfdf73
Support updating dictionaries and removing old versions.
2017-11-04 18:16:05 -04:00
Panagiotis K
5215321e64
Error handling, better code quality.
...
Handling of os errors raised during parent
directory creation.
2017-11-04 20:17:35 +02:00
Florian Bruhin
87c339587f
Release v1.0.3
...
(cherry picked from commit fc63cea91790ddfc4b7fe2ef590de83a3c31dd39)
2017-11-04 17:05:05 +01:00
Florian Bruhin
5689a3c0dc
Fix unbinding default keys twice
...
When doing :unbind with a default keybinding the first time, it gets inserted
into bindings.commands with None as value.
When then doing :unbind a second time, instead of just leaving that None value
as-is, we removed it again (because it got treated as a custom binding).
Fixes #3162
2017-11-04 15:17:19 +01:00
Michal Siedlaczek
2dc0115c81
Load the newest version of the dictionary.
2017-11-03 19:20:31 -04:00
Michal Siedlaczek
16ad9182f1
Add en-AU (Australia) to the list of valid languages
2017-11-03 17:24:33 -04:00
Florian Bruhin
c22a27d47f
Add missing trailing dots
...
(cherry picked from commit 5f43b02badc20a4fc67931ab6e76f1050ab283aa)
2017-11-03 15:03:05 +01:00
Florian Bruhin
864249d798
Merge remote-tracking branch 'origin/pr/3181'
2017-11-03 15:02:27 +01:00
Florian Bruhin
0f28804032
Merge pull request #3237 from rcorre/completionsort
...
Fix completion sorting
2017-11-03 14:36:42 +01:00
Florian Bruhin
1536c098cf
Merge pull request #3215 from deewakar/issue3161
...
Add trailing slash to qute://help pages
2017-11-03 11:49:31 +01:00
Ulrik de Muelenaere
ce1494e5ec
Update stylesheet.js to ES6
2017-11-03 12:17:35 +02:00
Ulrik de Muelenaere
72c57d16f4
Merge branch 'master' into stylesheet
2017-11-03 12:13:52 +02:00
Florian Bruhin
d53a96d9f2
Merge pull request #3208 from 7lb/refactor/make_completer_less_stateful
...
[RDY] Make completer less stateful
2017-11-03 10:47:52 +01:00
Florian Bruhin
be325853d8
Revert "Inject JS into the profile"
...
This reverts commit acfb3aa26f
.
The related code doesn't really belong in webenginesettings.py after all, and
for some reason I don't understand right now this breaks tests in
javascript.feature because window._qutebrowser is undefined when running them.
2017-11-03 09:59:00 +01:00
Florian Bruhin
25bda66260
Merge pull request #3191 from gyorb/refactor/enum
...
use Enum start number
2017-11-03 09:30:47 +01:00
Marcel Schilling
7e07f5c996
standardize placeholders in configdata descriptions
...
* Keep descriptions concise.
* Prefer starting descriptions with a noun.
* Don't explain that placeholders are placeholders/get replaced.
* Introduce placeholder list by the following line:
'The following placeholders are defined:'
* List placeholders in a markdown-style list:
'* `{<placeholder>}`: <description>.'
2017-11-03 08:48:30 +01:00
Marcel Schilling
c6d7509220
rephrase configdata descriptions
...
* see discussion of PR #3181
2017-11-03 08:44:11 +01:00
Marcel Schilling
87ec7a1a0b
prefer nouns for configdata descriptions
...
* reserve interrogative words for selection type options
2017-11-03 08:44:11 +01:00
Marcel Schilling
aebe4c8f9e
assume single user in configdata descriptions
...
* 'a user' -> 'the user'
2017-11-03 08:44:11 +01:00
Marcel Schilling
a6451c05d7
add missing units to configdata descriptions
...
* fixes #3171
2017-11-03 08:44:11 +01:00
Marcel Schilling
01b29cd640
use interrogative words for configdata descriptions
...
* for selections, use appropriate determiner/pro-adverb/pronoun:
* 'When to [...].'
* 'How to [...].'
* 'Which [...] to [...].'
* 'What [...] to [...].'
2017-11-03 08:44:11 +01:00
Marcel Schilling
0a908206bc
avoid boolean redundancy in configdata descriptions
...
* 'Enable or disable [...]' -> 'Enable [...]'
What else? ---^^^^^^^
2017-11-03 08:44:11 +01:00
Marcel Schilling
494aceec45
use imperative mood for bools in configdata descriptions
...
* considers ConfirmQuit and BoolAsk in addition to Bool
2017-11-03 08:44:11 +01:00
Marcel Schilling
f76af6c949
define type before desc in configdata YAML file
2017-11-03 08:44:11 +01:00
Marcel Schilling
b187a83d59
avoid spaces before colons in confidata YAML file
...
* ' desc : [...]' -> ' desc: [...]'
space ----^ no space ----^
2017-11-03 08:44:11 +01:00
Marcel Schilling
56671e5787
avoid articles in configdata descriptions
...
* includes `valid_value` descriptions in addition to `desc` fields
2017-11-03 08:44:11 +01:00
Marcel Schilling
e744a7c25a
avoid code duplication in configdata descriptions
...
* available placeholders are defined for tabs.title.format
* tabs.title.format_pinned refers to that definition
* window.title.format repeats the identical(!) definition
* this replaces the repetion by another reference
2017-11-03 08:44:11 +01:00
Marcel Schilling
fe8b9519c8
avoid redundancy in configdata descriptions
...
* drop phrases referring to the settings themselves:
* 'set ...'
* 'control ...'
* 'definitons of ...'
2017-11-03 08:44:11 +01:00
Marcel Schilling
fd52409d0c
standardize units in configdata descriptions
...
* encapsulate units in parentheses: ('(in <unit>)')
* move units right behind the corresponding noun
2017-11-03 08:44:11 +01:00
Marcel Schilling
e126faf8c1
prefer 'duration' in configdata descriptions
2017-11-03 08:44:11 +01:00
Marcel Schilling
7672fb5241
avoid abbreviations in configdata description
...
* chars -> characters
* px -> pixels
* ms -> milliseconds
* regexes -> regular expressions
* includes `valid_value` descriptions in addition to `desc` fields
ms_fix
2017-11-03 08:44:11 +01:00
Marcel Schilling
99ad1547bc
break long lines in configdata YAML file
...
* max. 79 chars (as per PEP8)
* two long lines remain (as I didn't know how to safely break them):
> 389 - "http://malwaredomains.lehigh.edu/files/justdomains.zip "
> -> 390 - "https://pgl.yoyo.org/adservers/serverlist.php?hostformat=hosts&mimetype=plaintext "
> 391 type:
> --
> 2222 Sh: open qute://history
> ->2223 xx: config-cycle statusbar.hide ;; config-cycle tabs.show always switching
> 2224 xt: config-cycle tabs.show always switching
2017-11-03 08:44:11 +01:00
Marcel Schilling
31e7d8dd3f
fix capitalization in configdata descriptions
...
* url -> URL
* os -> OS
* Page Cache -> page cache
* Spatial Navigation -> spatial navigation
2017-11-03 08:44:11 +01:00
Marcel Schilling
a55d12bf70
add missing periods (.) to configdata descriptions
...
* includes `valid_value` descriptions in addition to `desc` fields
2017-11-03 08:44:11 +01:00
Marcel Schilling
0c01d9b61a
fixed typos in configdata descriptions
2017-11-03 08:44:11 +01:00
Ryan Roden-Corrent
47447c047a
Ensure completions are sorted after filtering.
...
I previously removed the sorting logic from SortFilter thinking it was
unnecessary if we construct the model with a sorted list. However, this
only worked when no pattern was set, and the items are misordered as
soon as a pattern is input.
This patch reintroduces alpha-sorting, which can be disabled by passing
sort=False to the ListCategory constructor. The session completion test
had to be tweaked as it simulated the incorrect assumption that the
session list is not alpha-ordered; sessions come out of the
session-manager pre-sorted so we may as well use alpha-sorting in the
session completion model.
Resolves #3156 .
2017-11-02 22:10:00 -04:00
Florian Bruhin
acfb3aa26f
Inject JS into the profile
...
Closes #3216
2017-11-02 21:59:22 +01:00
Florian Bruhin
a14ef88acf
Remove some obsolete/deprecated eslint customizations
2017-11-02 20:00:29 +01:00
Florian Bruhin
1cf66976d2
Merge remote-tracking branch 'origin/pr/3225'
2017-11-02 19:43:04 +01:00
Florian Bruhin
bb208f4e77
Un-hide :open-editor
...
It can be used in normal mode as well, and it's nice to have it discoverable.
Fixes #3235 .
2017-11-02 19:32:45 +01:00
Florian Bruhin
5469a238de
Fix docs for new editor replacements
...
See #3100
2017-11-02 19:30:47 +01:00
Gyorgy Orban
98c6b49cde
use enum module instead or usertypes.enum
...
Remove the usertypes.enum from the source and use
the standard enum module instead.
Enum start number is available since python 3.5
2017-11-02 18:56:11 +01:00
plexigras
6e624bcd3c
Merge branch 'master' into es6ify-js
2017-11-02 16:44:25 +01:00
Florian Bruhin
9a69ccc9e3
Merge remote-tracking branch 'origin/pr/3100'
2017-11-02 11:32:45 +01:00
Florian Bruhin
3385585ca5
Merge remote-tracking branch 'origin/pr/3203'
2017-11-02 11:02:49 +01:00
Florian Bruhin
f620ffd9d4
Merge remote-tracking branch 'origin/pr/3228'
2017-11-02 09:14:49 +01:00
Florian Bruhin
1c39715267
Clarify qute://configdiff/old title
2017-11-01 22:36:59 +01:00
Gyorgy Orban
bb54a954fe
use subprocess run
...
The usage of subprocess.run is recommended since python 3.5.
Popen, check_call, call and check_output calls were replaced with run.
2017-11-01 09:59:32 +01:00
Jay Kamat
cb7e6ab02d
Abort pinned tab prompt if tab is destroyed
...
Closes #3223
2017-10-31 19:07:01 -04:00
Luca Benci
24231ae405
Remove unnecessary parens
2017-10-31 23:22:17 +01:00
Luca Benci
bc0c877b87
Formatting
2017-10-31 23:21:37 +01:00
Luca Benci
370405c0ed
Remove assert
2017-10-31 23:20:13 +01:00
Luca Benci
dcc53026a3
Stay within 79 columns
2017-10-31 23:14:07 +01:00
plexigras
fa8476f762
keep old pac_utils.js
2017-10-31 16:40:09 +01:00
plexigras
905c984148
change some lambdas to functions
2017-10-31 12:54:26 +01:00
plexigras
d4d791f14e
es6ified js
2017-10-31 11:53:35 +01:00
Florian Bruhin
0b86b302a2
pylint: Turn off some more too-many-* stuff globally
...
Humans are just better at judging what's okay here than a machine.
2017-10-31 07:35:00 +01:00
Florian Bruhin
e9483bc485
Merge remote-tracking branch 'origin/pr/3122'
2017-10-31 07:05:38 +01:00
dwagle
f70740cc3a
set original query parameters if any before redirecting to new_url
2017-10-31 11:47:06 +05:45
Ulrik de Muelenaere
95b41b311f
Disable ESLint no-bitwise rule
2017-10-30 22:24:59 +02:00
Ulrik de Muelenaere
3adc2e0f83
Add filter to NodeIterator checking for styled nodes
2017-10-30 19:56:12 +02:00
Ulrik de Muelenaere
34b27437d0
Clarify function names in stylesheet.js
2017-10-30 19:55:37 +02:00
Ulrik de Muelenaere
0540a43995
Check for deleted window
2017-10-30 19:52:15 +02:00
Jay Kamat
64b6852ae3
Fix a couple style issues
2017-10-30 12:40:44 -04:00
dwagle
aab7496916
fixes issue #3161
2017-10-30 17:09:45 +05:45
Florian Bruhin
daee729fc2
Merge remote-tracking branch 'origin/pr/3200'
2017-10-30 06:58:46 +01:00
Florian Bruhin
3d53ffb7ef
Bump up YAML load deadline some more
2017-10-30 06:55:55 +01:00
Ulrik de Muelenaere
2fe1a1db89
Remove unused variable
2017-10-29 00:23:11 +02:00
Ulrik de Muelenaere
51d48f6b00
Rewrite user stylesheet injection for WebEngine
...
This now works correctly in XML documents. The stylesheet is applied at
document creation to reduce flickering, and is updated if the
user_stylesheets setting is changed after page load.
2017-10-28 22:16:29 +02:00
Jay Kamat
2a4163b2c7
Fix ellipsis on pinned tabs with index > 10
...
See #3209
2017-10-27 17:20:55 -04:00
Luca Benci
f5f11f7f4e
Remove _ignore_change
2017-10-27 20:15:33 +02:00
Luca Benci
2947b75ab9
Make eslint happy
2017-10-27 19:52:10 +02:00
Ryan Roden-Corrent
24f466b2c3
Add --related flag to edit-url.
2017-10-26 22:13:35 -04:00
Ryan Roden-Corrent
6519f500a9
Add --private flag to edit_url.
...
The command :edit-url --private (or :edit-url -p) will spawn a new
private window with the url input from the editor.
I had to add 'Given I have a fresh instance' to the feature file to
ensure tests were not interfering.
Resolves #3185 .
2017-10-26 07:21:51 -04:00
Florian Bruhin
eee5f8263f
Merge remote-tracking branch 'origin/pr/3179'
2017-10-26 09:43:42 +02:00
Florian Bruhin
c883d6b429
Merge remote-tracking branch 'origin/pr/3196'
2017-10-26 08:46:21 +02:00
Luca Benci
ff7edf79e7
Rethrow exception if we can't handle it
2017-10-25 22:53:54 +02:00
Luca Benci
ae2dad7d18
Only catch the correct exception
2017-10-25 22:43:17 +02:00
Luca Benci
3fd7fb3e14
Do not assume elem.selectionStart exists
2017-10-25 22:38:44 +02:00
Luca Benci
f195b7e4d2
Fix flake8 failures
2017-10-25 21:18:53 +02:00
Florian Bruhin
2ab441a5a3
Merge remote-tracking branch 'origin/pr/3129'
2017-10-25 20:49:55 +02:00
lxhillwind
4c7f6e5339
Update configfiles.py: line too long fix
2017-10-26 02:04:09 +08:00
lxhillwind
66c5350989
handle <EOL> of :config-write-py
generated file
2017-10-26 00:06:53 +08:00
Florian Bruhin
ed2f473a8e
Make it more clear that :messages helps with failing processes
2017-10-24 22:56:04 +02:00
Jay Kamat
cb6f4313d7
Lower tabbar cache bound and clean up code
2017-10-24 10:18:10 -04:00
Florian Bruhin
1d18e808b1
Merge remote-tracking branch 'origin/pr/3182'
2017-10-24 09:31:25 +02:00
Florian Bruhin
43bca9793e
Merge remote-tracking branch 'origin/pr/3136'
2017-10-24 08:57:28 +02:00
siddhugolu
570f1a849f
modified as requested
2017-10-24 12:20:07 +05:30
siddhugolu
bc9d305354
modified as requested
2017-10-23 01:46:02 +05:30
siddhugolu
4862b2faf9
modified pylint pragmas
2017-10-22 23:52:35 +05:30
Luca Benci
96bbdb19e6
Add missing docstrings
2017-10-22 20:02:32 +02:00
Christopher Pezley
96eff65690
Log when url contains characters not present in current locale.
2017-10-22 18:41:29 +02:00
Florian Bruhin
bd0289423e
Merge remote-tracking branch 'origin/pr/3180'
2017-10-22 17:33:06 +02:00
Florian Bruhin
a704526582
Remove messages.unfocused
2017-10-22 17:30:47 +02:00
Michael Hoang
e5f2d27ed9
Ensure that a window with the given win_id exists
2017-10-22 08:22:45 +11:00
Luca Benci
56d29a1b5f
Avoid scheduling spurious completion updates
...
Instead of setting `_ignore_change` to `True` before calling
`_change_completed_part` we just stop `_cmd` from emitting
`update_completion`.
This has the nice side-effect that when writing a complete command
`_ignore_change` was set to `True` regardless, and thus hitting space
would not update the completion view.
Now, hitting space will (as always) schedule a completion update that
now will not be incorrectly ignored
2017-10-21 23:20:37 +02:00
Jay Kamat
49daa7aab8
Add most recent tab bar to cache statistics
2017-10-21 16:18:23 -04:00
Christopher Pezley
bdfb9c60cc
Fix issue where opening a file whose name contains characters not
...
present in locale would cause a crash.
Fixes qutebrowser/qutebrowser/1450
2017-10-21 21:01:07 +02:00
Jay Kamat
b499474599
Prevent calling _tab_pinned on every tab twice
2017-10-21 00:32:05 -04:00
Jay Kamat
caae1c7008
Fix blowing cache for different icons
2017-10-20 22:13:54 -04:00
Jay Kamat
fde4495bc7
Clear cache on config changes
2017-10-20 16:35:11 -04:00
Luca Benci
dee0799e15
Avoid crash with LC_ALL=C
and unicode filename
2017-10-20 22:06:59 +02:00
Jay Kamat
e705ea7e56
Rename _minimum_tab_size_hint_helper
2017-10-20 15:40:11 -04:00
Jay Kamat
f6cc9d53b8
Merge branch 'master' into jay/cache-tabsize
2017-10-20 15:24:22 -04:00
Florian Bruhin
128a16173e
Merge remote-tracking branch 'origin/pr/3165'
2017-10-20 09:14:41 +02:00
Florian Bruhin
5fe6e60ffd
Fix lint
2017-10-20 09:12:23 +02:00
Florian Bruhin
8504d41db3
Use Qt API for QtWebEngine scrolling
...
See #2233
Fixes #2822
2017-10-20 08:58:28 +02:00
Florian Bruhin
dd927ded6b
Only update tab/window title on scroll if needed
...
This way, if {scroll_pos} is not in the window/tab title template,
we don't redraw anything unnecessarily.
See #2233
2017-10-20 08:25:43 +02:00
Florian Bruhin
fd8e5e30c6
Re-add scroll filtering and disable it for mark/scroll tests
...
See #2233
2017-10-20 07:38:51 +02:00
Florian Bruhin
455b90ecad
Log which dictionaries have been found
...
See #3166
2017-10-20 07:14:32 +02:00
Martin Fraga
2bfa853847
Add keyhint radius configuration option
...
The radius for the keyhint dialog box should be configurable vi via
c.keyhint.radius. The default was set to 6px, which is the previous
hardcoded value.
2017-10-19 02:03:59 -07:00
Luca Benci
0436526203
Change default editor command
2017-10-18 21:08:22 +02:00
Luca Benci
cf04219f79
Rename possible_placeholder
to arg
2017-10-18 20:20:05 +02:00
Luca Benci
7907840ead
Add full stops
2017-10-18 20:19:47 +02:00
Luca Benci
addccd7492
Move comment to docstring and fix typo
2017-10-18 20:19:09 +02:00
Florian Bruhin
5a9042ab3e
Add a config.source() method
2017-10-18 13:53:26 +02:00
Florian Bruhin
354c3c8c9b
Handle unknown filetypes with qute://help
2017-10-18 09:02:39 +02:00
Luca Benci
f710536092
Move line and column calculation to own function
2017-10-17 22:48:43 +02:00
Luca Benci
233e72fef1
Adjust docstring
2017-10-17 22:38:11 +02:00
Florian Bruhin
9dc9bcaf39
Make standarddir work on HaikuOS
...
For some reason, it returns an empty DataLocation.
2017-10-17 22:37:14 +02:00
Luca Benci
e508224a46
Avoid the use of chained replace
s
2017-10-17 22:35:01 +02:00
Luca Benci
b3445bc35a
Add default value for caret_position
2017-10-17 22:08:54 +02:00
Jay Kamat
5d11a1fd75
Prevent :home from bypassing pinned tab warnings
...
Closes #3138
2017-10-17 11:37:37 -04:00
Florian Bruhin
96bec9f9d7
Fix error code for "database is locked"
...
See #2930
2017-10-17 15:35:23 +02:00
Florian Bruhin
12c9590524
Always use shortest match for completion.use_best_match
2017-10-17 15:01:37 +02:00
Florian Bruhin
161b96be1e
Fix long line
2017-10-17 13:10:00 +02:00
Florian Bruhin
2e64dda592
Clean up getting matching commands
2017-10-17 11:40:34 +02:00
Florian Bruhin
c233099bca
Merge remote-tracking branch 'origin/pr/3063'
2017-10-17 11:34:35 +02:00
Florian Bruhin
458a45c172
Remove old deprecated commands
2017-10-17 10:44:22 +02:00
Florian Bruhin
f1ddf58260
Add a deprecated :tab-detach
2017-10-17 10:30:47 +02:00
Florian Bruhin
f84af0a6fb
Fix docstring
2017-10-17 09:33:20 +02:00
Florian Bruhin
ced4713fda
Reverse if/else
2017-10-17 09:14:59 +02:00
Florian Bruhin
cce4ff6d53
Merge remote-tracking branch 'origin/pr/3054'
2017-10-17 09:10:45 +02:00
Florian Bruhin
373ad28d2e
Release v1.0.2
...
(cherry picked from commit 55a88ceea674fdfaf5577c255bc704e41e3353a3)
2017-10-17 07:46:02 +02:00
Florian Bruhin
1a7612e559
Bump up yaml timeout a bit
2017-10-17 06:28:22 +02:00
Florian Bruhin
d8384ced0a
Show better error message when trying to toggle with :set
2017-10-17 06:26:42 +02:00
Aneesh Roy
50983f01b8
New tab opens as unrelated
2017-10-16 17:14:48 +01:00
Aneesh Roy
4d780e23af
Add tabs.close_mouse_button_on_bar ignore option
2017-10-16 15:49:19 +01:00
Aneesh Roy
674269724f
Configurable behavior of close mouse button on bar
2017-10-16 15:44:52 +01:00
Florian Bruhin
e89fda189a
Fix tab sizing when we get a QPainter and not a QStylePainter
...
I'm not sure yet how that happens, but I got a crash report for that.
See #3099
2017-10-16 13:44:51 +02:00
Florian Bruhin
e766fe14fc
Fix HTML escaping in completion
2017-10-16 12:27:13 +02:00
Florian Bruhin
5307b97ca5
Improve checkpyver error message
2017-10-16 09:24:31 +02:00
Florian Bruhin
8756997dc8
Merge remote-tracking branch 'origin/pr/3099'
2017-10-16 08:30:03 +02:00
Florian Bruhin
09868c1e7f
Update docs
2017-10-16 08:17:45 +02:00
Florian Bruhin
3797b0cfed
Merge remote-tracking branch 'origin/pr/3034'
2017-10-16 08:12:15 +02:00
Florian Bruhin
3d02feac2b
Merge pull request #3118 from jgkamat/jay/git-version
...
Change qute:version git commit to display hash
2017-10-16 07:59:52 +02:00
Florian Bruhin
2a65cadb67
Fix setting monospace fonts with None values
...
Fixes #3130
2017-10-16 06:18:09 +02:00
Florian Bruhin
e003b11670
Fix overflow handling for QtWebKit scrolling
...
If we do "m * val / 100", the value gets bigger, so we need to check for an
overflow afterwards.
2017-10-15 22:30:17 +02:00
Florian Bruhin
fa4a66f7b3
Add SQLITE_READONLY to environmental errors
2017-10-15 21:10:11 +02:00
Adrien Folie
57e1135abe
fix blurry favicons on hidpi displays
2017-10-15 19:24:15 +02:00
Florian Bruhin
16b2df56df
Merge remote-tracking branch 'origin/pr/3115'
2017-10-15 00:27:14 +02:00
Florian Bruhin
f4796b5ec6
Add missing period
2017-10-15 00:22:19 +02:00
Florian Bruhin
71f48a1e30
Move statusbar colors together in configdata.yml
2017-10-15 00:21:35 +02:00
Florian Bruhin
69d4bb6c6a
Merge remote-tracking branch 'origin/pr/3119'
2017-10-15 00:20:47 +02:00
Jay Kamat
4ff44eff7b
Clean up logic for finding git hash
...
Also add implementation for release scripts as well
2017-10-14 18:08:52 -04:00
Jay Kamat
08b562ea0c
Add caching for tab sizes
2017-10-14 17:59:50 -04:00
Florian Bruhin
01d2654c23
Improve history formatting in crashdialog
2017-10-14 22:27:30 +02:00
Florian Bruhin
bad349aacf
Fix getting history in crash dialog
2017-10-14 22:23:03 +02:00
Kimat Boven
ffab9e263f
it was not possible to show the current_url in tab or window title
...
note that I couldn't use {url} as field for the FormatString
2017-10-14 22:14:01 +02:00
Florian Bruhin
5dacf1431f
eslint: Disable multiline-comment-style
2017-10-14 21:41:56 +02:00
Florian Bruhin
27c46f20c0
Make sure the config default values are mutable
...
While the old values meant the same thing, they weren't mutable, so the config
couldn't modify them with a simple .append().
Fixes #3104
2017-10-14 16:40:44 +02:00
Florian Bruhin
0195f717c3
Move QOpenGL imports to the top
...
We don't support Qt < 5.4 anymore anyways.
2017-10-14 12:11:41 +02:00
Florian Bruhin
b3f395453b
Run Nvidia shader workaround earlier
...
We need to do it before utils.opengl_vendor(), and it fits better there anyway.
This was a regression in v1.0.
See #2554 , #3106
2017-10-14 12:10:21 +02:00
sMailund
f5cccfb097
re-add erroneously removed line
2017-10-14 10:43:34 +02:00
sMailund
14005e3684
trigger color change on passthrough mode
2017-10-14 10:30:44 +02:00
sMailund
57c4285dbc
configure colorflags for passthrough mode
2017-10-14 10:29:34 +02:00
sMailund
4d2ca878ea
add color configuration to passthrough mode
2017-10-14 10:26:55 +02:00
Jay Kamat
ee3d7463f6
Change qute:version git commit to display hash
...
Replaces output of git-describe
Closes #3095
2017-10-13 23:30:07 -04:00
Florian Bruhin
d411ec1eba
Mark content.notifications as QtWebKit-only
2017-10-13 23:18:36 +02:00
Luca Benci
440740d30b
Don't crash when opening editor under webkit
2017-10-13 20:40:08 +02:00
Florian Bruhin
2872ae5641
Release v1.0.1
2017-10-13 09:21:56 +02:00
Florian Bruhin
2bf9a81451
Prevent empty segfault reports
2017-10-13 07:52:55 +02:00
Luca Benci
ad9ac2191b
Also accept {file}
placeholder
2017-10-12 23:48:49 +02:00
Luca Benci
6425061b3a
Substitute new editor.command
placeholders
...
Added placeholders are:
* `{file}` has the same function as `{}`
* `{line}` is the 1-based line number
* `{column}` is the 1-based column number
* `{line0}` like `{line}`, but 0-based
* `{column0}` like `{column}` but 0-based
2017-10-12 22:46:05 +02:00
Luca Benci
cdf4f69251
Pass caret_position
to editor's edit()
2017-10-12 22:43:31 +02:00
Luca Benci
67e41af875
Add sanity check and accessor for caret_position
2017-10-12 22:43:06 +02:00
Luca Benci
f43a597370
Add cursor_position
to serialize_elem
output
2017-10-12 22:42:40 +02:00
Florian Bruhin
bf1d6acb06
Properly fix up version checks...
2017-10-12 22:41:52 +02:00
Bryan Gilbert
0e527d2584
Consistently space + center favicons when using vertical tabs
2017-10-12 14:55:13 -04:00
Florian Bruhin
8539d092df
Fix version checking in earlyinit
...
With the previous commit, we also checked that PyQt was >= 5.7.1, but we want to
support PyQt 5.7.0. Instead, we now check the individual components by hand.
Also, the previous check accidentally allowed PyQt >= 5.2.0 instead of 5.7.0.
2017-10-12 19:41:49 +02:00
Florian Bruhin
dfe2f9e38c
Also check PyQt version for qtutils.version_check()
...
With an older PyQt built against a newer Qt, we still don't have its features
available.
This also drops support for exact=True with compiled=True as the semantics for
that are unclear, and it's not used.
2017-10-12 19:13:20 +02:00
Florian Bruhin
4f870f902c
Fix loading of monospace fonts in configtypes.QtFont
...
See #3096
2017-10-12 18:26:54 +02:00
Joakim Reinert
efef588c30
fix lints in completer
2017-10-12 14:43:22 +02:00
Panagiotis K
10388b0515
Remove an unused variable.
2017-10-12 15:16:35 +03:00
Panagiotis K
0a753915ff
Prompt for non-existing download directories.
...
Closes #2120
2017-10-12 15:00:35 +03:00
Florian Bruhin
e9f9449237
Release v1.0.0
2017-10-12 09:15:02 +02:00
Florian Bruhin
f035d4f362
Fix quote handling for fonts.monospace family
2017-10-11 22:14:58 +02:00
Florian Bruhin
a21a60c5ca
Fix updating fonts when fonts.monospace is changed
...
Fixes #2973
2017-10-11 22:14:55 +02:00
Florian Bruhin
cbe9ff7435
Fix reading of fonts.monospace on init
...
See #2973
2017-10-11 22:06:47 +02:00
Florian Bruhin
96c0cde8b8
Fix copy-paste error in colors.messages.warning.border description
2017-10-11 16:26:52 +02:00
Florian Bruhin
ba92f32e9f
Merge pull request #3073 from qutebrowser/sql-errors
...
Handle some sqlite errors gracefully
2017-10-11 14:48:01 +02:00
Florian Bruhin
64443a3eed
Fix docstrings
2017-10-11 14:40:05 +02:00
Florian Bruhin
1b5f1aaebf
Merge remote-tracking branch 'origin/pr/3055'
2017-10-11 14:37:59 +02:00
Florian Bruhin
f5e7388bfe
Improve YAML deadline warning
...
See #2777
2017-10-11 13:15:15 +02:00
Florian Bruhin
35335d954b
Show error when YAML load took too long
...
See #2777
2017-10-11 13:15:11 +02:00
Florian Bruhin
9c080538ba
Add a setting to force the platform and improve Wayland handling
...
Closes #3078
See #2932
2017-10-11 09:23:21 +02:00
Florian Bruhin
bdc82bc633
Fix lint
...
See https://github.com/PyCQA/pylint/issues/1698
2017-10-11 08:41:23 +02:00
Michael Hoang
29f66dcd95
Merge :tab-detach with :tab-give
2017-10-11 17:18:12 +11:00
Florian Bruhin
59a1609dd8
Handle RuntimeError in AbstractTab __repr__
...
Apparently it can happen that we try to get a repr of an already destroyed tab.
In that case, we display <RuntimeError> as the URL now.
2017-10-11 08:02:27 +02:00
Florian Bruhin
2a3369e2fe
Show nicer errors when trying to set deleted/renamed options
2017-10-11 08:00:38 +02:00
Florian Bruhin
0cd5d4300b
Rename qt_args and force_software_rendering to add qt. prefix
...
Closes #3077
2017-10-11 07:45:38 +02:00
Michael Hoang
67437a0d5d
Add :tab-give and :tab-take commands and tests
2017-10-11 16:27:35 +11:00
Michael Hoang
b7061dc7db
Separate logic for resolving buffers from index
2017-10-11 16:27:35 +11:00
Florian Bruhin
abbd69f604
Implement deleting/renaming values in configdata.yml
...
This is needed for #3077 , but also is used for the deletion in #2847 now.
See #2772 .
2017-10-11 07:13:51 +02:00
Anton S
fadc8f1e0b
[review] convey via_ipc from process_pos_args to get_window
2017-10-11 00:45:22 +03:00
Anton S
085304a1de
[review] removed ApplicationActivate handler due to bugs
2017-10-11 00:28:20 +03:00
Anton S
ba1a7a8de8
[review] force_raise -> no_raise
2017-10-10 23:02:10 +03:00
Florian Bruhin
4c1273ba0a
Fix indent
2017-10-10 14:59:24 +02:00
Anton S
e1f5da3eff
[review] docstrings, url logging, etc.
2017-10-10 14:13:49 +03:00
Anton S
e537826ff5
fixed docstring, converted list to set
2017-10-10 01:46:49 +03:00
Anton S
40185385cf
moved methods to restore initial order
2017-10-10 01:37:39 +03:00
Anton S
14da05f7b1
use open_url to handle FileOpen event
2017-10-10 01:31:31 +03:00
Anton S
00f0e519a9
added option to suppress window raising
2017-10-10 01:30:58 +03:00
Anton S
552d041422
reused some code from process args
2017-10-10 01:30:14 +03:00
Anton S
5301a42495
raise last focused window if requested
2017-10-10 01:00:34 +03:00
Anton S
6b7cecc840
separated window raising into it's own function
2017-10-10 01:00:33 +03:00
Florian Bruhin
8a6ea6a375
Add spaces around args with annotations
...
Looks like pylint 1.7.3/.4 notices those
2017-10-09 21:21:17 +02:00
Joakim Reinert
0226025308
add adjustable amount of chars required to update completions
2017-10-09 16:51:19 +02:00
Joakim Reinert
019d66a4c6
add adjustable delay for completion updates
2017-10-09 16:51:19 +02:00
Florian Bruhin
b5777299fd
Fix getting a short text from the SqlError
2017-10-09 16:08:56 +02:00
Florian Bruhin
b608259751
Handle some sqlite errors gracefully
...
We mark some SQL errors as "environmental", and then show those as error
messages instead of raising an exception.
Fixes #3004
Workaround for #2930
2017-10-09 16:06:24 +02:00
Luca Benci
0578349e29
Default completion.use_best_match to false
2017-10-09 11:12:42 +02:00
Luca Benci
71048a1b55
Add (and use) completion.use_best_match config
2017-10-09 11:12:37 +02:00
Luca Benci
9d0dfd5726
Always run best-matching command
2017-10-09 11:12:28 +02:00
Florian Bruhin
83aa936276
Ignore _on_history_trigger for destroyed tabs
2017-10-09 07:13:43 +02:00
Florian Bruhin
e95260092c
Add some more dwb keybindings
...
See #13
2017-10-09 07:00:59 +02:00
Florian Bruhin
0e64511d63
Split up _init_envvars from configinit.early_init
2017-10-09 06:52:14 +02:00
Florian Bruhin
f63b95c298
Fix the window.hide_wayland_decoration setting
...
Fixes #2267
2017-10-09 06:50:29 +02:00
Florian Bruhin
220d1be500
Fix docstring
2017-10-08 23:10:08 +02:00
Florian Bruhin
36ef68c698
Add :bind --default
...
Closes #3059
2017-10-08 21:48:48 +02:00
Florian Bruhin
8c1e95787d
Improve error message for PercOrInt
...
Fixes #3068
2017-10-08 19:47:05 +02:00
Florian Bruhin
6c3f90146f
Make qtutils.version_check strict by default
...
This also renames 'strict' to 'compiled' to be more descriptive.
It also fixes a crash when starting qutebrowser with an older compiled Qt
version which was introduced recently (calling setSpellCheckEnabled).
2017-10-08 19:08:37 +02:00
Florian Bruhin
1d1faf8d25
Merge remote-tracking branch 'origin/pr/2940'
2017-10-08 16:53:10 +02:00
Florian Bruhin
1d7af2e74b
Use double quotes to avoid escaping
2017-10-08 15:25:21 +02:00
Florian Bruhin
277daa334d
Merge remote-tracking branch 'origin/pr/2891'
2017-10-08 15:23:01 +02:00
Florian Bruhin
e63d11527d
Get rid of CommandRunner.run_safely_init
...
All messages are queued nowadays.
2017-10-08 14:42:42 +02:00
Florian Bruhin
51ea56375e
Improve error handling for config commands
...
- Use self._handle_config_error() for key commands too
- Catch getting an invalid key properly
- Remove (wrong) "set: " prefix
2017-10-08 14:40:10 +02:00
Florian Bruhin
8d34d4d4f5
Turn on overflow checking in sip
2017-10-08 12:58:28 +02:00
Bryan Gilbert
be3727a599
Improved zoom level management and enforcement
2017-10-06 20:30:06 -04:00
Michal Siedlaczek
4bac2f3e44
Initialize profiles with spellchecking turn on by default.
2017-10-06 07:58:26 -04:00
Florian Bruhin
54e5176f28
Revert "Only emit perc_changed signal when the percentage actually changed"
...
This reverts commit 1d50c2c39a
.
This breaks various end2end test relying on getting log messages for scrolling.
2017-10-06 10:16:41 +02:00
Florian Bruhin
1d50c2c39a
Only emit perc_changed signal when the percentage actually changed
...
QtWebEngine emits scrollPositionChanged a lot during smooth scrolling, and
there's no reason we need to update percentages when they didn't *actually*
change.
This reduces the updates with a single spacebar press from 6-7 to 2-3 on my
machine, which might not be enough though.
See #2233
2017-10-06 08:51:48 +02:00
Florian Bruhin
2651688ef4
Only show customized options for :config-unset completion
2017-10-05 18:40:34 +02:00
Florian Bruhin
618586f8b0
Merge branch 'config-write-py'
2017-10-05 11:30:50 +02:00
Florian Bruhin
712e4a975a
Add a test to make sure :write-config-py files actually work
2017-10-05 10:48:14 +02:00
Florian Bruhin
ade0e1bd0b
Finish ConfigPyWriter and tests
2017-10-05 10:21:31 +02:00
Florian Bruhin
231b0522ca
Refactor write_config_py
2017-10-05 09:01:33 +02:00
Florian Bruhin
8dc34cf78a
Write commented lines with :write-config-py when writing defaults
2017-10-05 08:50:41 +02:00
Anton S
91c6847e59
[review] style fixes
2017-10-05 01:49:13 +03:00
Florian Bruhin
763d035ee3
Add environment variables to skip backendproblem checks
...
This is usually a bad idea, but might be useful in some special situations.
2017-10-04 22:25:14 +02:00
Michal Siedlaczek
c5d695b59e
Remove spellcheck.enabled option.
2017-10-04 09:54:59 -04:00
Michał Siedlaczek
e20ad95666
Merge branch 'master' into spell
2017-10-04 09:47:42 -04:00
Michal Siedlaczek
6a486058c5
Review fixes
2017-10-04 09:22:35 -04:00
Florian Bruhin
36857d9250
Remove valid values for Bool from docs
2017-10-04 11:46:42 +02:00
Florian Bruhin
6fa001481d
Add some comments to generated config.py
2017-10-04 11:43:14 +02:00
Florian Bruhin
7fc5e42cca
Initial :config-write-py implementation
2017-10-04 11:14:24 +02:00
Florian Bruhin
f0c0fea281
Merge branch 'pr/3025'
2017-10-04 09:28:40 +02:00
Florian Bruhin
208b4d1cbc
Make configfiles.YamlConfig iteration deterministic
2017-10-04 08:47:10 +02:00
Florian Bruhin
42550cd2e6
Merge remote-tracking branch 'origin/pr/3048'
2017-10-04 06:47:48 +02:00
Florian Bruhin
ae4d5153b9
Add missing docstring
2017-10-04 06:47:08 +02:00
Florian Bruhin
cdf0cf56fa
Merge remote-tracking branch 'origin/pr/3056'
2017-10-04 06:45:08 +02:00
Florian Bruhin
8c660d1bf4
Add a :version command
2017-10-04 06:23:15 +02:00
Ryan Roden-Corrent
4a9e22163b
Filter keyhints based on count prefix.
...
If a count prefix is given, only hint commands that can take a count.
2017-10-03 22:15:21 -04:00
Ryan Roden-Corrent
5d787c84ea
Show keyhint even with count prefix.
...
The keyhintwidget was not showing up when a keychain was prefixed with a
count. For example, 'g' would show a keyhint but '5g' would not. Now
keyhints are shown even when a count is given.
Resolves #3045 .
2017-10-03 22:04:53 -04:00
Michal Siedlaczek
932e7a9ab9
Review fixes
2017-10-03 20:07:06 -04:00
Florian Bruhin
feaccb3083
Rename :scroll-perc to :scroll-to-perc
...
Closes #2819
2017-10-03 22:59:32 +02:00
Florian Bruhin
7f28097f55
Be explicit about constraints instead
2017-10-03 22:17:29 +02:00
Florian Bruhin
d70bdb5552
Honour --no-err-windows in more places
...
Fixes #3053
2017-10-03 21:28:55 +02:00
Florian Bruhin
6c2958b646
Set star_args_optional for :config-cycle
2017-10-03 20:49:16 +02:00
Florian Bruhin
22088d9f7b
Remove --force for :bind and config.bind(...)
...
Turns out --force is just in the way for most people, and at least for default
bindings it's easy to reset them.
Also, it makes :config-source fail when config.py contains keybindings.
Closes #3049
2017-10-03 20:43:38 +02:00
Florian Bruhin
727580d1f4
Add a :config-edit command
...
See #2794
2017-10-03 20:43:38 +02:00
Florian Bruhin
555930791f
Refactor ExternalEditor to be able to edit an existing file
2017-10-03 19:24:04 +02:00
Michael Hoang
8506e1f4f2
Add arg to run when count given for :set-cmd-text
2017-10-04 03:57:23 +11:00
Florian Bruhin
8edaad51c3
Add a :config-source command
...
See #2794
2017-10-03 16:28:11 +02:00
Florian Bruhin
ed8c3f4aa2
Add :config-clear and :config-unset
...
See #2794
2017-10-03 12:45:39 +02:00
Florian Bruhin
31f49afdb2
Fix incorrect docstring
2017-10-03 10:28:36 +02:00
Florian Bruhin
1603b15cfd
Default to NOT NULL for table constraints
...
Ideally, we'd update all existing tables to add the new constraints, but sqlite
doesn't offer an easy way to do so: https://www.sqlite.org/lang_altertable.html
Since that migration really isn't worth the effort, we only set the constraint
for new tables...
2017-10-03 10:28:36 +02:00
Florian Bruhin
b06a38ce7e
Reorder methods
...
(cherry picked from commit ba9bd292dbc43bf0ad382a1ef060c87ee651b5d7)
2017-10-03 10:28:19 +02:00
Florian Bruhin
ad867a3b90
Merge branch 'pr/3024'
2017-10-03 10:17:01 +02:00
Florian Bruhin
58bef6ba97
Regenerate docs
2017-10-03 10:16:41 +02:00
Florian Bruhin
f533e3b751
Move config toggling to :config-cycle
...
This removes :set option! and allows :config-cycle option instead.
2017-10-03 07:38:10 +02:00
Florian Bruhin
81993a70a2
Split off :config-cycle from :set
...
Before, we allowed :set to take multiple values, which often lead to confusing
error messages when a user forgot to quote the value.
Now, we instead have a dedicated :config-cycle command for that.
See #1840 , #2794
2017-10-03 07:37:55 +02:00
Michael Hoang
138ce60c1d
Add count support to buffer command
2017-10-02 23:44:04 +11:00
Florian Bruhin
5af8a95c82
Refactor SQL error handling
...
This renames SqlException to SqlError (to be more consistent with how Python
names exceptions), and adds an utility function which logs a few more useful
details about errors.
See #3004
2017-10-02 09:48:15 +02:00
Florian Bruhin
85532248fa
Merge remote-tracking branch 'origin/pr/2879'
2017-10-02 09:05:01 +02:00
Florian Bruhin
14dacbaa92
Fix typo
2017-10-02 07:49:31 +02:00
Florian Bruhin
0df4569502
Merge remote-tracking branch 'origin/pr/2847'
2017-10-02 07:49:20 +02:00
Florian Bruhin
a8fc561707
Split config commands off to their own file.
2017-10-02 07:08:30 +02:00
Florian Bruhin
a273baf8a0
Make sure :bind/unbind works properly when bindings.commands is None
...
To make this work, we should never return None when trying to get bindings to
modify.
Fixes #3026
2017-10-01 21:43:00 +02:00
Florian Bruhin
0fbd914432
Fix completion for empty config values
...
If we have an empty string in the completion, that already gets completed as ''.
If we return "", we'd have '""' in the completion.
Fixes #3027
2017-10-01 20:14:49 +02:00
Anton S
ab6bfe61b8
[osx] first step to become default browser
2017-10-01 00:39:13 +03:00
Florian Bruhin
1a381bf0a5
eslint: Report unused disables
2017-09-29 22:29:18 +02:00
Florian Bruhin
0b5af757ec
Clarify settings which need a restart
...
[ci skip]
2017-09-28 21:51:07 +02:00
Florian Bruhin
322d97c3fa
Only show warning message stack with --debug
2017-09-28 21:30:32 +02:00
Florian Bruhin
5c181a23ab
Fix default prompt color
...
The former value was interpreted as a comment in the YAML...
2017-09-28 21:24:12 +02:00
Florian Bruhin
02bcec37f4
Darken default prompt color a bit more
2017-09-28 19:20:29 +02:00
Florian Bruhin
9d963d55f5
Fix :debug-cache-stats with QtWebEngine
...
When we use --backend webengine, the QtWebKit stuff might be importable, but the
history still isn't initialized because of that.
2017-09-28 17:42:21 +02:00
Florian Bruhin
6c25e96621
Remove unused imports
2017-09-28 11:38:52 +02:00
Florian Bruhin
865fc2e0de
Handle -s argument earlier
...
This makes sure we can e.g. set software_rendering via -s
2017-09-28 10:10:14 +02:00
Florian Bruhin
6770a474c4
Force software rendering earlier
...
We need to do this before a QApplication exists
2017-09-28 09:52:56 +02:00
Florian Bruhin
35beb84e85
Fix tests and lint
2017-09-28 09:38:57 +02:00
Florian Bruhin
f077f52997
Add asserts for the backend
2017-09-28 08:57:48 +02:00
Florian Bruhin
c77cff3fcb
Also fail with DISPLAY with wayland platform plugin
...
QtWebEngine spews errors at us, and while it seems to work with Weston for some
reason (despite errors logged), it doesn't with sway.
2017-09-28 08:56:05 +02:00
Florian Bruhin
b906c862bb
Remove ipc-server from objreg
2017-09-28 08:52:32 +02:00
Florian Bruhin
ce0622e38a
Document how initialization roughly works
2017-09-28 08:41:10 +02:00
Florian Bruhin
e5958e6061
Override --backend argument from backend problem dialog
2017-09-28 08:41:10 +02:00
Florian Bruhin
defcf5394a
Move SSL backend checking to backendproblem.py
2017-09-28 08:41:10 +02:00
Florian Bruhin
fa902c5d82
Improve error dialogs when QtWebKit/QtWebEngine was not found
2017-09-28 08:41:10 +02:00
Florian Bruhin
093f34183c
Add improved checks for Nouveau/Wayland for QtWebEngine
...
Closes #2368
Closes #2932
See #2335
2017-09-28 08:41:10 +02:00
Florian Bruhin
ca4a997559
Update settings for QtWebEngine by default
...
See #2335
2017-09-28 08:41:10 +02:00
Jay Kamat
bb8d41cedc
Add indicator padding to minimumTabSizeHint
...
Previously, indicator_padding was not taken into account, causing
problems when using a indicator_padding too small
Also removed icon padding to width calculation (seemed to be overestimating)
2017-09-27 21:04:06 -04:00
Florian Bruhin
e1f3829383
Cache the completion delegate stylesheet
...
We removed various caches in b5eac744b5
but the
completion delegate stylesheet gets rendered a lot, causing things to slow down.
The rendering takes around 1ms, but it gets done ~10k times with a simple
profiling run, so that adds up quickly.
We don't use a functools.lru_cache here as the stylesheet template never
changes.
Thanks a lot to gilbertw1 for tracking this down!
See #2812 - there's probably more possible, but this should fix the performance
regression some people saw with the new config.
2017-09-27 23:16:40 +02:00
Florian Bruhin
fac322058e
Improve crashdialog result codes
2017-09-27 11:46:51 +02:00
Florian Bruhin
6573888dc6
Fix :bind completion with invalid commands
...
Now that Command doesn't validate things anymore, we can't rely on parsing to
work.
2017-09-27 11:10:25 +02:00
Florian Bruhin
fef1a65247
Fix ListOrValue.to_doc signature
2017-09-27 10:37:42 +02:00
Florian Bruhin
9607f3de59
Improve type documentation of settings
...
Use .get_name() for the docs
2017-09-27 08:25:52 +02:00
Florian Bruhin
c694bff902
Allow direct values for url.start_pages and content.user_stylesheets
2017-09-27 08:21:03 +02:00
Jay Kamat
cc84c1722d
Merge remote-tracking branch 'upstream/master' into jay/remote-pintab-width
2017-09-26 18:07:10 -04:00
Jay Kamat
59c6555537
Remove the tabs.width.pinned setting
2017-09-26 18:06:23 -04:00
Florian Bruhin
2dfcf9c506
Remove unused imports
2017-09-26 21:37:20 +02:00
Florian Bruhin
b879f5e648
Slightly re-style prompts
...
See #2104
2017-09-26 21:28:01 +02:00
Florian Bruhin
6af879887f
Drop --relaxed-config
2017-09-26 20:12:21 +02:00
Florian Bruhin
8e000dfe54
Make qute://configdiff usable with the new config too
...
Closes #2983
2017-09-26 19:39:47 +02:00
Florian Bruhin
1704438777
Reintroduce crash dialogs for QtWebKit
2017-09-26 19:25:53 +02:00
Florian Bruhin
6b5d34c7fb
Fix updating of stylesheet when scrolling.bar is set
...
Fixes #2981
2017-09-26 11:28:40 +02:00
Florian Bruhin
277beae399
Merge branch 'pr/2984'
2017-09-26 08:48:45 +02:00
Florian Bruhin
38449e3e2b
Make sure the autoconfig.yml is saved periodically
...
Fixes #2982
2017-09-26 06:41:55 +02:00
Florian Bruhin
38038df703
Compare objects with :set with multiple values
2017-09-25 21:24:12 +02:00
Florian Bruhin
6aed6bca93
Make loading autoconfig.yml opt-in when a config.py exists
...
This lets the user control the precedence those files should have, and also
simplifies the code quite a bit.
Fixes #2975
2017-09-25 21:24:12 +02:00
Ian Walker
ad2bb45446
Allow user to cancel proxy authentication request
2017-09-25 15:00:17 +09:00
Ian Walker
78bddaefe6
Move _on_proxy_authentication_required to WebEngineTab
2017-09-25 14:47:54 +09:00
Florian Bruhin
07862ce52e
Merge branch 'pr/3029'
2017-09-25 06:57:02 +02:00
Florian Bruhin
8408d6ed9b
Fix emacs syntax highlighting in configdata.yml
2017-09-25 06:56:33 +02:00
Florian Bruhin
40f0f75ad5
Improve error message for duplicate keys in config.py
2017-09-24 19:43:30 +02:00
arza
cb68e4b6b2
Remove extra backslashes in configdata.yml
2017-09-23 22:58:30 +03:00
arza
1784dc777d
Add table headers and widen input fields in qute://settings
2017-09-23 22:24:17 +03:00
Ryan Roden-Corrent
888a1b8c57
Append multiple history backups on import.
...
Previously, a successful import of the text history into sqlite would
move 'history' to 'history.bak'. If history.bak already existed, this
would overwrite it on unix and fail on windows.
With this patch, the most recently imported history is appended to
history.bak to avoid data loss.
Resolves #3005 .
A few other options I considered:
1. os.replace:
- fast, simple, no error on Windows
- potential data loss
2. numbered backups (.bak.1, .bak.2, ...):
- fast, no data loss, but more complex
3. append each line to the backup as it is read:
- more efficient than current patch (no need to read history twice)
- potentially duplicate data if backup fails
2017-09-23 13:06:11 -04:00
Ian Walker
e2e9bbacce
Move _on_proxy_authentication_required to WebEngineTab
2017-09-23 17:26:41 +09:00
Florian Bruhin
b8389e4496
Revert "Fix NUL byte error handling on Python 3.4"
...
This reverts commit a7d5a98cc4
.
Not needed anymore now that we dropped support.
2017-09-22 22:30:02 +02:00
Florian Bruhin
5be44756e3
Remove unused imports
2017-09-22 17:29:01 +02:00
Michal Siedlaczek
b840b8066b
Spell only when pyqt>=5.8
2017-09-22 11:16:59 -04:00
Florian Bruhin
1e2015be65
Make bindings win over mappings
...
Fixes #2995
2017-09-22 17:13:17 +02:00
Florian Bruhin
d5a1fff637
Move init stuff from config.py to configinit.py
...
Closes #2997
2017-09-22 14:11:54 +02:00
Florian Bruhin
d1a4a028cd
Use more idiomatic comparison
2017-09-22 13:24:26 +02:00
Florian Bruhin
501764d1cb
Fix documented default values for falsey non-strings
...
Fixes #3015 .
2017-09-22 13:18:27 +02:00
Florian Bruhin
7f8ae531aa
Add config.configdir and config.datadir to config API.
...
Fixes #1419
2017-09-22 09:59:46 +02:00
Florian Bruhin
9b22480b07
Raise config.py errors happening in tests
2017-09-22 09:09:45 +02:00
Jay Kamat
43ce10efc3
Simplify and reorganize configfile tests
...
Also make save/load of sys.path a little more robust
2017-09-22 02:05:55 -04:00
Jay Kamat
4e22b4666d
Convert save-restore of sys to a context-manager
...
Also improve and simplify tests for save/load of sys.module and sys.path
2017-09-22 02:05:55 -04:00
Jay Kamat
7ddde334da
Add tests for module/path isolation
2017-09-22 02:05:55 -04:00
Jay Kamat
333c0d848b
Restructure save/load of state to be more extensible
...
Also save/load sys.modules as well
- This is a little rough, but I can't find a better way...
2017-09-22 02:05:54 -04:00
Jay Kamat
0332dce458
Get config path from config.py location, rather than standarddir
2017-09-22 02:05:54 -04:00
Jay Kamat
a2952e13a8
Add qutebrowser config directory to python path
...
This is done so config.py can import other python files in the config
directory. For example, config.py can 'import theme' which would load
a theme.py.
The previous path is restored at the end of this function, to avoid
tainting qutebrowser's path
2017-09-22 02:05:52 -04:00
Florian Bruhin
f4017eb5b6
Ignore more Python warnings when importing in earlyinit
...
With a17c4767d6
we moved the first time
pkg_resources is imported to earlyinit.py, which means less warnings were
suppressed.
Fixes #2990
2017-09-21 23:24:22 +02:00
Florian Bruhin
599a5b9648
Remove windows/pip instructions from earlyinit
...
Windows: The instructions are outdated and not really relevant anymore with the
standalone packages;
pip: Let's recommend tox/virtualenv by just linking to the install docs.
Closes #2998
2017-09-21 22:48:15 +02:00
Florian Bruhin
1c76a51c1e
Improve configtypes.Command docs
2017-09-21 22:31:11 +02:00
Michal Siedlaczek
396f82d474
Valid dictionaries
2017-09-21 16:30:58 -04:00
Florian Bruhin
64b783d9c0
Do not validate commands in the config and with :bind
...
There are just way too many gotchas related to valid modes, aliases, and
circular dependencies when validating aliases/bindings in the config.
Let's just remove this and let invalid commands fail late, when they're actually
used.
2017-09-21 22:30:48 +02:00
Florian Bruhin
f97f427100
Add an assertion for Completer._partition
2017-09-21 21:50:33 +02:00
Michal Siedlaczek
9e620ce6e9
Fix spell with new config
2017-09-21 12:09:55 -04:00
Florian Bruhin
7cad8f41f2
Remove unknown YAML data from config
...
I considered introducing another list of deleted options (or a "deleted: True"
in configdata.yml), similar to what we had with the old config.
However, let's take the easier route and just delete everything we don't know
from configdata.yml. If someone edits it by hand, it's their fault :P
See #2772 , #2847
2017-09-21 16:29:40 +02:00
Michal Siedlaczek
132b1f705e
Revert requirements changes
2017-09-21 09:56:38 -04:00
Michal Siedlaczek
329cfa5756
End2end tests for spell checking
2017-09-21 09:56:33 -04:00
Michal Siedlaczek
cf229cb9c8
Dictionary path bug fix & added warning whenever a selected dictionary isn't installed
2017-09-21 09:56:27 -04:00
Michal Siedlaczek
e61e6b124e
Check if spelling supported by QWebEngineProfile (version 5.8 or higher)
2017-09-21 09:56:27 -04:00
Michal Siedlaczek
95592770a7
Fixing test dependencies and other test issues
2017-09-21 09:53:51 -04:00
Michal Siedlaczek
fac0e44a7e
Test all available languages and getting installed langs when the dir doesn't exist
2017-09-21 09:52:31 -04:00
Michal Siedlaczek
82433e04ad
Set default value for spelling settings and limit number of installed languages for testing
2017-09-21 09:52:09 -04:00
Michal Siedlaczek
d923ab9ae5
Moved and renamed the language list file
2017-09-21 09:51:52 -04:00
Michal Siedlaczek
c2197102a3
Enable spell checking and installing dictionaries for QtWebEngine
2017-09-21 09:51:52 -04:00
Florian Bruhin
a559477028
Merge remote-tracking branch 'origin/pr/2953'
2017-09-21 13:43:01 +02:00
Florian Bruhin
53b1ffe953
Merge remote-tracking branch 'origin/pr/2965'
2017-09-21 09:12:56 +02:00
Florian Bruhin
fb33985f07
Merge remote-tracking branch 'origin/pr/2992'
2017-09-21 09:12:03 +02:00
Florian Bruhin
106edc953a
Merge branch 'is-os'
2017-09-21 08:57:32 +02:00
Jay Kamat
d5c2f2855a
Clean up pinned_tab width implementation
...
Misc fixes from PR
2017-09-20 20:48:48 -04:00
Jay Kamat
e49aa35c75
Remove pinned_width variables
...
Now it calculates the number of pinned tabs directly, instead of
keeping track of a variable. Potentially slower though.
2017-09-20 11:31:05 -04:00
Jay Kamat
da57d21f0c
Remove pinned-width from config
2017-09-20 11:31:05 -04:00
Jay Kamat
b46f116075
Switch pinned tabs to use their title width
...
Previously, their width was determined by a config setting
Closes #2845
2017-09-20 11:31:03 -04:00
Florian Bruhin
9d360f80cf
Use __attrs_post_init__ to validate ArgInfo
...
This makes qutebrowser compatible with attrs < 17.1.0, such as attrs 16.3.0
coming with Debian Stretch.
2017-09-20 17:27:28 +02:00
Penaz91
6132a3d7ca
Made _handle_auto_insert_mode public
2017-09-20 15:52:07 +02:00
Penaz91
7f03b0d0d5
Deleted a commented-out line
2017-09-20 13:37:40 +02:00
Penaz91
ccba76f757
Fix for Issue #2879
2017-09-20 13:31:44 +02:00
Ryan Roden-Corrent
5cd00f699e
Resolve KeyError when deleting URL with space.
...
Resolves #2963 .
2017-09-20 07:15:59 -04:00
Ryan Roden-Corrent
f9440b8026
Use CommandParser for configmodel.bind.
...
The parsing bind() did manually is now available through CommandParser.
Resolves #2952 .
This also adds a unit test for the case when there is no current
binding, as I broke that while working on this and there was no test to
catch it :)
2017-09-20 07:05:38 -04:00
Florian Bruhin
ef1c83862b
Use utils.is_* for platform checks everywhere
2017-09-20 11:10:24 +02:00
Florian Bruhin
e4594bd688
Use attributes for utils.is_*
2017-09-20 11:10:23 +02:00
Florian Bruhin
9ddc59e8e5
Also add utils.is_posix()
2017-09-20 11:10:23 +02:00
Florian Bruhin
e50ab3f72c
Merge remote-tracking branch 'origin/pr/2972'
2017-09-20 10:08:08 +02:00
Felix Van der Jeugt
285b534384
make changed dirty and save on duplicate write
2017-09-20 10:04:34 +02:00
Florian Bruhin
31bd4d7ffe
Make sure ProxyId is hashable
...
Fixes proxy auth with QtWebEngine
2017-09-20 09:30:58 +02:00
Florian Bruhin
10c84dfb90
Use unpacking to access config mutables
2017-09-20 08:52:11 +02:00
Florian Bruhin
55cbb39127
Merge remote-tracking branch 'origin/pr/2999'
2017-09-20 08:48:22 +02:00
Florian Bruhin
50b19462f4
Bring back accidentally deleted hunk
2017-09-20 08:17:04 +02:00
Florian Bruhin
ba1cf06be6
Reintroduce handling for typing.Union.__union_params__
...
Looks like Python 3.5.2 doesn't have typing.Union.__args__.
2017-09-20 08:17:04 +02:00
Florian Bruhin
1d2d31d0f9
Remove duplicate key mapping
2017-09-20 08:17:04 +02:00
Ian Walker
a3456c41e4
Mark url argument as unused
2017-09-20 12:51:38 +09:00
Ryan Farley
dd4294de03
fix #2979 : use dictionary for mutable tracking
...
Using a dictionary instead of a list keeps only one working copy,
allowing consistency in between calls of update_mutables()
2017-09-19 16:26:02 -05:00
Florian Bruhin
3a5241b642
Start using attrs
...
Closes #1073
2017-09-19 22:21:45 +02:00
Ryan Farley
a530b0cc95
fixed iteration
2017-09-19 14:19:28 -05:00
Ryan Farley
cc540bb166
Merge branch 'master' into mutable-dict
2017-09-19 14:07:46 -05:00
Felix Van der Jeugt
8e14d1b7e6
remove unused import
2017-09-19 17:47:38 +02:00
Felix Van der Jeugt
8db630d358
don't copy values but set dirty
2017-09-19 17:26:03 +02:00
Felix Van der Jeugt
7b192d426e
add unit test and fix issues with it
2017-09-19 15:30:28 +02:00
Felix Van der Jeugt
0e743f0e09
save only a changed autoconfig file
2017-09-19 14:33:34 +02:00
Florian Bruhin
1a1a6ebf79
Improve bind documentation
...
[ci skip]
2017-09-19 13:56:29 +02:00
Florian Bruhin
248afde21e
configapi: Also allow mode as posarg
2017-09-19 13:18:44 +02:00
Florian Bruhin
7d1549aaeb
Make mode optionally in ConfigAPI.bind and .unbind
2017-09-19 13:14:41 +02:00
Florian Bruhin
40b26d7492
Always require QtOpenGL
...
It makes it a bit easier to explain things, and it makes the transition to
QtWebEngine smoother.
2017-09-19 08:16:26 +02:00
Florian Bruhin
43ff79be0b
Merge branch 'drop-legacy'
2017-09-18 23:07:58 +02:00
Florian Bruhin
8ae87bbde2
Remove typing module from version.py
...
It comes with python now
2017-09-18 23:06:49 +02:00
Florian Bruhin
b1b6c462c1
Add a backend setting
...
See #2589
2017-09-18 23:02:08 +02:00
Florian Bruhin
61e183d9bb
Fix indent
2017-09-18 23:01:18 +02:00
Florian Bruhin
cd701e95fa
Reintroduce __hash__ for CertificateErrorWrapper
2017-09-18 23:01:18 +02:00
Florian Bruhin
5c0ebc1f94
Fix lint
2017-09-18 23:01:18 +02:00
Florian Bruhin
3772dc5930
Drop legacy QtWebKit support
...
See #2742
2017-09-18 23:01:17 +02:00
Florian Bruhin
3e70bf5af9
Make sure we never compare against an uninit'ed backend
2017-09-18 23:01:17 +02:00
Florian Bruhin
5298d14084
Move backend initialization to config.py
2017-09-18 23:01:17 +02:00
Florian Bruhin
01da144a03
Revert ipc.py socket opts handling
2017-09-18 23:01:17 +02:00
Florian Bruhin
a17c4767d6
Check libraries before Qt version
...
Importing qtutils for version_check needs pkg_resources, so we need to check
that's available earlier.
Also, import pkg_resources also shows warnings on older setuptools versions
because of invalid escapes, so we need to import it with warnings suppressed.
2017-09-18 23:01:17 +02:00
Florian Bruhin
db807a1bbc
Reintroduce downloadview workaround
...
This still seems to be an issue on AppVeyor
2017-09-18 23:01:17 +02:00
Florian Bruhin
cf07bfc5c5
Make sure the :set-cmd-text command is registered
2017-09-18 23:01:17 +02:00
Florian Bruhin
505321c336
Drop support for Python 3.4
...
See #2742
2017-09-18 23:01:17 +02:00
Florian Bruhin
852baaa8c3
Drop support for Qt < 5.7.1
...
See #2742
2017-09-18 23:01:17 +02:00
Florian Bruhin
ee4d92364e
Fix off-by-one issue for odd/even tabs
2017-09-18 14:29:14 +02:00
Ian Walker
9867200c38
Change username/password prompt for proxyAuthenticationRequired
...
Update webview.py to more closely follow the webkit/networkmanager.py
on_proxy_authentication_required().
2017-09-18 15:55:44 +09:00
Florian Bruhin
8e2b2d113b
Improve explanations for dicts in the config
2017-09-18 06:25:39 +02:00
Ryan Farley
c6ea0f8372
Use dictionary for configuration mutable storage
...
Includes a test for persistence of intermediate mutations in a
configuration file (i.e. more than one update) and a switch of the
_mutable attribute in configurations to a dictionary of (old, new)
values rather than (name, old, new). get_obj() now checks for an
existing mutable value and returns a reference to that value, only
making an initial copy; this preserves changes between update_mutables()
2017-09-17 16:07:52 -05:00
Florian Bruhin
66e4c3286a
Fix lint
2017-09-17 22:53:32 +02:00
Florian Bruhin
fe05947b54
Add a new qt_args setting
...
See #2589
2017-09-17 22:53:27 +02:00
Florian Bruhin
34042522f1
Set default hints font in pt and not px
2017-09-17 22:13:13 +02:00
Florian Bruhin
2398a58526
Fix more file move issues
2017-09-17 21:54:42 +02:00
Florian Bruhin
4c616a5733
Move all documentation files to doc/
2017-09-17 21:27:38 +02:00
Florian Bruhin
3e0ca5d94d
Stop using objreg for state-config
2017-09-17 21:04:34 +02:00
Florian Bruhin
70b8585e95
Move qtutils.unset_organization to standarddir
2017-09-17 20:44:08 +02:00
Florian Bruhin
6f1b8bd1d9
Make sure the config is available before the QApplication
...
See #2589
2017-09-17 20:06:35 +02:00
Florian Bruhin
e4d05e3fec
Log error information when config init fails
2017-09-17 14:13:36 +02:00
Florian Bruhin
f85f4630ff
Turn off SQL history writing during end2end tests
...
This hopefully makes them a bit faster, and also should help with weird hangs we
had in tests.
2017-09-17 10:58:30 +02:00
Florian Bruhin
7ed64efa08
Fix standarddir.cache() on Windows
2017-09-17 10:35:05 +02:00
Florian Bruhin
df9726a152
Fix standarddir without AppDataLocation
2017-09-17 09:49:06 +02:00
Lakshay Kalbhor
813a7b2c3a
Removed if statements
2017-09-17 10:56:53 +05:30
Lakshay Kalbhor
476ca6d42f
Added 'startswith()' to each OS
2017-09-17 10:27:21 +05:30
Florian Bruhin
9706dcbda5
Fix lint
2017-09-16 23:48:02 +02:00
Florian Bruhin
a1fa40f067
Remove the ability to migrate old QtWebEngine data
...
Versions before v0.9.0 (which didn't even support hinting with QtWebEngine!)
used to write QtWebEngine data to:
~/.local/share/qutebrowser/qutebrowser/QtWebEngine/Default
~/.cache/qutebrowser/qutebrowser/QtWebEngine/Default
In v0.9.0 this was changed to:
~/.local/share/qutebrowser/webengine
~/.cache/qutebrowser/webengine
Now we don't try to migrate data from the old location anymore.
2017-09-16 23:48:02 +02:00
Florian Bruhin
a85e19a5e1
Add initial support for early standarddir init
...
See #2589 , #2791
2017-09-16 23:47:22 +02:00
Florian Bruhin
046a16f924
Bind <Ctrl-Shift-N> and <Ctrl-Shift-W> by default
...
See #2954
2017-09-16 22:22:36 +02:00
Lakshay Kalbhor
c5ceb6b880
Added functions to check OS/Platform
2017-09-16 19:23:05 +05:30
Florian Bruhin
0ae1f5909d
Strip the old text for configdiff
...
This means we don't report an unneeded whitespace hunk anymore.
2017-09-16 14:41:37 +02:00
Florian Bruhin
2afd7549bc
Encode Unicode in old config as escapes
...
This seems to fix #2971 .
2017-09-16 14:39:37 +02:00
Florian Bruhin
714c18db0e
Fix \b escapes in old config file
2017-09-16 14:20:08 +02:00