rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Test all available languages and getting installed langs when the dir doesn't exist

Browse Source
This commit is contained in:
Michal Siedlaczek 2017-08-12 16:09:52 -07:00
parent 82433e04ad
commit fac0e44a7e
2 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qutebrowser/browser/webengine/spell.py
View File

@ -95,6 +95,8 @@ def get_available_languages():
def get_installed_languages():
"""Return a list of Language objects of all installed languages."""
if not os.path.isdir(get_dictionary_dir()):
return []
installed_files = [os.path.basename(file)
for file in os.listdir(get_dictionary_dir())]
all_languages = get_available_languages()

21
tests/unit/browser/webengine/test_spell.py
View File

@ -19,7 +19,7 @@
from os.path import basename
#from requests import head
from requests import head
import pytest
@ -38,6 +38,13 @@ POLISH = spell.Language('pl-PL',
LANGUAGE_LIST = [AFRIKAANS, ENGLISH, POLISH]
def test_get_installed_languages(mocker):
# return an empty list if the dir doesn't exist
mocker.patch('qutebrowser.browser.webengine.spell.get_dictionary_dir',
lambda: '/some-non-existing-dir')
assert spell.get_installed_languages() == []
def test_get_available_languages():
language_list = spell.get_available_languages()
assert len(language_list) == 42
@ -64,13 +71,13 @@ def test_install(tmpdir, mocker):
mocker.patch('qutebrowser.browser.webengine.spell.get_dictionary_dir',
lambda: str(tmpdir))
spell.install(LANGUAGE_LIST)
installed_files = [basename(file) for file in tmpdir.listdir()]
installed_files = [basename(str(file)) for file in tmpdir.listdir()]
expected_files = [lang.file for lang in LANGUAGE_LIST]
assert sorted(installed_files) == sorted(expected_files)
#def test_available_langs():
# for lang in spell.get_available_languages():
# lang_url = '{}/{}'.format(spell.repository_url, lang.file)
# code, text, headers = head(lang_url)
# assert code == 200
def test_available_langs():
for lang in spell.get_available_languages():
lang_url = '{}/{}'.format(spell.repository_url, lang.file)
response = head(lang_url)
assert response.status_code == 302