Jimmy
32edd35c7a
buffer completion: handle deleting items see issue #1443
...
Allows to use ctrl+d to close tabs from the buffer completion widget
when they are selected. Respects current tab settings like whether you
can close the last tab in a window.
Had to change the `rebuild()` method to use `setData()` when possible
because the selection was being lost if the whole model was being rebuilt.
Current problems are:
1) When opening a new window while you already the tab completion open on
one window a category is added for the new window but new rows in
that category aren't picked up. Interesting if you open a third
window then close the second window the completion display is now
correct... I can see that the model is being updated correctly but I
am not sure why that isn't propagating to the view. Not sure whether
it is worth looking into (further) either.
2) Bit of duplication of code, it iterates over the window registry
twice. Could put everything in one loop but then that would be
dependant on the current behaviour of the `tab_closed` signal being
called with the relevant `tabbed_browser` still existing but with the
`shutting_down` flag set.
3) I'm still using just the one `rebuild()` method and removing items from
the end then calling `setData` on everything rather than having special
`on_tab/window_closed` methods (or partial functions) that delete the
actual corresponding item. Because if I did that I would also have to
special case tab moves etc.
2016-04-23 02:55:53 +12:00
Florian Bruhin
77a9bbb4b4
Fix accidental double-import
2016-04-21 23:12:54 +02:00
Florian Bruhin
39e8ac5159
Merge branch 'rcorre-marks'
2016-04-21 22:55:44 +02:00
Florian Bruhin
0955ed49a7
Update docs
2016-04-21 22:55:36 +02:00
Florian Bruhin
5b34f1b429
Fix ModeManager.leave docstring
2016-04-21 20:12:02 +02:00
Florian Bruhin
e0aa35b05a
Fix type in @pyqtSlot for ModeManager.leave
...
For some reason it worked with str as well, but the signal emits a
KeyMode member.
2016-04-21 20:10:58 +02:00
Florian Bruhin
ef91fa3821
Merge branch 'marks' of https://github.com/rcorre/qutebrowser into rcorre-marks
2016-04-21 20:05:41 +02:00
Florian Bruhin
46a525d0d7
bdd: Improve test IDs for :buffer tests
2016-04-21 19:47:26 +02:00
Florian Bruhin
10fe9cf32d
Stabilize test_buffer_two_window_index_present
...
Fixes #1440
I'm not sure if this was the case, but probably it was.
2016-04-21 19:34:39 +02:00
Ryan Roden-Corrent
600b5082a9
Touch up tests and add pyqtSlot for marks.
...
Small code review changes.
2016-04-20 21:53:12 -04:00
Florian Bruhin
a55952375b
bdd: Improve output when comparing sessions
...
See #1440 .
2016-04-21 00:15:37 +02:00
Florian Bruhin
e53c136342
tests: Refactor partial_compare
...
Functions now return a PartialCompareOutcome to attach an error message instead
of a bool, and the main function got rewritten based on a handler dict.
2016-04-21 00:14:13 +02:00
Florian Bruhin
cd128bec8e
bdd: __tracbackhide__ in QuteProcess._wait_for_*
...
This should improve the output we got here:
https://ci.appveyor.com/project/The-Compiler/qutebrowser/build/master-2404/job/gr7m54km6h6nul04
2016-04-20 22:39:52 +02:00
Florian Bruhin
eeb830e040
travis: Ignore doc changes when building a PR
...
Fixes #1441
2016-04-20 22:35:02 +02:00
Florian Bruhin
391900cc99
Merge branch 'forkbong-pretty_url'
2016-04-20 22:17:35 +02:00
Florian Bruhin
9ae826295b
Update docs
2016-04-20 22:17:27 +02:00
Florian Bruhin
e18b056877
Merge branch 'pretty_url' of https://github.com/forkbong/qutebrowser into forkbong-pretty_url
2016-04-20 22:15:54 +02:00
Florian Bruhin
0277c47ffa
Merge branch 'forkbong-pretty_url_2'
2016-04-20 20:59:35 +02:00
Florian Bruhin
c27d4f4407
Update docs
2016-04-20 20:59:27 +02:00
Florian Bruhin
6a6285495a
Merge branch 'pretty_url_2' of https://github.com/forkbong/qutebrowser into forkbong-pretty_url_2
2016-04-20 20:56:24 +02:00
Florian Bruhin
3237e36db5
tox: Update hacking to 0.11.0
2016-04-20 20:16:50 +02:00
Panagiotis Ktistakis
1ef2f042cf
Mention {url:pretty} in the docs
2016-04-20 19:39:18 +03:00
Florian Bruhin
664a542ff6
requirements: Update colorlog to 2.6.3
2016-04-20 17:51:16 +02:00
Florian Bruhin
a6f496dc2a
Merge branch 'blyxxyz-master'
2016-04-20 17:49:31 +02:00
Florian Bruhin
41c7f37618
Regenerate authors
2016-04-20 17:48:51 +02:00
Florian Bruhin
6c6b8e10a6
Merge branch 'master' of https://github.com/blyxxyz/qutebrowser into blyxxyz-master
2016-04-20 17:48:41 +02:00
Panagiotis Ktistakis
8550fb3401
Add tests for {url:pretty} variable
2016-04-20 17:58:14 +03:00
Panagiotis Ktistakis
6c3b0219e7
Style fix
2016-04-20 17:25:26 +03:00
Florian Bruhin
22582773b1
Fix lint
2016-04-20 09:00:01 +02:00
Florian Bruhin
bc815505f1
bdd: Output fewer = chars for summary headers
...
Otherwise we have line breaks on Travis CI
2016-04-20 07:55:59 +02:00
Florian Bruhin
4520261884
bdd: Make TestProcess.log_summary public
...
We want to use it from the BDD conftest.py
2016-04-20 07:55:23 +02:00
Florian Bruhin
6cf4cebfd4
bdd: Show messages we're waiting for in the log
2016-04-20 07:49:08 +02:00
Florian Bruhin
a99cb5f6b2
bdd: Improve wait_for_load_finished output
2016-04-20 07:38:32 +02:00
Florian Bruhin
5e91ad6c42
bdd: Shorten InvalidLine exception output
2016-04-20 07:38:32 +02:00
Florian Bruhin
266bc6e8d8
bdd: Don't shorten log if an exception happened
2016-04-20 07:38:32 +02:00
Florian Bruhin
1579f27564
bdd: Add sections to log
...
See #1418
2016-04-20 07:38:12 +02:00
Ryan Roden-Corrent
0755e163bb
Only set the ' mark on normal/current hinting.
...
Don't set ' for downloading, hovering, or opening a link in a tab.
2016-04-19 21:18:20 -04:00
Ryan Roden-Corrent
268d490e25
Return False when MarkKeyParser gets special key.
2016-04-19 17:30:57 -04:00
Jan Verbeek
3788eeb10b
Add a few common generic browser keybindings
2016-04-19 22:24:24 +02:00
Panagiotis Ktistakis
c7534bd4a3
Allow {url:pretty} variable in commands
2016-04-19 16:37:05 +03:00
Ryan Roden-Corrent
6466ff919a
Don't limit marks to alpha characters.
2016-04-19 08:28:11 -04:00
Ryan Roden-Corrent
ae267c466f
Small fixes for marks.
...
Mark two callbacks with pyqtSlot as appropriate.
Return False instead of raising NotImplementedException to avoid pylint
identifying MarkKeyParser as abstract.
2016-04-19 08:28:02 -04:00
Florian Bruhin
5c97ec1659
Fix HeaderDict lint
2016-04-19 09:50:53 +02:00
Florian Bruhin
6aaea2aa31
Fix HeaderDict with an empty value
2016-04-19 09:43:54 +02:00
Florian Bruhin
4ea6bd40e4
Update docs
2016-04-19 09:40:39 +02:00
Florian Bruhin
e860d8cfea
Add a custom-headers setting
...
Supersedes #1132
Closes #1020 .
2016-04-19 06:35:32 +02:00
Florian Bruhin
c5999443a1
Implement a HeaderDict config type
...
Supersedes #1132 .
Fixes #1022 .
2016-04-19 06:35:20 +02:00
Ryan Roden-Corrent
c7ee7a9702
Update docs for jump-mark and set-mark
2016-04-18 18:15:11 -04:00
Panagiotis Ktistakis
045b54b94b
Add commands to yank pretty decoded URLs
...
yp and yP, yank to the clipboard and primary selection respectively
2016-04-18 23:11:27 +03:00
Panagiotis Ktistakis
bd6783c7e6
Add --pretty flag to :yank
...
With --pretty, the URL is yanked in a "pretty form", with most
percent-encoded characters decoded. Partially fixes #1372 .
2016-04-18 23:10:53 +03:00