rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
17,061 Commits 1 Branch 0 Tags 112 MiB
9d069ea12b
Commit Graph

4553 Commits

Author SHA1 Message Date
Florian Bruhin
200c11625f Revert "Make sure we wait until follow_selected is done" 
This reverts commit bc45aa33e0.
 2018-09-14 21:58:42 +02:00
Florian Bruhin
8d066690e6 Fix :follow-selected tests 2018-09-14 21:57:37 +02:00
Florian Bruhin
bc45aa33e0 Make sure we wait until follow_selected is done 2018-09-14 20:18:33 +02:00
Florian Bruhin
afe16d3a7c Avoid using qapp with autouse=True 2018-09-13 22:49:25 +02:00
Florian Bruhin
68af23b76e Try getting selection multiple times 2018-09-13 22:41:30 +02:00
Florian Bruhin
62458c7a84 Register a qute://testdata/ scheme for unit tests 
This is more lightweight than running a webserver (probably about the same as
file://), but allows us to use relative links in files.
 2018-09-13 22:32:00 +02:00
Jesko Dujmovic
25e396faea
Merge branch 'master' into master 2018-09-13 22:06:04 +02:00
Florian Bruhin
f9327731b8 Handle UTF-8 byte order marks in Greasemonkey scripts 
See e.g. https://github.com/jerone/UserScripts/issues/135
 2018-09-12 23:54:32 +02:00
Florian Bruhin
91b8002dd5 Clean up workaround for sqlite opening errors 
Now that we know the real cause, we can be a bit stricter with our workaround.
 2018-09-12 16:06:57 +02:00
Florian Bruhin
c2a072f9fe Fix handling of sqlite out of memory errors 
The "error_code == -1" check never passed, as error_code (confusingly) is a
string of a number.
 2018-09-12 01:36:50 +02:00
Florian Bruhin
d80d9eb26c Allow downloading from PDF.js 
When we click the download button in PDF.js, it downloads a blob://qute:...
URL. We can detect that and force a download rather than opening it in PDF.js
again.

Note that what actually happens depends on the Qt version and backend:

QtWebKit (any Qt version):
Downloads always work properly (regardless of Qt version).

QtWebEngine, Qt 5.7.1:
Downloads work.

QtWebEngine, Qt 5.9 - 5.11:
Downloads won't work as we need to tell PDF.js to not use blob: URLs:
https://bugreports.qt.io/browse/QTBUG-70420 - in theory, PDF.js could fall back
to downloading the existing qute:// URL, but it has a whitelist of schemes
which does not include qute://... Since it's not in that whitelist, it just
ends up doing nothing at all.

QtWebEngine, Qt 5.12:
Downloads should hopefully work properly again, as we can register the qute://
scheme with Chromium, which allows us to use blob:// URLs.
 2018-09-10 13:15:39 +02:00
Florian Bruhin
02641b86fc Don't tell PDF.js to disable createObjectURL on Qt 5.7.1 
Looks like things actually work fine there...
 2018-09-10 13:01:01 +02:00
Florian Bruhin
bb96f8d297 Fix PDF.js test when no PDF.js is installed 2018-09-10 09:36:29 +02:00
Florian Bruhin
9b04c4b8e0 Add missing tests for qute://pdfjs 2018-09-09 19:22:39 +02:00
Florian Bruhin
b4077a8543 Fix lint 2018-09-09 18:39:22 +02:00
Florian Bruhin
b96898db37 Simplify and lock down PDF.js filename handling 2018-09-09 18:35:09 +02:00
Florian Bruhin
8cfa46f539 100% test coverage for browser.pdfjs 2018-09-09 18:35:09 +02:00
Florian Bruhin
3e25262437 Remove old backend patching 2018-09-09 18:35:09 +02:00
Florian Bruhin
490fe5e1a3 Add utils.guess_mimetype 2018-09-09 18:35:09 +02:00
Florian Bruhin
24148c649e Fix lint and tests 2018-09-09 18:35:09 +02:00
Florian Bruhin
3ad7ae2a2c Remove fix_urls which isn't needed anymore 
With qute://pdfjs/web/viewer.html we can use relative URLs
 2018-09-09 18:35:09 +02:00
Florian Bruhin
bbcb87e434 Get PDF.js to work 
We need to use the /web/viewer.html path so relative references are correct.
 2018-09-09 18:35:09 +02:00
Florian Bruhin
7206dde19c Revert "Simplify getting pdfjs main page" 
This reverts commit 9c731bde85627308fdde4730b0181a014096cb47.

We need to set some PDF.js options, so we can't just use the default viewer
with ?file=...
 2018-09-09 18:35:09 +02:00
Florian Bruhin
8f19820a7a Remove pdfjs.fix_urls 
Now that we use qute://pdfjs to show the viewer, we don't need to rewrite any
URLs.
 2018-09-09 18:35:09 +02:00
Florian Bruhin
24fb3b0d1b Simplify getting pdfjs main page 2018-09-09 18:35:09 +02:00
Florian Bruhin
dc82ac3eb2 Move qute_pdfjs to qutescheme.py 2018-09-09 18:35:09 +02:00
Jimmy
33cc8c11ba Pull common code into a fixture. 2018-09-09 20:51:19 +12:00
Jesko
02f485cbc8 making import of QtWebEngine in corresponding tests conditional 2018-09-09 20:51:19 +12:00
Jesko
f22fb30ef3 fixing non controversial changes 2018-09-09 20:51:19 +12:00
Jimmy
7a73c0f264 Add tests for greasemonkey worldid in webenginetab. 
Adds a new file for tests relating to WebEngineTab, it looks a little
sparse right now but I'm sure there will be more soon.

Tests that scripts with invalid world IDs are rejected appropriately and
the ones with valid world IDs aren't rejected.

The `FakeWidget` thing is so `sip.isdeleted` didn't complain about being
passed the wrong type.
 2018-09-09 20:51:19 +12:00
Jimmy
5252541fe3 greasemonkey: better handle scripts without metadata 
Previously calling `script.code()` would fail if the script didn't have
a `name`. This wasn't being hit in practice because the only place that
constructs GreasemonkeyScripts was checking for that condition and add
the filename there as a fallback.

This change make the `name` attribute more explicitly mandatory by
failing with a `ValueError` if it is not provided and make it still
possible to use the filename fallback in that case by adding a
`filename` keyward argument to `__init__()`.

Additionally where `script_meta` is used in `script.code()` a fallback
to and emptry string was added so it doesn't fail for raw javascript
files without greasemonkey metadata.
 2018-09-09 20:51:19 +12:00
Jesko
abea603119 moving MAX_WORLD_ID to qtutils, changing test names, fixing linter errors, changing error type to WebTabError 2018-09-09 20:45:21 +12:00
Jesko
8ef3d90b1a removing unwanted space 2018-09-09 20:45:21 +12:00
Jesko
ee9b1f4950 adding tests and improving error messages 2018-09-09 20:45:21 +12:00
Florian Bruhin
1647c28632 Allow lists for javascript.convert_js_arg 2018-09-08 16:20:38 +02:00
Florian Bruhin
b8ab378083 Show web_engine_tab container 
This is needed for caret tests on Qt < 5.11
 2018-09-08 16:04:29 +02:00
Florian Bruhin
20da259de6 Rewrite some :follow-selected tests as unit tests 2018-09-08 16:01:38 +02:00
Florian Bruhin
45eece372f Don't access caretElement if it's gone 2018-09-08 15:51:42 +02:00
Florian Bruhin
8c0366f0a7 Configure JS logging for test tab objects 2018-09-08 15:34:28 +02:00
Florian Bruhin
bb5fee4adc Also add a container for webengine_tab 
Seems to be needed with Qt < 5.11 for things to work.
 2018-09-08 14:52:57 +02:00
Florian Bruhin
9c67239847 Fix lint 2018-09-08 14:52:47 +02:00
Florian Bruhin
7cb32dca07 Add a container around webkit_tab 
This makes the selection appear properly in caret tests - otherwise, --no-xvfb
would be needed.
 2018-09-08 13:36:02 +02:00
Florian Bruhin
5978605873 Make caret unittests run with QtWebKit 2018-09-08 13:22:17 +02:00
Florian Bruhin
db6935b42e Fix TestSearch caret tests 
For some reason, they need the window to be shown on a screen to work...
 2018-09-08 12:26:00 +02:00
Florian Bruhin
64e321d47c Rewrite most caret tests as unit tests 2018-09-08 12:15:32 +02:00
Florian Bruhin
a58abf8f4c Set __tracebackhide__ for CallbackChecker.check 2018-09-08 12:15:14 +02:00
Florian Bruhin
8ac3162425 Call modeman.init() in mode_manager fixture 2018-09-08 12:14:55 +02:00
cauimsouza
71781b3f43 Update fake object instantiation 2018-09-07 21:44:17 +02:00
Florian Bruhin
4ca8fc0cb7 Use a shared web_history fixture 2018-09-06 20:08:32 +02:00
Florian Bruhin
ab6c8dde9a Decrease minimum QProgressDialog duration 
We already have a threshold before we use a QProgressDialog at all, so let's
show it quite quickly and not after 4 seconds.
 2018-09-06 17:26:28 +02:00
Florian Bruhin
935d93d10e Add tests for HistoryProgress 2018-09-06 17:26:28 +02:00
Florian Bruhin
d4f16f88b6 Remove support for importing pre-v1.0.0 history 2018-09-06 17:26:28 +02:00
Florian Bruhin
ec774379bd Add tests for history progress 2018-09-06 17:13:46 +02:00
Florian Bruhin
e4b7786bcc Factor out GUI stuff to a HistoryProgress object 2018-09-06 17:04:26 +02:00
Florian Bruhin
c8be2d4f7e Fix pylint issues with config cache 2018-09-06 16:43:10 +02:00
Florian Bruhin
108cc65bc6 Merge remote-tracking branch 'origin/pr/4185' 2018-09-06 16:15:16 +02:00
Jay Kamat
8e82adc306
Refactor configcache to cache 
Also fix and improve configcache tests
 2018-09-05 22:26:12 -07:00
Florian Bruhin
6293bc5178 Fix lint and test 2018-09-04 23:46:34 +02:00
Florian Bruhin
58793d95d7 Further clean up error handling 2018-09-04 23:05:59 +02:00
Florian Bruhin
92fcc523c5 WIP: Properly signal scheme errors 2018-09-04 23:03:10 +02:00
Florian Bruhin
2fcdc5a0c9 Merge branch 'blacklist-history' 2018-09-04 22:19:52 +02:00
Philip Scheel
8d04f8cdc8 Fixed pylint complaints 2018-09-04 00:59:49 +02:00
Philip Scheel
cf13c31142 Resolved conflicts for merge, regenerated asciidoc, removed whitespace 
Removed whitespace
 2018-09-04 00:10:07 +02:00
Philip Scheel
35c2f95a58 Merged upstream, made requested modifications to the search engine code and added tests 2018-09-03 23:28:43 +02:00
Jay Kamat
d4cf5045ab
Fix tests for configcache 2018-09-02 18:03:36 -07:00
Jay Kamat
067d76616b
Implement config cache system 2018-09-02 14:23:00 -07:00
Florian Bruhin
5b0c10d430 Fix docstrings 2018-09-02 15:46:57 +02:00
Florian Bruhin
8a42256cff Merge remote-tracking branch 'origin/pr/4178' 2018-09-02 15:45:48 +02:00
Florian Bruhin
b0185e3c8a Use config_stub.val instead of config_stub.set_obj in tests 2018-09-02 14:42:47 +02:00
Florian Bruhin
dbdeb6a9c7 Rename history.exclude to completion.web_history.exclude 
If the blacklist is only valid for the completion, the setting should also be
under completion.

This also un-renames history.gap_interval and renames
completion.web_history_max_items.
 2018-09-02 14:42:47 +02:00
Florian Bruhin
4f56355fbe Don't affect qute://history with history.exclude 2018-09-02 14:42:47 +02:00
Florian Bruhin
67b4b7d490 Handle :// as URL pattern 2018-09-02 11:58:34 +02:00
Florian Bruhin
37396d68f3 Define names for sqlite error codes 2018-09-01 22:25:22 +02:00
Florian Bruhin
f5c92ded41 Merge Sql{Environment,Bug}Error with Sqlite{Environment,Bug}Error 2018-09-01 22:25:22 +02:00
Florian Bruhin
50ae2bf2f9 Redesign SQL error handling 
Instead of having an environmental attribute on exceptions, we now have two
different exception classes.

Fixes #3341
See #3073
 2018-09-01 22:25:22 +02:00
Florian Bruhin
71a2dad570 Add a history.exclude setting 
This allows to exclude URL patterns from being displayed in the completion or
in qute://history.
 2018-09-01 22:25:22 +02:00
Florian Bruhin
7fb2224640 Add a UrlPattern config type 
For some settings it makes sense to have a list of URL patterns in the config,
rather than having a per-domain boolean setting.
 2018-09-01 18:25:58 +02:00
Florian Bruhin
3f2a468750 Also detect missing bound values for sql.Query.run_batch 2018-09-01 18:25:58 +02:00
Florian Bruhin
fa1fe63a93 Add some more sql.Query tests 2018-09-01 18:25:58 +02:00
Florian Bruhin
0e284944e7 Use composition instead of inheritance for sql.Query 
This means we're more loosely coupled to Qt's QSqlQuery, and also can move some
logic for handling batch queries from the table to there.
 2018-09-01 18:25:58 +02:00
Florian Bruhin
6b719fb218 Make sure queries don't have any missing bindings 2018-09-01 18:25:58 +02:00
Florian Bruhin
1d6282fd6c Add some tests for sql.Query 2018-09-01 18:25:58 +02:00
Florian Bruhin
806d65be8e Add test for no-sql-history flag 2018-09-01 18:25:58 +02:00
Florian Bruhin
c2f8b6531d Reorganize test_history 2018-09-01 18:25:58 +02:00
Florian Bruhin
9fb794656b Make it possible to force a history rebuild 
This adds a new CompletionMetaInfo table which is a simple key/value store.

Thanks to Python/sqlite duck typing, we can use that to store values of any
type, even new ones in the future.

Currently, the only allowed key is force_rebuild, which forces a rebuild of the
CompletionHistory table. This will be needed for a future change.
 2018-09-01 18:25:58 +02:00
Vasilij Schneidermann
3fa6d94893 Display value when calling :set without a value 
This change brings Qutebrowser closer to Vim's behavior of `:set
foo?` *and* `:set foo` displaying the current value of `foo`.
 2018-08-31 21:34:42 +02:00
Florian Bruhin
1815070dab Make sure the host blocker doesn't block 0.0.0.0 2018-08-31 16:48:45 +02:00
Florian Bruhin
d337ed885a Re-add :stop test in misc.feature 
For some reason I don't comprehend right now, disabling it breaks
test_focusing_download_widget_via_tab. I'm having exams tomorrow and the day
after that, so meh, let's just re-enable that test for now as a stopgap
solution.
 2018-08-28 22:56:50 +02:00
Florian Bruhin
8459afb76e Recognize "Command"/"Cmd" in keybindings 2018-08-28 18:57:47 +02:00
Florian Bruhin
3fa01ae84d Handle more flaky tests 2018-08-28 09:21:03 +02:00
Florian Bruhin
1a7efd92d7 Merge remote-tracking branch 'origin/pr/4140' 2018-08-27 10:06:04 +02:00
Florian Bruhin
a370a00194 Remove more useless-return suppressions 2018-08-19 10:53:01 +02:00
Jimmy
b192164f2e Don't alphabetically sort tab completion. 
`ListCategory` sorts its completion by default, we are already building
the categories in the right order so don't need that.

The test tests the case of where you have 11 tabs and if the model was
sorted the tabs with index 10 and 11 would be sorted before the one with
index 2.

The `random.sample` bit for the tab url and title is to also make sure
the model isn't being sorted on those columns, whithout haveng to write
and all ten lines.
 2018-08-19 16:42:36 +12:00
Jay Kamat
b962c5c4d9
Merge pull request #4118 from DerJesko/master 
Tests for ipv6 support in urlmatch
 2018-08-13 14:33:53 -07:00
wishfort36
0e3e41a5e8 Handle nitpicks 2018-08-13 07:50:54 +02:00
wishfort36
b05738dd6c Keep $QUTE_COUNT unset if a count is not given 2018-08-12 22:39:32 +02:00
wishfort36
a9725ddb4a Add tests for $QUTE_COUNT 2018-08-12 22:31:12 +02:00
Florian Bruhin
58dffafb1e Merge remote-tracking branch 'origin/pr/4126' 2018-08-12 20:24:56 +02:00
Florian Bruhin
bddc021295 Mark more :follow-selected tests as flaky 2018-08-12 20:24:31 +02:00
farlusiva
8e2307c546 Docstring things, change test 
- Update the docstring for repeat
 - Remove the blank line after the docstring
 - Update the docstring with scripts/dev/src2asciidoc.py
 - Simplify the test
 2018-08-11 19:32:41 +02:00
wishfort36
adb371f305 Add test 2018-08-11 19:04:18 +02:00
Jesko
a676cca6c5 changing the texts of the errors 2018-08-10 20:49:20 +02:00
Jesko
0b51437346 fixing indentation 2018-08-10 19:05:15 +02:00
Florian Bruhin
57d3ed95f2 Mark another test as flaky 2018-08-10 08:40:24 +02:00
Jesko
972b3ae960 changing suggested flaws 2018-08-08 18:30:12 +02:00
Jesko
484a22f111 now declining more wrong ipv6 addresses and cleaning up code 2018-08-08 17:53:14 +02:00
Jesko
4ce5d99b24 match minimizes ipv6 urls 2018-08-08 16:55:43 +02:00
Jesko
599ac5ca23 Adding parser tests for IPv4 2018-08-07 22:35:00 +02:00
Jesko
790b34dc56 Adding match pattern test esp. IPv6 2018-08-07 21:59:15 +02:00
Florian Bruhin
9eeaa4f45d Fix lineparser tests 2018-08-07 17:53:26 +02:00
Florian Bruhin
70addc93b3 Add missing yaml_value fixture 2018-08-06 19:57:38 +02:00
Florian Bruhin
c1d06c8abb Skip another test 2018-08-06 09:55:49 +02:00
Florian Bruhin
4c23fb9e2f Another flaky test 2018-07-28 09:57:42 +02:00
Florian Bruhin
5269c5ac2b Another flaky test 2018-07-28 09:52:45 +02:00
Florian Bruhin
6fa07703db More flaky tests 2018-07-24 19:56:34 +02:00
Florian Bruhin
12e5375931 Handle more test flakiness 2018-07-24 17:36:07 +02:00
Florian Bruhin
8b814e3072 Increase qute://history delay in tests 2018-07-24 16:51:36 +02:00
Florian Bruhin
98cf1e5b2c Kill some more tests 2018-07-22 17:19:12 +02:00
Florian Bruhin
463dd911a3 More flaky tests 2018-07-22 15:46:24 +02:00
Florian Bruhin
40e58126aa About everything is flaky 
Did I already mention that I'm starting to hate those tests I wrote in the past
with a passion?
 2018-07-22 14:05:40 +02:00
Florian Bruhin
c1c182d958 Mark more tests as flaky 2018-07-22 13:03:25 +02:00
Florian Bruhin
0304036d7d Skip test which is too flaky 2018-07-22 12:05:55 +02:00
Florian Bruhin
13f688eeb8 "Fix" more flaky tests 2018-07-22 11:24:06 +02:00
Florian Bruhin
a7170fefe9 Turn off hypothesis deadline if on CI 2018-07-22 10:13:06 +02:00
Florian Bruhin
31a6374e0e Mark some more flaky tests as flaky 
I really want end2end tests to die...
 2018-07-21 23:36:45 +02:00
Florian Bruhin
733625e140 Stabilize test_qute_settings_persistence 2018-07-21 23:36:45 +02:00
Florian Bruhin
8a748741ba Fix checks for Nouveau workaround 2018-07-19 00:28:12 +02:00
Florian Bruhin
8e6aa9e3e1 Locally disable assignment-from-no-return for pylint 2.0 2018-07-16 14:53:30 +02:00
Florian Bruhin
e50b6912a7 Fix pylint 2.0 useless-return cases 
See https://github.com/PyCQA/pylint/issues/2300
 2018-07-16 14:33:11 +02:00
Florian Bruhin
43e58ac865 CVE-2018-10895: Fix CSRF issues with qute://settings/set URL 
In ffc29ee043 (part of v1.0.0), a
qute://settings/set URL was added to change settings.

Contrary to what I apparently believed at the time, it *is* possible for
websites to access `qute://*` URLs (i.e., neither QtWebKit nor QtWebEngine
prohibit such requests, other than the usual cross-origin rules).

In other words, this means a website can e.g. have an `<img>` tag which loads a
`qute://settings/set` URL, which then sets `editor.command` to a bash script.
The result of that is arbitrary code execution.

Fixes #4060
See #2332
 2018-07-11 17:05:23 +02:00
Florian Bruhin
274b66ec46 Strip trailing newlines from pastebin URL 2018-07-08 22:09:56 +02:00
Olmo Kramer
daa8bc0507
Fix accidentally renamed hint group 2018-07-05 00:57:08 +02:00
Olmo Kramer
9f5f52360c
Add test cases for url-patterns 2018-07-04 23:52:28 +02:00
Olmo Kramer
332cbf811b
Add test for custom hint group 2018-07-04 22:56:47 +02:00
Olmo Kramer
7aa5db29b5
Add tests for invalid hint group & js click handler 2018-07-04 22:56:47 +02:00
Olmo Kramer
0f8296d384
Add hints.selectors setting 2018-07-04 22:56:42 +02:00
Florian Bruhin
42a3622906 Ignore a new Qt 5.11 lowlevel message 2018-07-03 15:38:29 +02:00
Florian Bruhin
a0f36c5cbf Skip JS test which is too flaky 2018-07-03 14:15:08 +02:00
Florian Bruhin
4d1e56a8c6 Ignore "Lost UI shared context" error happening on AppVeyor 2018-07-03 13:39:34 +02:00
Florian Bruhin
7e8c741937 Set compiled=False for BDD Qt comparisons 
We often check for bugs and not APIs there.
 2018-07-03 13:10:15 +02:00
Florian Bruhin
641f7eb3c5 Don't import test_file on Windows 
See https://github.com/pytest-dev/pytest/issues/3650
 2018-07-03 13:08:54 +02:00
Florian Bruhin
26d6cf8ef6 Stabilize URL escaping test 2018-07-03 10:29:28 +02:00
Florian Bruhin
f6f713bbfe Skip key forwarding tests on Qt 5.11.1 
See #4036
 2018-07-02 23:19:57 +02:00
Florian Bruhin
6ca11ed95b Adjust SSL test for Qt 5.11 2018-07-02 23:15:04 +02:00
Florian Bruhin
41303ecfcf Make sure temporary dir exists 
This seems to be enforced with Qt 5.12
See #4025
 2018-07-02 22:32:59 +02:00
Florian Bruhin
9a14574c9f Skip invalid links on any Qt 5.11 version 
See #3661
 2018-07-02 22:32:59 +02:00
Florian Bruhin
d861c097b1 Support new dead keys added in Qt 5.11 properly 
See https://codereview.qt-project.org/#/c/207231/
 2018-07-02 22:32:59 +02:00
Florian Bruhin
77fe2e1c85 Fix test_set_wrong_backend 2018-07-02 22:32:59 +02:00
Florian Bruhin
c3455d9082 Add a wrapper around sip 
Starting with PyQt 5.11, the sip module now is bundled with PyQt as PyQt.sip.
Having a qutebrowser.qt also helps with #3625, see #995
 2018-07-02 22:32:59 +02:00
Florian Bruhin
e857400c2c Add missing str() 2018-06-28 13:26:45 +02:00
Florian Bruhin
a804300dc0 Add missing tests for spell.init() 2018-06-26 16:56:22 +02:00
Florian Bruhin
3312c221c4 Stabilize ssl_strict test 2018-06-26 10:26:17 +02:00
Florian Bruhin
85a9f6a08a Fix lint 2018-06-26 10:23:48 +02:00
Jimmy
680ae89ffd Also mock platform to windows for utils tests. 
This is the same fixture I added in
tests/unit/browser/webkit/test_downloads.py
 2018-06-26 17:47:10 +12:00
Jimmy
747acfe7fa Makes sanitize_filenames platform dependant. 
Hopefully having the posix bad_chars list so minimal won't ruin anyones day.
 2018-06-26 16:29:38 +12:00
Jimmy
d31fa5229d Stringify py.path object for py3.5 
https://www.python.org/dev/peps/pep-0519/

Huh, I didn't realise cpython and the stdlib look up "special" methods
on the class only.
 2018-06-26 16:14:22 +12:00
Jimmy
2510fde80f Add unit test for sanitized download filenames. 
I think this covers the right path despite not using either of the
backend specific download code. They both either call `set_target()`
directly with a guessed filename or from the prompt question. When
called directly though that basename set by `_init_item()` is used.

It's a little high level but we already know that sanitize_filenames
does, I wanted to test that it gets called.
 2018-06-26 16:14:22 +12:00
Jimmy
75c6e087c7 Refactor individual tmpdir fixtures. 
I was adding a downloads one and saw the opportunity to refactor. Didn't
end up saving that much because I couldn't figure out how to get the
method that does the work to use the fixtures while also taking an
argument, so they have to be passed through from the calling ones. Oh
well.
 2018-06-26 16:14:22 +12:00
Florian Bruhin
1bc3d444b6 Stabilize escaping URLs test 2018-06-25 23:02:50 +02:00
Florian Bruhin
87778277e0 Fix SSL error page tests 2018-06-25 22:51:48 +02:00
Florian Bruhin
fc19262eaa Fix test_shared.py 2018-06-24 22:31:27 +02:00
Florian Bruhin
a02c25dfb1 Don't escape URLs for qute://history 
We only use the URL to set a 'href' attribute, which does not need escaping.

See #4011
Fixes #4012
 2018-06-23 14:27:07 +02:00
Florian Bruhin
9a5439e5d0 Re-add waiting for QQuickWidget 
Apparently this is still needed on some PyQt versions.
 2018-06-21 22:22:04 +02:00
Florian Bruhin
5a7869f2fe Fix XSS issue on qute://history 
Fixes #4011
 2018-06-21 21:20:19 +02:00
Florian Bruhin
62d8b5b574 Don't depend on PyQt5.QtQuickWidgets to get RWHV 
Some distributions (at least FreeBSD) don't package that module, so let's not
rely on it.
 2018-06-21 17:14:29 +02:00
Florian Bruhin
4887385bdd Fix test_dictionary_dir 2018-06-21 01:40:36 +02:00
Jay Kamat
0e7bbccd71
Fix stacking tabs setting with new_tab prev 2018-06-19 12:10:21 -04:00
Jay Kamat
1919029858
Add setting for controlling stacking of new tabs 2018-06-18 18:09:13 -04:00
Florian Bruhin
b1b06fcb43 Fix restore test 2018-06-14 17:42:33 +02:00
Florian Bruhin
746c2986f0 Fix test_stylesheet on Qt 5.11 2018-06-14 16:42:24 +02:00
Florian Bruhin
11fce30ed0 Stabilize mode_on_change tests 2018-06-14 15:56:48 +02:00
Florian Bruhin
1335fccba1 Merge remote-tracking branch 'origin/pr/3590' into tab-mode 2018-06-14 15:40:58 +02:00
Florian Bruhin
cec63ea449 Merge remote-tracking branch 'origin/pr/3906' 2018-06-14 14:49:30 +02:00
Florian Bruhin
fd4ae2fabe Fix test_set_wrong_backend 2018-06-12 14:17:50 +02:00
Florian Bruhin
6faff11243 Improve error messages with backend conditionals 2018-06-12 11:10:03 +02:00
Florian Bruhin
e066f83a7c Make configinit tests run with all setups 2018-06-12 10:52:22 +02:00
Florian Bruhin
5b5657b0d5 Make sure debug_flags is available for unit tests 2018-06-12 10:38:19 +02:00
Florian Bruhin
093f07f552 Add content.canvas_reading setting 
See #2377
Closes #2235
 2018-06-11 23:28:04 +02:00
Florian Bruhin
69abc9a1a1 Add a content.webrtc_public_interfaces_only option 
See #3010
Fixes #2163
 2018-06-11 19:44:45 +02:00
Florian Bruhin
3bf89bcea4 Add content.autoplay option 
See #3010
Closes #1643
 2018-06-11 19:32:34 +02:00
Florian Bruhin
b7c1d7fe37 Fix broken tests 2018-06-11 18:38:22 +02:00
Florian Bruhin
263d298449 Remove the content.developer_extras setting 2018-06-11 18:09:24 +02:00
Florian Bruhin
98c82859b5 Skip "History with view-source URL" on QtWebKit 2018-06-11 15:36:48 +02:00
Florian Bruhin
b5d1614c48 Add audio attribute to FakeWebTab 2018-06-11 12:41:55 +02:00
Florian Bruhin
4dcba2343d Add expected_names to test arguments 2018-06-11 12:37:48 +02:00
Florian Bruhin
e36b6b13e0 Edit docstring :D 2018-06-11 12:35:49 +02:00
Florian Bruhin
2934f4a1ca Merge remote-tracking branch 'origin/pr/3973' 2018-06-11 12:34:18 +02:00
Jimmy
b7929ef747 Add tests for suppressing debug log records. 
For the LogFilter tests I just copied some of the examples that were
already being used and reversed them. To do that without even more
duplication I had to add another parameter to the test.
 2018-06-11 21:56:59 +12:00
Florian Bruhin
649c9f37cd Fix import 2018-06-11 11:35:37 +02:00
Florian Bruhin
7f69920158 Merge remote-tracking branch 'origin/pr/3947' 2018-06-11 11:29:14 +02:00
Florian Bruhin
1ba2e3e24b Implement Qt 5.11 devtools support 
See #3010
 2018-06-11 11:07:14 +02:00
Florian Bruhin
c4add62301 Merge remote-tracking branch 'origin/pr/3825' 2018-06-10 17:30:44 +02:00
Florian Bruhin
50fa7743ba Only use OS-specific line separator for hints 2018-06-10 17:21:31 +02:00
Florian Bruhin
829a6855a3 Make sure test_env_vars restores variables correctly 
Otherwise, we'd get a segfault inside Qt in test_stylesheet, since
88f2873a79.
 2018-06-10 15:49:24 +02:00
Florian Bruhin
ca8d3903e3 Improve configinit tests 2018-06-10 10:49:26 +02:00
Jay Kamat
de127497a2
Press enter to follow links instead of using js 
This codepath may trigger a crash which was fixed by
0e75f3272d.
However, this commit does not make it more likely to happen, and this
patch was backported into arch (at least).

In the future, we may be able to use <enter> on qtwebkit with js,
without triggering this crash
 2018-06-09 15:42:44 -07:00
Florian Bruhin
c9fddfe458 Fix lint 2018-06-09 23:00:57 +02:00
Florian Bruhin
7fdeeb25b7 Merge remote-tracking branch 'origin/pr/3793' 2018-06-09 22:59:52 +02:00
Florian Bruhin
dcb1191f93 Remove the deprecated :tab-detach 2018-06-09 21:25:09 +02:00
Florian Bruhin
ec88c15390 Fix waiting for initial focus object with Qt 5.11 workarounds 
This was broken in d32d541ac0 because now
apparently PyQt knows it's a QQuickWidget.
 2018-06-09 20:05:26 +02:00