rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
14,072 Commits 1 Branch 0 Tags 112 MiB
739cfc03ba
Commit Graph

7741 Commits

Author SHA1 Message Date
Ulrik de Muelenaere
ce1494e5ec Update stylesheet.js to ES6 2017-11-03 12:17:35 +02:00
Ulrik de Muelenaere
72c57d16f4 Merge branch 'master' into stylesheet 2017-11-03 12:13:52 +02:00
Florian Bruhin
d53a96d9f2
Merge pull request #3208 from 7lb/refactor/make_completer_less_stateful 
[RDY] Make completer less stateful
 2017-11-03 10:47:52 +01:00
Florian Bruhin
be325853d8 Revert "Inject JS into the profile" 
This reverts commit acfb3aa26f.

The related code doesn't really belong in webenginesettings.py after all, and
for some reason I don't understand right now this breaks tests in
javascript.feature because window._qutebrowser is undefined when running them.
 2017-11-03 09:59:00 +01:00
Florian Bruhin
25bda66260
Merge pull request #3191 from gyorb/refactor/enum 
use Enum start number
 2017-11-03 09:30:47 +01:00
Marcel Schilling
7e07f5c996 standardize placeholders in configdata descriptions 
* Keep descriptions concise.
 * Prefer starting descriptions with a noun.
 * Don't explain that placeholders are placeholders/get replaced.
 * Introduce placeholder list by the following line:
   'The following placeholders are defined:'
 * List placeholders in a markdown-style list:
   '* `{<placeholder>}`: <description>.'
 2017-11-03 08:48:30 +01:00
Marcel Schilling
c6d7509220 rephrase configdata descriptions 
* see discussion of PR #3181
 2017-11-03 08:44:11 +01:00
Marcel Schilling
87ec7a1a0b prefer nouns for configdata descriptions 
* reserve interrogative words for selection type options
 2017-11-03 08:44:11 +01:00
Marcel Schilling
aebe4c8f9e assume single user in configdata descriptions 
* 'a user' -> 'the user'
 2017-11-03 08:44:11 +01:00
Marcel Schilling
a6451c05d7 add missing units to configdata descriptions 
* fixes #3171
 2017-11-03 08:44:11 +01:00
Marcel Schilling
01b29cd640 use interrogative words for configdata descriptions 
* for selections, use appropriate determiner/pro-adverb/pronoun:
   * 'When to [...].'
   * 'How to [...].'
   * 'Which [...] to [...].'
   * 'What [...] to [...].'
 2017-11-03 08:44:11 +01:00
Marcel Schilling
0a908206bc avoid boolean redundancy in configdata descriptions 
* 'Enable or disable [...]' -> 'Enable [...]'
What else? ---^^^^^^^
 2017-11-03 08:44:11 +01:00
Marcel Schilling
494aceec45 use imperative mood for bools in configdata descriptions 
* considers ConfirmQuit and BoolAsk in addition to Bool
 2017-11-03 08:44:11 +01:00
Marcel Schilling
f76af6c949 define type before desc in configdata YAML file 2017-11-03 08:44:11 +01:00
Marcel Schilling
b187a83d59 avoid spaces before colons in confidata YAML file 
* '  desc : [...]' -> '  desc: [...]'
space ----^      no space ----^
 2017-11-03 08:44:11 +01:00
Marcel Schilling
56671e5787 avoid articles in configdata descriptions 
* includes `valid_value` descriptions in addition to `desc` fields
 2017-11-03 08:44:11 +01:00
Marcel Schilling
e744a7c25a avoid code duplication in configdata descriptions 
* available placeholders are defined for tabs.title.format
 * tabs.title.format_pinned refers to that definition
 * window.title.format repeats the identical(!) definition
 * this replaces the repetion by another reference
 2017-11-03 08:44:11 +01:00
Marcel Schilling
fe8b9519c8 avoid redundancy in configdata descriptions 
* drop phrases referring to the settings themselves:
   * 'set ...'
   * 'control ...'
   * 'definitons of ...'
 2017-11-03 08:44:11 +01:00
Marcel Schilling
fd52409d0c standardize units in configdata descriptions 
* encapsulate units in parentheses: ('(in <unit>)')
 * move units right behind the corresponding noun
 2017-11-03 08:44:11 +01:00
Marcel Schilling
e126faf8c1 prefer 'duration' in configdata descriptions 2017-11-03 08:44:11 +01:00
Marcel Schilling
7672fb5241 avoid abbreviations in configdata description 
* chars -> characters
 * px -> pixels
 * ms -> milliseconds
 * regexes -> regular expressions

 * includes `valid_value` descriptions in addition to `desc` fields

ms_fix
 2017-11-03 08:44:11 +01:00
Marcel Schilling
99ad1547bc break long lines in configdata YAML file 
* max. 79 chars (as per PEP8)
 * two long lines remain (as I didn't know how to safely break them):

>    389      - "http://malwaredomains.lehigh.edu/files/justdomains.zip"
> -> 390      - "https://pgl.yoyo.org/adservers/serverlist.php?hostformat=hosts&mimetype=plaintext"
>    391    type:
> --
>   2222        Sh: open qute://history
> ->2223        xx: config-cycle statusbar.hide ;; config-cycle tabs.show always switching
>   2224        xt: config-cycle tabs.show always switching
 2017-11-03 08:44:11 +01:00
Marcel Schilling
31e7d8dd3f fix capitalization in configdata descriptions 
* url -> URL
 * os -> OS
 * Page Cache -> page cache
 * Spatial Navigation -> spatial navigation
 2017-11-03 08:44:11 +01:00
Marcel Schilling
a55d12bf70 add missing periods (.) to configdata descriptions 
* includes `valid_value` descriptions in addition to `desc` fields
 2017-11-03 08:44:11 +01:00
Marcel Schilling
0c01d9b61a fixed typos in configdata descriptions 2017-11-03 08:44:11 +01:00
Ryan Roden-Corrent
47447c047a Ensure completions are sorted after filtering. 
I previously removed the sorting logic from SortFilter thinking it was
unnecessary if we construct the model with a sorted list. However, this
only worked when no pattern was set, and the items are misordered as
soon as a pattern is input.

This patch reintroduces alpha-sorting, which can be disabled by passing
sort=False to the ListCategory constructor. The session completion test
had to be tweaked as it simulated the incorrect assumption that the
session list is not alpha-ordered; sessions come out of the
session-manager pre-sorted so we may as well use alpha-sorting in the
session completion model.

Resolves #3156.
 2017-11-02 22:10:00 -04:00
Florian Bruhin
acfb3aa26f Inject JS into the profile 
Closes #3216
 2017-11-02 21:59:22 +01:00
Florian Bruhin
a14ef88acf Remove some obsolete/deprecated eslint customizations 2017-11-02 20:00:29 +01:00
Florian Bruhin
1cf66976d2 Merge remote-tracking branch 'origin/pr/3225' 2017-11-02 19:43:04 +01:00
Florian Bruhin
bb208f4e77 Un-hide :open-editor 
It can be used in normal mode as well, and it's nice to have it discoverable.
Fixes #3235.
 2017-11-02 19:32:45 +01:00
Florian Bruhin
5469a238de Fix docs for new editor replacements 
See #3100
 2017-11-02 19:30:47 +01:00
Gyorgy Orban
98c6b49cde use enum module instead or usertypes.enum 
Remove the usertypes.enum from the source and use
the standard enum module instead.
Enum start number is available since python 3.5
 2017-11-02 18:56:11 +01:00
plexigras
6e624bcd3c
Merge branch 'master' into es6ify-js 2017-11-02 16:44:25 +01:00
Florian Bruhin
9a69ccc9e3 Merge remote-tracking branch 'origin/pr/3100' 2017-11-02 11:32:45 +01:00
Florian Bruhin
3385585ca5 Merge remote-tracking branch 'origin/pr/3203' 2017-11-02 11:02:49 +01:00
Florian Bruhin
f620ffd9d4 Merge remote-tracking branch 'origin/pr/3228' 2017-11-02 09:14:49 +01:00
Florian Bruhin
1c39715267 Clarify qute://configdiff/old title 2017-11-01 22:36:59 +01:00
Gyorgy Orban
bb54a954fe use subprocess run 
The usage of subprocess.run is recommended since python 3.5.
Popen, check_call, call and check_output calls were replaced with run.
 2017-11-01 09:59:32 +01:00
Jay Kamat
cb7e6ab02d
Abort pinned tab prompt if tab is destroyed 
Closes #3223
 2017-10-31 19:07:01 -04:00
Luca Benci
24231ae405 Remove unnecessary parens 2017-10-31 23:22:17 +01:00
Luca Benci
bc0c877b87 Formatting 2017-10-31 23:21:37 +01:00
Luca Benci
370405c0ed Remove assert 2017-10-31 23:20:13 +01:00
Luca Benci
dcc53026a3 Stay within 79 columns 2017-10-31 23:14:07 +01:00
plexigras
fa8476f762 keep old pac_utils.js 2017-10-31 16:40:09 +01:00
plexigras
905c984148 change some lambdas to functions 2017-10-31 12:54:26 +01:00
plexigras
d4d791f14e es6ified js 2017-10-31 11:53:35 +01:00
Florian Bruhin
0b86b302a2 pylint: Turn off some more too-many-* stuff globally 
Humans are just better at judging what's okay here than a machine.
 2017-10-31 07:35:00 +01:00
Florian Bruhin
e9483bc485 Merge remote-tracking branch 'origin/pr/3122' 2017-10-31 07:05:38 +01:00
dwagle
f70740cc3a set original query parameters if any before redirecting to new_url 2017-10-31 11:47:06 +05:45
Ulrik de Muelenaere
95b41b311f Disable ESLint no-bitwise rule 2017-10-30 22:24:59 +02:00
Ulrik de Muelenaere
3adc2e0f83 Add filter to NodeIterator checking for styled nodes 2017-10-30 19:56:12 +02:00
Ulrik de Muelenaere
34b27437d0 Clarify function names in stylesheet.js 2017-10-30 19:55:37 +02:00
Ulrik de Muelenaere
0540a43995 Check for deleted window 2017-10-30 19:52:15 +02:00
Jay Kamat
64b6852ae3
Fix a couple style issues 2017-10-30 12:40:44 -04:00
dwagle
aab7496916 fixes issue #3161 2017-10-30 17:09:45 +05:45
Florian Bruhin
daee729fc2 Merge remote-tracking branch 'origin/pr/3200' 2017-10-30 06:58:46 +01:00
Florian Bruhin
3d53ffb7ef Bump up YAML load deadline some more 2017-10-30 06:55:55 +01:00
Ulrik de Muelenaere
2fe1a1db89 Remove unused variable 2017-10-29 00:23:11 +02:00
Ulrik de Muelenaere
51d48f6b00 Rewrite user stylesheet injection for WebEngine 
This now works correctly in XML documents. The stylesheet is applied at
document creation to reduce flickering, and is updated if the
user_stylesheets setting is changed after page load.
 2017-10-28 22:16:29 +02:00
Jay Kamat
2a4163b2c7
Fix ellipsis on pinned tabs with index > 10 
See #3209
 2017-10-27 17:20:55 -04:00
Luca Benci
f5f11f7f4e Remove _ignore_change 2017-10-27 20:15:33 +02:00
Luca Benci
2947b75ab9 Make eslint happy 2017-10-27 19:52:10 +02:00
Ryan Roden-Corrent
24f466b2c3 Add --related flag to edit-url. 2017-10-26 22:13:35 -04:00
Ryan Roden-Corrent
6519f500a9 Add --private flag to edit_url. 
The command :edit-url --private (or :edit-url -p) will spawn a new
private window with the url input from the editor.

I had to add 'Given I have a fresh instance' to the feature file to
ensure tests were not interfering.

Resolves #3185.
 2017-10-26 07:21:51 -04:00
Florian Bruhin
eee5f8263f Merge remote-tracking branch 'origin/pr/3179' 2017-10-26 09:43:42 +02:00
Florian Bruhin
c883d6b429 Merge remote-tracking branch 'origin/pr/3196' 2017-10-26 08:46:21 +02:00
Luca Benci
ff7edf79e7 Rethrow exception if we can't handle it 2017-10-25 22:53:54 +02:00
Luca Benci
ae2dad7d18 Only catch the correct exception 2017-10-25 22:43:17 +02:00
Luca Benci
3fd7fb3e14 Do not assume elem.selectionStart exists 2017-10-25 22:38:44 +02:00
Luca Benci
f195b7e4d2 Fix flake8 failures 2017-10-25 21:18:53 +02:00
Florian Bruhin
2ab441a5a3 Merge remote-tracking branch 'origin/pr/3129' 2017-10-25 20:49:55 +02:00
lxhillwind
4c7f6e5339 Update configfiles.py: line too long fix 2017-10-26 02:04:09 +08:00
lxhillwind
66c5350989 handle <EOL> of :config-write-py generated file 2017-10-26 00:06:53 +08:00
Florian Bruhin
ed2f473a8e Make it more clear that :messages helps with failing processes 2017-10-24 22:56:04 +02:00
Jay Kamat
cb6f4313d7
Lower tabbar cache bound and clean up code 2017-10-24 10:18:10 -04:00
Florian Bruhin
1d18e808b1 Merge remote-tracking branch 'origin/pr/3182' 2017-10-24 09:31:25 +02:00
Florian Bruhin
43bca9793e Merge remote-tracking branch 'origin/pr/3136' 2017-10-24 08:57:28 +02:00
siddhugolu
570f1a849f modified as requested 2017-10-24 12:20:07 +05:30
siddhugolu
bc9d305354 modified as requested 2017-10-23 01:46:02 +05:30
siddhugolu
4862b2faf9 modified pylint pragmas 2017-10-22 23:52:35 +05:30
Luca Benci
96bbdb19e6 Add missing docstrings 2017-10-22 20:02:32 +02:00
Christopher Pezley
96eff65690 Log when url contains characters not present in current locale. 2017-10-22 18:41:29 +02:00
Florian Bruhin
bd0289423e Merge remote-tracking branch 'origin/pr/3180' 2017-10-22 17:33:06 +02:00
Florian Bruhin
a704526582 Remove messages.unfocused 2017-10-22 17:30:47 +02:00
Michael Hoang
e5f2d27ed9 Ensure that a window with the given win_id exists 2017-10-22 08:22:45 +11:00
Luca Benci
56d29a1b5f Avoid scheduling spurious completion updates 
Instead of setting `_ignore_change` to `True` before calling
`_change_completed_part` we just stop `_cmd` from emitting
`update_completion`.

This has the nice side-effect that when writing a complete command
`_ignore_change` was set to `True` regardless, and thus hitting space
would not update the completion view.

Now, hitting space will (as always) schedule a completion update that
now will not be incorrectly ignored
 2017-10-21 23:20:37 +02:00
Jay Kamat
49daa7aab8
Add most recent tab bar to cache statistics 2017-10-21 16:18:23 -04:00
Christopher Pezley
bdfb9c60cc Fix issue where opening a file whose name contains characters not 
present in locale would cause a crash.

Fixes qutebrowser/qutebrowser/1450
 2017-10-21 21:01:07 +02:00
Jay Kamat
b499474599
Prevent calling _tab_pinned on every tab twice 2017-10-21 00:32:05 -04:00
Jay Kamat
caae1c7008
Fix blowing cache for different icons 2017-10-20 22:13:54 -04:00
Jay Kamat
fde4495bc7
Clear cache on config changes 2017-10-20 16:35:11 -04:00
Luca Benci
dee0799e15 Avoid crash with LC_ALL=C and unicode filename 2017-10-20 22:06:59 +02:00
Jay Kamat
e705ea7e56
Rename _minimum_tab_size_hint_helper 2017-10-20 15:40:11 -04:00
Jay Kamat
f6cc9d53b8
Merge branch 'master' into jay/cache-tabsize 2017-10-20 15:24:22 -04:00
Florian Bruhin
128a16173e Merge remote-tracking branch 'origin/pr/3165' 2017-10-20 09:14:41 +02:00
Florian Bruhin
5fe6e60ffd Fix lint 2017-10-20 09:12:23 +02:00
Florian Bruhin
8504d41db3 Use Qt API for QtWebEngine scrolling 
See #2233
Fixes #2822
 2017-10-20 08:58:28 +02:00
Florian Bruhin
dd927ded6b Only update tab/window title on scroll if needed 
This way, if {scroll_pos} is not in the window/tab title template,
we don't redraw anything unnecessarily.

See #2233
 2017-10-20 08:25:43 +02:00
Florian Bruhin
fd8e5e30c6 Re-add scroll filtering and disable it for mark/scroll tests 
See #2233
 2017-10-20 07:38:51 +02:00
Florian Bruhin
455b90ecad Log which dictionaries have been found 
See #3166
 2017-10-20 07:14:32 +02:00
Martin Fraga
2bfa853847 Add keyhint radius configuration option 
The radius for the keyhint dialog box should be configurable vi via
c.keyhint.radius. The default was set to 6px, which is the previous
hardcoded value.
 2017-10-19 02:03:59 -07:00
Luca Benci
0436526203 Change default editor command 2017-10-18 21:08:22 +02:00
Luca Benci
cf04219f79 Rename possible_placeholder to arg 2017-10-18 20:20:05 +02:00
Luca Benci
7907840ead Add full stops 2017-10-18 20:19:47 +02:00
Luca Benci
addccd7492 Move comment to docstring and fix typo 2017-10-18 20:19:09 +02:00
Florian Bruhin
5a9042ab3e Add a config.source() method 2017-10-18 13:53:26 +02:00
Florian Bruhin
354c3c8c9b Handle unknown filetypes with qute://help 2017-10-18 09:02:39 +02:00
Luca Benci
f710536092 Move line and column calculation to own function 2017-10-17 22:48:43 +02:00
Luca Benci
233e72fef1 Adjust docstring 2017-10-17 22:38:11 +02:00
Florian Bruhin
9dc9bcaf39 Make standarddir work on HaikuOS 
For some reason, it returns an empty DataLocation.
 2017-10-17 22:37:14 +02:00
Luca Benci
e508224a46 Avoid the use of chained replaces 2017-10-17 22:35:01 +02:00
Luca Benci
b3445bc35a Add default value for caret_position 2017-10-17 22:08:54 +02:00
Jay Kamat
5d11a1fd75
Prevent :home from bypassing pinned tab warnings 
Closes #3138
 2017-10-17 11:37:37 -04:00
Florian Bruhin
96bec9f9d7 Fix error code for "database is locked" 
See #2930
 2017-10-17 15:35:23 +02:00
Florian Bruhin
12c9590524 Always use shortest match for completion.use_best_match 2017-10-17 15:01:37 +02:00
Florian Bruhin
161b96be1e Fix long line 2017-10-17 13:10:00 +02:00
Florian Bruhin
2e64dda592 Clean up getting matching commands 2017-10-17 11:40:34 +02:00
Florian Bruhin
c233099bca Merge remote-tracking branch 'origin/pr/3063' 2017-10-17 11:34:35 +02:00
Florian Bruhin
458a45c172 Remove old deprecated commands 2017-10-17 10:44:22 +02:00
Florian Bruhin
f1ddf58260 Add a deprecated :tab-detach 2017-10-17 10:30:47 +02:00
Florian Bruhin
f84af0a6fb Fix docstring 2017-10-17 09:33:20 +02:00
Florian Bruhin
ced4713fda Reverse if/else 2017-10-17 09:14:59 +02:00
Florian Bruhin
cce4ff6d53 Merge remote-tracking branch 'origin/pr/3054' 2017-10-17 09:10:45 +02:00
Florian Bruhin
373ad28d2e Release v1.0.2 
(cherry picked from commit 55a88ceea674fdfaf5577c255bc704e41e3353a3)
 2017-10-17 07:46:02 +02:00
Florian Bruhin
1a7612e559 Bump up yaml timeout a bit 2017-10-17 06:28:22 +02:00
Florian Bruhin
d8384ced0a Show better error message when trying to toggle with :set 2017-10-17 06:26:42 +02:00
Aneesh Roy
50983f01b8 New tab opens as unrelated 2017-10-16 17:14:48 +01:00
Aneesh Roy
4d780e23af Add tabs.close_mouse_button_on_bar ignore option 2017-10-16 15:49:19 +01:00
Aneesh Roy
674269724f Configurable behavior of close mouse button on bar 2017-10-16 15:44:52 +01:00
Florian Bruhin
e89fda189a Fix tab sizing when we get a QPainter and not a QStylePainter 
I'm not sure yet how that happens, but I got a crash report for that.
See #3099
 2017-10-16 13:44:51 +02:00
Florian Bruhin
e766fe14fc Fix HTML escaping in completion 2017-10-16 12:27:13 +02:00
Florian Bruhin
5307b97ca5 Improve checkpyver error message 2017-10-16 09:24:31 +02:00
Florian Bruhin
8756997dc8 Merge remote-tracking branch 'origin/pr/3099' 2017-10-16 08:30:03 +02:00
Florian Bruhin
09868c1e7f Update docs 2017-10-16 08:17:45 +02:00
Florian Bruhin
3797b0cfed Merge remote-tracking branch 'origin/pr/3034' 2017-10-16 08:12:15 +02:00
Florian Bruhin
3d02feac2b Merge pull request #3118 from jgkamat/jay/git-version 
Change qute:version git commit to display hash
 2017-10-16 07:59:52 +02:00
Florian Bruhin
2a65cadb67 Fix setting monospace fonts with None values 
Fixes #3130
 2017-10-16 06:18:09 +02:00
Florian Bruhin
e003b11670 Fix overflow handling for QtWebKit scrolling 
If we do "m * val / 100", the value gets bigger, so we need to check for an
overflow afterwards.
 2017-10-15 22:30:17 +02:00
Florian Bruhin
fa4a66f7b3 Add SQLITE_READONLY to environmental errors 2017-10-15 21:10:11 +02:00
Adrien Folie
57e1135abe fix blurry favicons on hidpi displays 2017-10-15 19:24:15 +02:00
Florian Bruhin
16b2df56df Merge remote-tracking branch 'origin/pr/3115' 2017-10-15 00:27:14 +02:00
Florian Bruhin
f4796b5ec6 Add missing period 2017-10-15 00:22:19 +02:00
Florian Bruhin
71f48a1e30 Move statusbar colors together in configdata.yml 2017-10-15 00:21:35 +02:00
Florian Bruhin
69d4bb6c6a Merge remote-tracking branch 'origin/pr/3119' 2017-10-15 00:20:47 +02:00
Jay Kamat
4ff44eff7b
Clean up logic for finding git hash 
Also add implementation for release scripts as well
 2017-10-14 18:08:52 -04:00
Jay Kamat
08b562ea0c
Add caching for tab sizes 2017-10-14 17:59:50 -04:00
Florian Bruhin
01d2654c23 Improve history formatting in crashdialog 2017-10-14 22:27:30 +02:00
Florian Bruhin
bad349aacf Fix getting history in crash dialog 2017-10-14 22:23:03 +02:00
Kimat Boven
ffab9e263f it was not possible to show the current_url in tab or window title 
note that I couldn't use {url} as field for the FormatString
 2017-10-14 22:14:01 +02:00
Florian Bruhin
5dacf1431f eslint: Disable multiline-comment-style 2017-10-14 21:41:56 +02:00