I thought I put this in here before, but apparently I did not. So here it is,
together with a new test to verify it. Other tests needed to be updated with a
mock for os.path.expandvars.
In function File.validate the try-except block has been re-written to
differentiate raised errors.
In function File.transform there was a check for validity of the file path that
is alraedy performed by File.validate under the same conditions. This check has
been removed.
When downloading a bunch (7 or 8) of files I noticed qutebrowser was using a lot
of CPU (>60%).
I did some looking, and in the `downloadProgress` callback qutebrower emits the
updated signal which causes everything to be updated. We don't really need this,
since _update_speed() calls it every 500ms anyway.
I tested by downloading 3 copies of the 1GB file [on this
page]( http://www.thinkbroadband.com/download.html ) qutebrowser consistently
pulls about 25% CPU on my system.
When removing this call, the system pulls about 17% CPU. Not a great amount, but
still significant enough to warrant a pull request ;-)
Some other notes:
- wget uses about 1.5%-2% for each process when downloading.
- When not doing any UI updates & speed calculations qutebrowser uses about 15%.
- Doing some quick profiling and strategic commenting seems to indicate there
isn't any other low hanging fruit to be improved on here.
This hopefully fixes this warning on Windows:
QWindowsWindow::setGeometryDp: Unable to set geometry 113x16+192+124 on
QWidgetWindow/'ProgressClassWindow'. Resulting geometry: 124x16+192+124
(frame: 8, 31, 8, 8, custom margin: 0, 0, 0, 0, minimum size: 0x0, maximum
size: 16777215x16777215).
Upstream changelog:
- Messages sent by qDebug, qWarning, qCritical are captured and displayed when
tests fail, similar to pytest-catchlog. Also, tests can be configured to
automatically fail if an unexpected message is generated. (See docs).
- New method waitSignals: will block untill all signals given are triggered, see
docs (thanks @The-Compiler for idea and complete PR).
- New parameter raising to waitSignals and waitSignals: when True (defaults to
False) will raise a qtbot.SignalTimeoutError exception when timeout is reached,
see docs (thanks again to @The-Compiler for idea and complete PR).
- pytest-qt now requires pytest version >= 2.7.
Internal changes to improve memory management
- QApplication.exit() is no longer called at the end of the test session and
the QApplication instance is not garbage collected anymore;
- QtBot no longer receives a QApplication as a parameter in the constructor,
always referencing QApplication.instance() now; this avoids keeping an extra
reference in the qtbot instances.
- deleteLater is called on widgets added in QtBot.addWidget at the end of each
test;
- QApplication.processEvents() is called at the end of each test to make sure
widgets are cleaned up;
Error messages for validate() are more specific.
Return of standarddir.conf() is explicitly tested for None to avoid ambiguity
with other falsey values.
