Remove the deprecated :tab-detach

This commit is contained in:
Florian Bruhin 2018-06-09 21:25:09 +02:00
parent cf3c200fcb
commit dcb1191f93
3 changed files with 8 additions and 9 deletions

View File

@ -47,6 +47,11 @@ Changed
- On Qt 5.11, using wayland with QtWebEngine is now possible when using - On Qt 5.11, using wayland with QtWebEngine is now possible when using
software rendering. software rendering.
Removed
~~~~~~~
- `:tab-detach` which has been deprecated in v1.1.0 has been removed.
v1.3.2 (unreleased) v1.3.2 (unreleased)
------------------- -------------------

View File

@ -566,12 +566,6 @@ class CommandDispatcher:
tabbed_browser.tabopen(self._current_url()) tabbed_browser.tabopen(self._current_url())
self._tabbed_browser.close_tab(self._current_widget(), add_undo=False) self._tabbed_browser.close_tab(self._current_widget(), add_undo=False)
@cmdutils.register(instance='command-dispatcher', scope='window',
deprecated='Use :tab-give instead!')
def tab_detach(self):
"""Deprecated way to detach a tab."""
self.tab_give()
def _back_forward(self, tab, bg, window, count, forward): def _back_forward(self, tab, bg, window, count, forward):
"""Helper function for :back/:forward.""" """Helper function for :back/:forward."""
history = self._current_widget().history history = self._current_widget().history

View File

@ -125,7 +125,7 @@ def cmdutils_patch(monkeypatch, stubs, miscmodels_patch):
"""docstring.""" """docstring."""
pass pass
def tab_detach(): def tab_give():
"""docstring.""" """docstring."""
pass pass
@ -140,7 +140,7 @@ def cmdutils_patch(monkeypatch, stubs, miscmodels_patch):
'help': command.Command(name='help', handler=show_help), 'help': command.Command(name='help', handler=show_help),
'open': command.Command(name='open', handler=openurl, maxsplit=0), 'open': command.Command(name='open', handler=openurl, maxsplit=0),
'bind': command.Command(name='bind', handler=bind), 'bind': command.Command(name='bind', handler=bind),
'tab-detach': command.Command(name='tab-detach', handler=tab_detach), 'tab-give': command.Command(name='tab-give', handler=tab_give),
'config-cycle': command.Command(name='config-cycle', 'config-cycle': command.Command(name='config-cycle',
handler=config_cycle), handler=config_cycle),
}) })
@ -189,7 +189,7 @@ def _set_cmd_prompt(cmd, txt):
(':open -t |', 'url', '', []), (':open -t |', 'url', '', []),
(':open --tab |', 'url', '', []), (':open --tab |', 'url', '', []),
(':open | -t', 'url', '', []), (':open | -t', 'url', '', []),
(':tab-detach |', None, '', []), (':tab-give |', None, '', []),
(':bind --mode=caret <c-x> |', 'command', '', ['<c-x>']), (':bind --mode=caret <c-x> |', 'command', '', ['<c-x>']),
pytest.param(':bind --mode caret <c-x> |', 'command', '', [], pytest.param(':bind --mode caret <c-x> |', 'command', '', [],
marks=pytest.mark.xfail(reason='issue #74')), marks=pytest.mark.xfail(reason='issue #74')),