From dcb1191f93ae9894a869f2340b8c304908d03eec Mon Sep 17 00:00:00 2001
From: Florian Bruhin <git@the-compiler.org>
Date: Sat, 9 Jun 2018 21:25:09 +0200
Subject: [PATCH] Remove the deprecated :tab-detach

---
 doc/changelog.asciidoc                  | 5 +++++
 qutebrowser/browser/commands.py         | 6 ------
 tests/unit/completion/test_completer.py | 6 +++---
 3 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/doc/changelog.asciidoc b/doc/changelog.asciidoc
index 73bc9a0fd..f9d528c27 100644
--- a/doc/changelog.asciidoc
+++ b/doc/changelog.asciidoc
@@ -47,6 +47,11 @@ Changed
 - On Qt 5.11, using wayland with QtWebEngine is now possible when using
   software rendering.
 
+Removed
+~~~~~~~
+
+- `:tab-detach` which has been deprecated in v1.1.0 has been removed.
+
 v1.3.2 (unreleased)
 -------------------
 
diff --git a/qutebrowser/browser/commands.py b/qutebrowser/browser/commands.py
index 1674a7eb0..45d1d2015 100644
--- a/qutebrowser/browser/commands.py
+++ b/qutebrowser/browser/commands.py
@@ -566,12 +566,6 @@ class CommandDispatcher:
         tabbed_browser.tabopen(self._current_url())
         self._tabbed_browser.close_tab(self._current_widget(), add_undo=False)
 
-    @cmdutils.register(instance='command-dispatcher', scope='window',
-                       deprecated='Use :tab-give instead!')
-    def tab_detach(self):
-        """Deprecated way to detach a tab."""
-        self.tab_give()
-
     def _back_forward(self, tab, bg, window, count, forward):
         """Helper function for :back/:forward."""
         history = self._current_widget().history
diff --git a/tests/unit/completion/test_completer.py b/tests/unit/completion/test_completer.py
index bdc0c1cf5..dc98f0efb 100644
--- a/tests/unit/completion/test_completer.py
+++ b/tests/unit/completion/test_completer.py
@@ -125,7 +125,7 @@ def cmdutils_patch(monkeypatch, stubs, miscmodels_patch):
         """docstring."""
         pass
 
-    def tab_detach():
+    def tab_give():
         """docstring."""
         pass
 
@@ -140,7 +140,7 @@ def cmdutils_patch(monkeypatch, stubs, miscmodels_patch):
         'help': command.Command(name='help', handler=show_help),
         'open': command.Command(name='open', handler=openurl, maxsplit=0),
         'bind': command.Command(name='bind', handler=bind),
-        'tab-detach': command.Command(name='tab-detach', handler=tab_detach),
+        'tab-give': command.Command(name='tab-give', handler=tab_give),
         'config-cycle': command.Command(name='config-cycle',
                                         handler=config_cycle),
     })
@@ -189,7 +189,7 @@ def _set_cmd_prompt(cmd, txt):
     (':open -t |', 'url', '', []),
     (':open --tab |', 'url', '', []),
     (':open | -t', 'url', '', []),
-    (':tab-detach |', None, '', []),
+    (':tab-give |', None, '', []),
     (':bind --mode=caret <c-x> |', 'command', '', ['<c-x>']),
     pytest.param(':bind --mode caret <c-x> |', 'command', '', [],
                  marks=pytest.mark.xfail(reason='issue #74')),