rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Make hinting work again.

Browse Source 
6b2d2713f7 broke this as we accidentally
iterate over self._frames before setting it.
This commit is contained in:
Florian Bruhin 2014-05-14 18:54:34 +02:00
parent f78f511c1f
commit cf02330b42
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qutebrowser/browser/hints.py
View File

@ -399,6 +399,7 @@ class HintManager(QObject):
# on_mode_left, we are extra careful here. # on_mode_left, we are extra careful here.
raise ValueError("start() was called with frame=None") raise ValueError("start() was called with frame=None")
elems = [] elems = []
self._frames = webelem.get_child_frames(mainframe)
for f in self._frames: for f in self._frames:
elems += f.findAllElements(webelem.SELECTORS[group]) elems += f.findAllElements(webelem.SELECTORS[group])
filterfunc = webelem.FILTERS.get(group, lambda e: True) filterfunc = webelem.FILTERS.get(group, lambda e: True)
@ -408,7 +409,6 @@ class HintManager(QObject):
raise CommandError("No elements found.") raise CommandError("No elements found.")
self._target = target self._target = target
self._baseurl = baseurl self._baseurl = baseurl
self._frames = webelem.get_child_frames(mainframe)
message.text(self.HINT_TEXTS[target]) message.text(self.HINT_TEXTS[target])
strings = self._hint_strings(visible_elems) strings = self._hint_strings(visible_elems)
for e, string in zip(visible_elems, strings): for e, string in zip(visible_elems, strings):