From cf02330b423b8973e12e3b15c7e93721aceb9a6b Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 14 May 2014 18:54:34 +0200 Subject: [PATCH] Make hinting work again. 6b2d2713f785a84c8f3935395cb7c02c904c65d6 broke this as we accidentally iterate over self._frames before setting it. --- qutebrowser/browser/hints.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qutebrowser/browser/hints.py b/qutebrowser/browser/hints.py index 13bda1f5f..02e80eeae 100644 --- a/qutebrowser/browser/hints.py +++ b/qutebrowser/browser/hints.py @@ -399,6 +399,7 @@ class HintManager(QObject): # on_mode_left, we are extra careful here. raise ValueError("start() was called with frame=None") elems = [] + self._frames = webelem.get_child_frames(mainframe) for f in self._frames: elems += f.findAllElements(webelem.SELECTORS[group]) filterfunc = webelem.FILTERS.get(group, lambda e: True) @@ -408,7 +409,6 @@ class HintManager(QObject): raise CommandError("No elements found.") self._target = target self._baseurl = baseurl - self._frames = webelem.get_child_frames(mainframe) message.text(self.HINT_TEXTS[target]) strings = self._hint_strings(visible_elems) for e, string in zip(visible_elems, strings):