rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Finish stats correctly with QtWebEngine downloads

Browse Source
This commit is contained in:
Florian Bruhin 2016-11-08 20:41:40 +01:00
parent 3ba7f28069
commit baeb8653c8
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
qutebrowser/browser/webengine/webenginedownloads.py
View File

@ -60,15 +60,18 @@ class DownloadItem(downloads.AbstractDownloadItem):
self.successful = True self.successful = True
self.done = True self.done = True
self.finished.emit() self.finished.emit()
self.stats.finish()
elif state == QWebEngineDownloadItem.DownloadCancelled: elif state == QWebEngineDownloadItem.DownloadCancelled:
self.successful = False self.successful = False
self.done = True self.done = True
self.cancelled.emit() self.cancelled.emit()
self.stats.finish()
elif state == QWebEngineDownloadItem.DownloadInterrupted: elif state == QWebEngineDownloadItem.DownloadInterrupted:
self.successful = False self.successful = False
self.done = True self.done = True
# https://bugreports.qt.io/browse/QTBUG-56839 # https://bugreports.qt.io/browse/QTBUG-56839
self.error.emit("Download failed") self.error.emit("Download failed")
self.stats.finish()
else: else:
raise ValueError("_on_state_changed was called with unknown state " raise ValueError("_on_state_changed was called with unknown state "
"{}".format(state_name)) "{}".format(state_name))