From baeb8653c83d73ec7a237019e86b78c803a4a464 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 8 Nov 2016 20:41:40 +0100 Subject: [PATCH] Finish stats correctly with QtWebEngine downloads --- qutebrowser/browser/webengine/webenginedownloads.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qutebrowser/browser/webengine/webenginedownloads.py b/qutebrowser/browser/webengine/webenginedownloads.py index d43916f9d..5b4e7f498 100644 --- a/qutebrowser/browser/webengine/webenginedownloads.py +++ b/qutebrowser/browser/webengine/webenginedownloads.py @@ -60,15 +60,18 @@ class DownloadItem(downloads.AbstractDownloadItem): self.successful = True self.done = True self.finished.emit() + self.stats.finish() elif state == QWebEngineDownloadItem.DownloadCancelled: self.successful = False self.done = True self.cancelled.emit() + self.stats.finish() elif state == QWebEngineDownloadItem.DownloadInterrupted: self.successful = False self.done = True # https://bugreports.qt.io/browse/QTBUG-56839 self.error.emit("Download failed") + self.stats.finish() else: raise ValueError("_on_state_changed was called with unknown state " "{}".format(state_name))