rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

downloads: Check if reply is open when doing delayed write.

Browse Source 
This fixes a "QIODevice::read: device not open" warning when closing the window
while a download is active.
This commit is contained in:
Florian Bruhin 2014-11-11 21:40:25 +01:00
parent b502280c06
commit b70c3754e8
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
qutebrowser/browser/downloads.py
View File

@ -266,7 +266,8 @@ class DownloadItem(QObject):
"""Write buffered data to disk and finish the QNetworkReply.""" """Write buffered data to disk and finish the QNetworkReply."""
log.downloads.debug("Doing delayed write...") log.downloads.debug("Doing delayed write...")
self._do_delayed_write = False self._do_delayed_write = False
self._fileobj.write(self._reply.readAll()) if self._reply.isOpen():
self._fileobj.write(self._reply.readAll())
self._fileobj.close() self._fileobj.close()
self._reply.close() self._reply.close()
self._reply.deleteLater() self._reply.deleteLater()