From b70c3754e850a191dd981856f747f1b2def102c8 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 11 Nov 2014 21:40:25 +0100 Subject: [PATCH] downloads: Check if reply is open when doing delayed write. This fixes a "QIODevice::read: device not open" warning when closing the window while a download is active. --- qutebrowser/browser/downloads.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qutebrowser/browser/downloads.py b/qutebrowser/browser/downloads.py index 541c5db5e..618c814b7 100644 --- a/qutebrowser/browser/downloads.py +++ b/qutebrowser/browser/downloads.py @@ -266,7 +266,8 @@ class DownloadItem(QObject): """Write buffered data to disk and finish the QNetworkReply.""" log.downloads.debug("Doing delayed write...") self._do_delayed_write = False - self._fileobj.write(self._reply.readAll()) + if self._reply.isOpen(): + self._fileobj.write(self._reply.readAll()) self._fileobj.close() self._reply.close() self._reply.deleteLater()