rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Reword FIXME comments

Browse Source
This commit is contained in:
Florian Bruhin 2014-04-22 14:35:56 +02:00
parent 70e1a0300c
commit a1650579e9
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
qutebrowser/browser/signalfilter.py
View File

@ -71,19 +71,13 @@ class SignalFilter(QObject):
Emit: Emit:
The target signal if the sender was the current widget. The target signal if the sender was the current widget.
""" """
# FIXME BUG the signal cache ordering seems to be weird sometimes.
# How to reproduce:
# - Open tab
# - While loading, open another tab
# - Switch back to #1 when loading finished
# - It seems loadingStarted is before loadingFinished
sender = self.sender() sender = self.sender()
log_signal = not signal.signal.startswith('2cur_progress') log_signal = not signal.signal.startswith('2cur_progress')
if log_signal: if log_signal:
logging.debug('signal {} (tab {})'.format( logging.debug('signal {} (tab {})'.format(
dbg_signal(signal, args), self._tabs.indexOf(sender))) dbg_signal(signal, args), self._tabs.indexOf(sender)))
if not isinstance(sender, BrowserTab): if not isinstance(sender, BrowserTab):
# FIXME why does this happen? # BUG? This should never happen, but it does regularely...
logging.warn('Got signal {} by {} which is no tab!'.format( logging.warn('Got signal {} by {} which is no tab!'.format(
dbg_signal(signal, args), sender)) dbg_signal(signal, args), sender))
return return