From a1650579e9004a43b3fb182482c0c5a75bb24816 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 22 Apr 2014 14:35:56 +0200 Subject: [PATCH] Reword FIXME comments --- qutebrowser/browser/signalfilter.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/qutebrowser/browser/signalfilter.py b/qutebrowser/browser/signalfilter.py index 2183b9ba8..52ca5c5bf 100644 --- a/qutebrowser/browser/signalfilter.py +++ b/qutebrowser/browser/signalfilter.py @@ -71,19 +71,13 @@ class SignalFilter(QObject): Emit: The target signal if the sender was the current widget. """ - # FIXME BUG the signal cache ordering seems to be weird sometimes. - # How to reproduce: - # - Open tab - # - While loading, open another tab - # - Switch back to #1 when loading finished - # - It seems loadingStarted is before loadingFinished sender = self.sender() log_signal = not signal.signal.startswith('2cur_progress') if log_signal: logging.debug('signal {} (tab {})'.format( dbg_signal(signal, args), self._tabs.indexOf(sender))) if not isinstance(sender, BrowserTab): - # FIXME why does this happen? + # BUG? This should never happen, but it does regularely... logging.warn('Got signal {} by {} which is no tab!'.format( dbg_signal(signal, args), sender)) return