rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't try to remove watched files if none exist

Browse Source 
If we try to remove watched files but we couldn't actually watch any earlier,
we'd get a Qt warning message:

QtWarningMsg: QFileSystemWatcher::removePaths: list is empty
This commit is contained in:
Florian Bruhin 2018-02-08 10:20:30 +01:00
parent 1da58b6a4c
commit 9d32807e33
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
qutebrowser/misc/editor.py
View File

@ -63,10 +63,13 @@ class ExternalEditor(QObject):
def _cleanup(self): def _cleanup(self):
"""Clean up temporary files after the editor closed.""" """Clean up temporary files after the editor closed."""
assert self._remove_file is not None assert self._remove_file is not None
if self._watcher:
failed = self._watcher.removePaths(self._watcher.files()) watched_files = self._watcher.files() if self._watcher else []
if watched_files:
failed = self._watcher.removePaths(watched_files)
if failed: if failed:
log.procs.error("Failed to unwatch paths: {}".format(failed)) log.procs.error("Failed to unwatch paths: {}".format(failed))
if self._filename is None or not self._remove_file: if self._filename is None or not self._remove_file:
# Could not create initial file. # Could not create initial file.
return return