From 9d32807e3333630bac025d18354958ae2a721348 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 8 Feb 2018 10:20:30 +0100 Subject: [PATCH] Don't try to remove watched files if none exist If we try to remove watched files but we couldn't actually watch any earlier, we'd get a Qt warning message: QtWarningMsg: QFileSystemWatcher::removePaths: list is empty --- qutebrowser/misc/editor.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/qutebrowser/misc/editor.py b/qutebrowser/misc/editor.py index 80bf9cd16..154660001 100644 --- a/qutebrowser/misc/editor.py +++ b/qutebrowser/misc/editor.py @@ -63,10 +63,13 @@ class ExternalEditor(QObject): def _cleanup(self): """Clean up temporary files after the editor closed.""" assert self._remove_file is not None - if self._watcher: - failed = self._watcher.removePaths(self._watcher.files()) + + watched_files = self._watcher.files() if self._watcher else [] + if watched_files: + failed = self._watcher.removePaths(watched_files) if failed: log.procs.error("Failed to unwatch paths: {}".format(failed)) + if self._filename is None or not self._remove_file: # Could not create initial file. return