rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove typing module from version.py

Browse Source 
It comes with python now
This commit is contained in:
Florian Bruhin 2017-09-18 23:06:49 +02:00
parent b1b6c462c1
commit 8ae87bbde2
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
qutebrowser/utils/version.py
View File

@ -190,7 +190,6 @@ def _module_versions():
('pygments', ['__version__']), ('pygments', ['__version__']),
('yaml', ['__version__']), ('yaml', ['__version__']),
('cssutils', ['__version__']), ('cssutils', ['__version__']),
('typing', []),
('PyQt5.QtWebEngineWidgets', []), ('PyQt5.QtWebEngineWidgets', []),
('PyQt5.QtWebKitWidgets', []), ('PyQt5.QtWebKitWidgets', []),
]) ])

5
tests/unit/utils/test_version.py
View File

@ -515,12 +515,10 @@ class ImportFake:
('pygments', True), ('pygments', True),
('yaml', True), ('yaml', True),
('cssutils', True), ('cssutils', True),
('typing', True),
('PyQt5.QtWebEngineWidgets', True), ('PyQt5.QtWebEngineWidgets', True),
('PyQt5.QtWebKitWidgets', True), ('PyQt5.QtWebKitWidgets', True),
]) ])
self.no_version_attribute = ['sip', 'typing', self.no_version_attribute = ['sip', 'PyQt5.QtWebEngineWidgets',
'PyQt5.QtWebEngineWidgets',
'PyQt5.QtWebKitWidgets'] 'PyQt5.QtWebKitWidgets']
self.version_attribute = '__version__' self.version_attribute = '__version__'
self.version = '1.2.3' self.version = '1.2.3'
@ -588,7 +586,6 @@ class TestModuleVersions:
@pytest.mark.parametrize('module, idx, expected', [ @pytest.mark.parametrize('module, idx, expected', [
('colorama', 1, 'colorama: no'), ('colorama', 1, 'colorama: no'),
('cssutils', 6, 'cssutils: no'), ('cssutils', 6, 'cssutils: no'),
('typing', 7, 'typing: no'),
]) ])
def test_missing_module(self, module, idx, expected, import_fake): def test_missing_module(self, module, idx, expected, import_fake):
"""Test with a module missing. """Test with a module missing.