From 8ae87bbde27f8bcafdc0423cbb3dedf488cb6b5c Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 18 Sep 2017 23:06:49 +0200 Subject: [PATCH] Remove typing module from version.py It comes with python now --- qutebrowser/utils/version.py | 1 - tests/unit/utils/test_version.py | 5 +---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/qutebrowser/utils/version.py b/qutebrowser/utils/version.py index 834d4ae3e..75ac197fa 100644 --- a/qutebrowser/utils/version.py +++ b/qutebrowser/utils/version.py @@ -190,7 +190,6 @@ def _module_versions(): ('pygments', ['__version__']), ('yaml', ['__version__']), ('cssutils', ['__version__']), - ('typing', []), ('PyQt5.QtWebEngineWidgets', []), ('PyQt5.QtWebKitWidgets', []), ]) diff --git a/tests/unit/utils/test_version.py b/tests/unit/utils/test_version.py index 399cb135c..4d977540d 100644 --- a/tests/unit/utils/test_version.py +++ b/tests/unit/utils/test_version.py @@ -515,12 +515,10 @@ class ImportFake: ('pygments', True), ('yaml', True), ('cssutils', True), - ('typing', True), ('PyQt5.QtWebEngineWidgets', True), ('PyQt5.QtWebKitWidgets', True), ]) - self.no_version_attribute = ['sip', 'typing', - 'PyQt5.QtWebEngineWidgets', + self.no_version_attribute = ['sip', 'PyQt5.QtWebEngineWidgets', 'PyQt5.QtWebKitWidgets'] self.version_attribute = '__version__' self.version = '1.2.3' @@ -588,7 +586,6 @@ class TestModuleVersions: @pytest.mark.parametrize('module, idx, expected', [ ('colorama', 1, 'colorama: no'), ('cssutils', 6, 'cssutils: no'), - ('typing', 7, 'typing: no'), ]) def test_missing_module(self, module, idx, expected, import_fake): """Test with a module missing.