rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Shut down NetworkManager before deleting WebPage.

Browse Source 
Now that the QWebPage actually is a parent of the QNetworkAccessManager, first
setting the page to None and then deleting the QNetworkAccessManager will get
us a RuntimeError because the underlying C++ object is already gone.
This commit is contained in:
Florian Bruhin 2014-09-02 07:01:23 +02:00
parent 7813f8f0c2
commit 892c02268a
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qutebrowser/widgets/webview.py
View File

@ -278,14 +278,12 @@ class WebView(QWebView):
settings = self.settings() settings = self.settings()
settings.setAttribute(QWebSettings.JavascriptEnabled, False) settings.setAttribute(QWebSettings.JavascriptEnabled, False)
self.stop() self.stop()
nam = self.page().networkAccessManager() self.page().networkAccessManager().shutdown()
# Explicitely releasing the page here seems to prevent some segfaults # Explicitely releasing the page here seems to prevent some segfaults
# when quitting. # when quitting.
# Copied from: # Copied from:
# https://code.google.com/p/webscraping/source/browse/webkit.py#325 # https://code.google.com/p/webscraping/source/browse/webkit.py#325
self.setPage(None) self.setPage(None)
nam.shutdown()
del nam
def openurl(self, url): def openurl(self, url):
"""Open a URL in the browser. """Open a URL in the browser.