From 892c02268af6bfdaca52bcdb7578431b40e523da Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 2 Sep 2014 07:01:23 +0200 Subject: [PATCH] Shut down NetworkManager before deleting WebPage. Now that the QWebPage actually is a parent of the QNetworkAccessManager, first setting the page to None and then deleting the QNetworkAccessManager will get us a RuntimeError because the underlying C++ object is already gone. --- qutebrowser/widgets/webview.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qutebrowser/widgets/webview.py b/qutebrowser/widgets/webview.py index 7b7b47c1a..1937a8479 100644 --- a/qutebrowser/widgets/webview.py +++ b/qutebrowser/widgets/webview.py @@ -278,14 +278,12 @@ class WebView(QWebView): settings = self.settings() settings.setAttribute(QWebSettings.JavascriptEnabled, False) self.stop() - nam = self.page().networkAccessManager() + self.page().networkAccessManager().shutdown() # Explicitely releasing the page here seems to prevent some segfaults # when quitting. # Copied from: # https://code.google.com/p/webscraping/source/browse/webkit.py#325 self.setPage(None) - nam.shutdown() - del nam def openurl(self, url): """Open a URL in the browser.