rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

hints: Ignore invalid href's instead of crashing.

Browse Source
This commit is contained in:
Florian Bruhin 2014-09-15 06:54:05 +02:00
parent ad2435fa0b
commit 81aa08593b
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
qutebrowser/browser/hints.py
View File

@ -393,11 +393,12 @@ class HintManager(QObject):
except KeyError: except KeyError:
return None return None
url = QUrl(text) url = QUrl(text)
if not url.isValid():
return None
if url.isRelative(): if url.isRelative():
if baseurl is None: if baseurl is None:
baseurl = self._context.baseurl baseurl = self._context.baseurl
url = baseurl.resolved(url) url = baseurl.resolved(url)
qtutils.ensure_valid(url)
return url return url
def _find_prevnext(self, frame, prev=False): def _find_prevnext(self, frame, prev=False):
@ -467,7 +468,7 @@ class HintManager(QObject):
raise cmdexc.CommandError("No {} links found!".format( raise cmdexc.CommandError("No {} links found!".format(
"prev" if prev else "forward")) "prev" if prev else "forward"))
url = self._resolve_url(elem, baseurl) url = self._resolve_url(elem, baseurl)
if url is None or not url.isValid(): if url is None:
raise cmdexc.CommandError("No {} links found!".format( raise cmdexc.CommandError("No {} links found!".format(
"prev" if prev else "forward")) "prev" if prev else "forward"))
self.openurl.emit(url, newtab) self.openurl.emit(url, newtab)