From 81aa08593bbb98f3341609451fd29af61a215baa Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 15 Sep 2014 06:54:05 +0200 Subject: [PATCH] hints: Ignore invalid href's instead of crashing. --- qutebrowser/browser/hints.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qutebrowser/browser/hints.py b/qutebrowser/browser/hints.py index 320cda79d..3e050f3c9 100644 --- a/qutebrowser/browser/hints.py +++ b/qutebrowser/browser/hints.py @@ -393,11 +393,12 @@ class HintManager(QObject): except KeyError: return None url = QUrl(text) + if not url.isValid(): + return None if url.isRelative(): if baseurl is None: baseurl = self._context.baseurl url = baseurl.resolved(url) - qtutils.ensure_valid(url) return url def _find_prevnext(self, frame, prev=False): @@ -467,7 +468,7 @@ class HintManager(QObject): raise cmdexc.CommandError("No {} links found!".format( "prev" if prev else "forward")) url = self._resolve_url(elem, baseurl) - if url is None or not url.isValid(): + if url is None: raise cmdexc.CommandError("No {} links found!".format( "prev" if prev else "forward")) self.openurl.emit(url, newtab)