rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Further prevent state leakage from test_init.

Browse Source 
test_history.test_init also leaked state by leaving the instantiated history as
the parent of the QApp, which was causing test_debug to fail because it was
trying to dump the history object left from test_history.
This commit is contained in:
Ryan Roden-Corrent 2017-02-16 20:32:03 -05:00
parent be38e181a8
commit 788babbb61
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/unit/browser/webkit/test_history.py
View File

@ -361,7 +361,8 @@ def test_init(backend, qapp, tmpdir, monkeypatch):
# before (so we need to test webengine before webkit)
assert default_interface is None
objreg.delete('web-history')
if backend == usertypes.Backend.QtWebKit:
# prevent interference with future tests
objreg.delete('web-history')
hist.setParent(None)
if backend == usertypes.Backend.QtWebKit:
QWebHistoryInterface.setDefaultInterface(None)