From 788babbb61f8b06f307a548622a2deea6af65bf9 Mon Sep 17 00:00:00 2001 From: Ryan Roden-Corrent Date: Thu, 16 Feb 2017 20:32:03 -0500 Subject: [PATCH] Further prevent state leakage from test_init. test_history.test_init also leaked state by leaving the instantiated history as the parent of the QApp, which was causing test_debug to fail because it was trying to dump the history object left from test_history. --- tests/unit/browser/webkit/test_history.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/unit/browser/webkit/test_history.py b/tests/unit/browser/webkit/test_history.py index 43b30ed19..890ff9a89 100644 --- a/tests/unit/browser/webkit/test_history.py +++ b/tests/unit/browser/webkit/test_history.py @@ -361,7 +361,8 @@ def test_init(backend, qapp, tmpdir, monkeypatch): # before (so we need to test webengine before webkit) assert default_interface is None + # prevent interference with future tests objreg.delete('web-history') + hist.setParent(None) if backend == usertypes.Backend.QtWebKit: - # prevent interference with future tests QWebHistoryInterface.setDefaultInterface(None)