rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Greasemonkey: Throw Errors if GM_ function args wrong type.

Browse Source 
These argument type restrictions are mentioned on the greasespot pages for
these value storage functions. We could call JSON.dumps() instead but better
to push that onto the caller so we don't have to try handle deserialization.

Also removes the check for localstorage because everyone has supported that
for years.
This commit is contained in:
Jimmy 2017-10-07 17:22:57 +13:00
parent d93c583c0d
commit 5e49e7eef2
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
qutebrowser/javascript/greasemonkey_wrapper.js
View File

@ -16,25 +16,29 @@
}()); }());
function GM_setValue(key, value) { function GM_setValue(key, value) {
if (localStorage !== null && if (typeof key !== "string") {
typeof key === "string" && throw new Error("GM_setValue requires the first parameter to be of type string, not '"+typeof key+"'");
(typeof value === "string" ||
typeof value === "number" ||
typeof value === "boolean")) {
localStorage.setItem(_qute_script_id + key, value);
} }
if (typeof value !== "string" ||
typeof value !== "number" ||
typeof value !== "boolean") {
throw new Error("GM_setValue requires the second parameter to be of type string, number or boolean, not '"+typeof value+"'");
}
localStorage.setItem(_qute_script_id + key, value);
} }
function GM_getValue(key, default_) { function GM_getValue(key, default_) {
if (localStorage !== null && typeof key === "string") { if (typeof key !== "string") {
return localStorage.getItem(_qute_script_id + key) || default_; throw new Error("GM_getValue requires the first parameter to be of type string, not '"+typeof key+"'");
} }
return localStorage.getItem(_qute_script_id + key) || default_;
} }
function GM_deleteValue(key) { function GM_deleteValue(key) {
if (localStorage !== null && typeof key === "string") { if (typeof key !== "string") {
localStorage.removeItem(_qute_script_id + key); throw new Error("GM_deleteValue requires the first parameter to be of type string, not '"+typeof key+"'");
} }
localStorage.removeItem(_qute_script_id + key);
} }
function GM_listValues() { function GM_listValues() {