From 5e49e7eef21ef1abaf327b1c060145f67ba6f868 Mon Sep 17 00:00:00 2001
From: Jimmy <jimmy@spalge.com>
Date: Sat, 7 Oct 2017 17:22:57 +1300
Subject: [PATCH] Greasemonkey: Throw Errors if GM_ function args wrong type.

These argument type restrictions are mentioned on the greasespot pages for
these value storage functions. We could call JSON.dumps() instead but better
to push that onto the caller so we don't have to try handle deserialization.

Also removes the check for localstorage because everyone has supported that
for years.
---
 .../javascript/greasemonkey_wrapper.js        | 24 +++++++++++--------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/qutebrowser/javascript/greasemonkey_wrapper.js b/qutebrowser/javascript/greasemonkey_wrapper.js
index a5079b89a..605f82d5a 100644
--- a/qutebrowser/javascript/greasemonkey_wrapper.js
+++ b/qutebrowser/javascript/greasemonkey_wrapper.js
@@ -16,25 +16,29 @@
     }());
 
     function GM_setValue(key, value) {
-        if (localStorage !== null &&
-                typeof key === "string" &&
-                (typeof value === "string" ||
-                 typeof value === "number" ||
-                 typeof value === "boolean")) {
-            localStorage.setItem(_qute_script_id + key, value);
+        if (typeof key !== "string") {
+          throw new Error("GM_setValue requires the first parameter to be of type string, not '"+typeof key+"'");
         }
+        if (typeof value !== "string" ||
+            typeof value !== "number" ||
+            typeof value !== "boolean") {
+          throw new Error("GM_setValue requires the second parameter to be of type string, number or boolean, not '"+typeof value+"'");
+        }
+        localStorage.setItem(_qute_script_id + key, value);
     }
 
     function GM_getValue(key, default_) {
-        if (localStorage !== null && typeof key === "string") {
-            return localStorage.getItem(_qute_script_id + key) || default_;
+        if (typeof key !== "string") {
+          throw new Error("GM_getValue requires the first parameter to be of type string, not '"+typeof key+"'");
         }
+        return localStorage.getItem(_qute_script_id + key) || default_;
     }
 
     function GM_deleteValue(key) {
-        if (localStorage !== null && typeof key === "string") {
-            localStorage.removeItem(_qute_script_id + key);
+        if (typeof key !== "string") {
+          throw new Error("GM_deleteValue requires the first parameter to be of type string, not '"+typeof key+"'");
         }
+        localStorage.removeItem(_qute_script_id + key);
     }
 
     function GM_listValues() {