rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Revert "Only emit perc_changed signal when the percentage actually changed"

Browse Source 
This reverts commit 1d50c2c39a.
This breaks various end2end test relying on getting log messages for scrolling.
This commit is contained in:
Florian Bruhin 2017-10-06 10:16:41 +02:00
parent cb357b326d
commit 54e5176f28
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
doc/changelog.asciidoc
View File

@ -106,7 +106,6 @@ Fixes
- The "try again" button on error pages works correctly again. - The "try again" button on error pages works correctly again.
- :spawn -u -d is now disallowed. - :spawn -u -d is now disallowed.
- :spawn -d shows error messages correctly now. - :spawn -d shows error messages correctly now.
- Performance improvements for smooth scrolling
v0.11.0 v0.11.0
------- -------

3
qutebrowser/browser/webengine/webenginetab.py
View File

@ -333,9 +333,8 @@ class WebEngineScroller(browsertab.AbstractScroller):
perc_y = min(100, round(100 / dy * jsret['px']['y'])) perc_y = min(100, round(100 / dy * jsret['px']['y']))
self._at_bottom = math.ceil(jsret['px']['y']) >= dy self._at_bottom = math.ceil(jsret['px']['y']) >= dy
if self._pos_perc != (perc_x, perc_y):
self._pos_perc = perc_x, perc_y self._pos_perc = perc_x, perc_y
self.perc_changed.emit(*self._pos_perc) self.perc_changed.emit(*self._pos_perc)
js_code = javascript.assemble('scroll', 'pos') js_code = javascript.assemble('scroll', 'pos')