From 54e5176f284de72505210513b380e62f5ebe7369 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Fri, 6 Oct 2017 10:16:41 +0200 Subject: [PATCH] Revert "Only emit perc_changed signal when the percentage actually changed" This reverts commit 1d50c2c39af217eb12de1746b28dc2a495f92741. This breaks various end2end test relying on getting log messages for scrolling. --- doc/changelog.asciidoc | 1 - qutebrowser/browser/webengine/webenginetab.py | 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/doc/changelog.asciidoc b/doc/changelog.asciidoc index a7df853ea..29bd527d3 100644 --- a/doc/changelog.asciidoc +++ b/doc/changelog.asciidoc @@ -106,7 +106,6 @@ Fixes - The "try again" button on error pages works correctly again. - :spawn -u -d is now disallowed. - :spawn -d shows error messages correctly now. -- Performance improvements for smooth scrolling v0.11.0 ------- diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py index 09df38e82..4de4bf26f 100644 --- a/qutebrowser/browser/webengine/webenginetab.py +++ b/qutebrowser/browser/webengine/webenginetab.py @@ -333,10 +333,9 @@ class WebEngineScroller(browsertab.AbstractScroller): perc_y = min(100, round(100 / dy * jsret['px']['y'])) self._at_bottom = math.ceil(jsret['px']['y']) >= dy + self._pos_perc = perc_x, perc_y - if self._pos_perc != (perc_x, perc_y): - self._pos_perc = perc_x, perc_y - self.perc_changed.emit(*self._pos_perc) + self.perc_changed.emit(*self._pos_perc) js_code = javascript.assemble('scroll', 'pos') self._tab.run_js_async(js_code, update_pos_cb)