Go back to using subprocess.Popen for :restart
With subprocess.run, we wait until the subprocess has completed, which means the
parent process will hang on :restart.
Since we *don't* want to wait for the subprocess here, using subprocess.Popen
seems the right thing to do.
This was introduced in bb54a954fe
/ #3203
Probably doesn't affect #3210 and #3220.
This commit is contained in:
parent
22f3fade24
commit
4d8ac7486c
@ -660,9 +660,9 @@ class Quitter:
|
|||||||
try:
|
try:
|
||||||
args, cwd = self._get_restart_args(pages, session, override_args)
|
args, cwd = self._get_restart_args(pages, session, override_args)
|
||||||
if cwd is None:
|
if cwd is None:
|
||||||
subprocess.run(args)
|
subprocess.Popen(args)
|
||||||
else:
|
else:
|
||||||
subprocess.run(args, cwd=cwd)
|
subprocess.Popen(args, cwd=cwd)
|
||||||
except OSError:
|
except OSError:
|
||||||
log.destroy.exception("Failed to restart")
|
log.destroy.exception("Failed to restart")
|
||||||
return False
|
return False
|
||||||
|
Loading…
Reference in New Issue
Block a user