From 4d8ac7486ccdd512b9a4f5d753be79aef418478c Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 6 Nov 2017 07:43:47 +0100 Subject: [PATCH] Go back to using subprocess.Popen for :restart With subprocess.run, we wait until the subprocess has completed, which means the parent process will hang on :restart. Since we *don't* want to wait for the subprocess here, using subprocess.Popen seems the right thing to do. This was introduced in bb54a954fe58c45d4fb8e2a25833ecc1d0f422f2 / #3203 Probably doesn't affect #3210 and #3220. --- qutebrowser/app.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qutebrowser/app.py b/qutebrowser/app.py index 02eb9bf18..2ed579f61 100644 --- a/qutebrowser/app.py +++ b/qutebrowser/app.py @@ -660,9 +660,9 @@ class Quitter: try: args, cwd = self._get_restart_args(pages, session, override_args) if cwd is None: - subprocess.run(args) + subprocess.Popen(args) else: - subprocess.run(args, cwd=cwd) + subprocess.Popen(args, cwd=cwd) except OSError: log.destroy.exception("Failed to restart") return False