rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add a webengine duplicate search test

Browse Source
This commit is contained in:
Jay Kamat 2018-02-23 18:13:10 -05:00
parent f926e7b850
commit 4602afe770
No known key found for this signature in database
GPG Key ID: 5D2E399600F4F7B5
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
qutebrowser/browser/webengine/webenginetab.py
View File

@ -185,7 +185,8 @@ class WebEngineSearch(browsertab.AbstractSearch):
result_cb=None): result_cb=None):
# When duplicate searching, don't search again (webkit behavior) # When duplicate searching, don't search again (webkit behavior)
if self.text == text and self.search_displayed: if self.text == text and self.search_displayed:
log.webview.debug("Ignoring duplicate search request") log.webview.debug("Ignoring duplicate search request"
" for {}".format(text))
return return
self.text = text self.text = text

7
tests/end2end/features/search.feature
View File

@ -52,6 +52,13 @@ Feature: Searching on a page
And I wait for "search didn't find blub" in the log And I wait for "search didn't find blub" in the log
Then the warning "Text 'blub' not found on page!" should be shown Then the warning "Text 'blub' not found on page!" should be shown
@qtwebkit_skip: Supported by default on qtwebkit
Scenario: Searching text duplicates
When I run :search foo
And I wait for "search found foo" in the log
And I run :search foo
Then "Ignoring duplicate search request for foo" should be logged
## search.ignore_case ## search.ignore_case
Scenario: Searching text with search.ignore_case = always Scenario: Searching text with search.ignore_case = always