rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Do not assume elem.selectionStart exists

Browse Source
This commit is contained in:
Luca Benci 2017-10-25 22:38:44 +02:00
parent f195b7e4d2
commit 3fd7fb3e14
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
qutebrowser/javascript/webelem.js
View File

@ -48,12 +48,20 @@ window._qutebrowser.webelem = (function() {
var id = elements.length; var id = elements.length;
elements[id] = elem; elements[id] = elem;
// InvalidStateError will be thrown if elem doesn't have selectionStart
var caret_position = 0;
try {
caret_position = elem.selectionStart;
} catch (e) {
// nothing to do, caret_position is already 0
}
var out = { var out = {
"id": id, "id": id,
"value": elem.value, "value": elem.value,
"outer_xml": elem.outerHTML, "outer_xml": elem.outerHTML,
"rects": [], // Gets filled up later "rects": [], // Gets filled up later
"caret_position": elem.selectionStart, "caret_position": caret_position,
}; };
// https://github.com/qutebrowser/qutebrowser/issues/2569 // https://github.com/qutebrowser/qutebrowser/issues/2569