From 3fd7fb3e14854306a801c9caa9bb2a89be150718 Mon Sep 17 00:00:00 2001 From: Luca Benci Date: Wed, 25 Oct 2017 22:38:44 +0200 Subject: [PATCH] Do not assume elem.selectionStart exists --- qutebrowser/javascript/webelem.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/qutebrowser/javascript/webelem.js b/qutebrowser/javascript/webelem.js index a37fcd6c8..7f17a1209 100644 --- a/qutebrowser/javascript/webelem.js +++ b/qutebrowser/javascript/webelem.js @@ -48,12 +48,20 @@ window._qutebrowser.webelem = (function() { var id = elements.length; elements[id] = elem; + // InvalidStateError will be thrown if elem doesn't have selectionStart + var caret_position = 0; + try { + caret_position = elem.selectionStart; + } catch (e) { + // nothing to do, caret_position is already 0 + } + var out = { "id": id, "value": elem.value, "outer_xml": elem.outerHTML, "rects": [], // Gets filled up later - "caret_position": elem.selectionStart, + "caret_position": caret_position, }; // https://github.com/qutebrowser/qutebrowser/issues/2569