rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix subtle issue in hint bdd tests

Browse Source 
- We need to clean open tabs to avoid reusing target=_blank child tabs
- We don't check the active tab with target=_blank anymore
- Remove some weird :tab-close
This commit is contained in:
Florian Bruhin 2017-02-17 22:07:59 +01:00
parent ac9b0e5c59
commit 399b02a367
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tests/end2end/features/hints.feature
View File

@ -1,5 +1,9 @@
Feature: Using hints Feature: Using hints
# https://bugreports.qt.io/browse/QTBUG-58381
Background:
Given I clean up open tabs
Scenario: Using :follow-hint outside of hint mode (issue 1105) Scenario: Using :follow-hint outside of hint mode (issue 1105)
When I run :follow-hint When I run :follow-hint
Then the error "follow-hint: This command is only allowed in hint mode, not normal." should be shown Then the error "follow-hint: This command is only allowed in hint mode, not normal." should be shown
@ -24,11 +28,10 @@ Feature: Using hints
And I wait until data/hello.txt is loaded And I wait until data/hello.txt is loaded
Then the following tabs should be open: Then the following tabs should be open:
- data/hints/link_blank.html - data/hints/link_blank.html
- data/hello.txt (active) - data/hello.txt
Scenario: Following a hint to link with sub-element and force to open in current tab. Scenario: Following a hint to link with sub-element and force to open in current tab.
When I open data/hints/link_span.html When I open data/hints/link_span.html
And I run :tab-close
And I hint with args "links current" and follow a And I hint with args "links current" and follow a
And I wait until data/hello.txt is loaded And I wait until data/hello.txt is loaded
Then the following tabs should be open: Then the following tabs should be open: