From 399b02a36712d5d73d9ca49c2ab2a9acd4a110d4 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Fri, 17 Feb 2017 22:07:59 +0100 Subject: [PATCH] Fix subtle issue in hint bdd tests - We need to clean open tabs to avoid reusing target=_blank child tabs - We don't check the active tab with target=_blank anymore - Remove some weird :tab-close --- tests/end2end/features/hints.feature | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/end2end/features/hints.feature b/tests/end2end/features/hints.feature index bb81bc7cb..516ca0979 100644 --- a/tests/end2end/features/hints.feature +++ b/tests/end2end/features/hints.feature @@ -1,5 +1,9 @@ Feature: Using hints + # https://bugreports.qt.io/browse/QTBUG-58381 + Background: + Given I clean up open tabs + Scenario: Using :follow-hint outside of hint mode (issue 1105) When I run :follow-hint Then the error "follow-hint: This command is only allowed in hint mode, not normal." should be shown @@ -24,11 +28,10 @@ Feature: Using hints And I wait until data/hello.txt is loaded Then the following tabs should be open: - data/hints/link_blank.html - - data/hello.txt (active) + - data/hello.txt Scenario: Following a hint to link with sub-element and force to open in current tab. When I open data/hints/link_span.html - And I run :tab-close And I hint with args "links current" and follow a And I wait until data/hello.txt is loaded Then the following tabs should be open: