rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

utils.javascript: Handle bools in _convert_js_arg

Browse Source
This commit is contained in:
Florian Bruhin 2016-08-18 12:29:05 +02:00
parent b596c4da27
commit 30029a8259
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qutebrowser/utils/javascript.py
View File

@ -52,6 +52,8 @@ def _convert_js_arg(arg):
return 'undefined' return 'undefined'
elif isinstance(arg, str): elif isinstance(arg, str):
return '"{}"'.format(string_escape(arg)) return '"{}"'.format(string_escape(arg))
elif isinstance(arg, bool):
return str(arg).lower()
elif isinstance(arg, (int, float)): elif isinstance(arg, (int, float)):
return str(arg) return str(arg)
else: else:

2
tests/unit/utils/test_javascript.py
View File

@ -127,8 +127,10 @@ class TestStringEscape:
('foo\\bar', r'"foo\\bar"'), ('foo\\bar', r'"foo\\bar"'),
(42, '42'), (42, '42'),
(23.42, '23.42'), (23.42, '23.42'),
(False, 'false'),
(None, 'undefined'), (None, 'undefined'),
(object(), TypeError), (object(), TypeError),
(True, 'true'),
]) ])
def test_convert_js_arg(arg, expected): def test_convert_js_arg(arg, expected):
if expected is TypeError: if expected is TypeError: