diff --git a/qutebrowser/utils/javascript.py b/qutebrowser/utils/javascript.py index 4eaf63cd0..4fc7e546c 100644 --- a/qutebrowser/utils/javascript.py +++ b/qutebrowser/utils/javascript.py @@ -52,6 +52,8 @@ def _convert_js_arg(arg): return 'undefined' elif isinstance(arg, str): return '"{}"'.format(string_escape(arg)) + elif isinstance(arg, bool): + return str(arg).lower() elif isinstance(arg, (int, float)): return str(arg) else: diff --git a/tests/unit/utils/test_javascript.py b/tests/unit/utils/test_javascript.py index f7ff7da53..298a75312 100644 --- a/tests/unit/utils/test_javascript.py +++ b/tests/unit/utils/test_javascript.py @@ -127,8 +127,10 @@ class TestStringEscape: ('foo\\bar', r'"foo\\bar"'), (42, '42'), (23.42, '23.42'), + (False, 'false'), (None, 'undefined'), (object(), TypeError), + (True, 'true'), ]) def test_convert_js_arg(arg, expected): if expected is TypeError: