rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add some logging for error pages

Browse Source
This commit is contained in:
Florian Bruhin 2014-06-10 15:31:22 +02:00
parent 1c63ff620d
commit 126a520674
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
qutebrowser/browser/webpage.py
View File

@ -61,13 +61,23 @@ class BrowserPage(QWebPage):
Return: Return:
False if no error page should be displayed, True otherwise. False if no error page should be displayed, True otherwise.
""" """
ignored_errors = [
(QWebPage.QtNetwork, QNetworkReply.OperationCanceledError),
]
info = sip.cast(opt, QWebPage.ErrorPageExtensionOption) info = sip.cast(opt, QWebPage.ErrorPageExtensionOption)
errpage = sip.cast(out, QWebPage.ErrorPageExtensionReturn) errpage = sip.cast(out, QWebPage.ErrorPageExtensionReturn)
errpage.baseUrl = info.url errpage.baseUrl = info.url
if (info.domain == QWebPage.QtNetwork and
info.error == QNetworkReply.OperationCanceledError):
return False
urlstr = urlutils.urlstring(info.url) urlstr = urlutils.urlstring(info.url)
if (info.domain, info.error) in ignored_errors:
log.webview.debug("Ignored error on {}: {} (error domain: {}, "
"error code: {})".format(
urlstr, info.errorString, info.domain,
info.error))
return False
log.webview.error("Error while loading {}: {}".format(
urlstr, info.errorString))
log.webview.debug("Error domain: {}, error code: {}".format(
info.domain, info.error))
title = "Error loading page: {}".format(urlstr) title = "Error loading page: {}".format(urlstr)
errpage.content = read_file('html/error.html').format( errpage.content = read_file('html/error.html').format(
title=title, url=urlstr, error=info.errorString, icon='') title=title, url=urlstr, error=info.errorString, icon='')