From 126a520674caf6831136bc37045ce268af89d8f4 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 10 Jun 2014 15:31:22 +0200 Subject: [PATCH] Add some logging for error pages --- qutebrowser/browser/webpage.py | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/qutebrowser/browser/webpage.py b/qutebrowser/browser/webpage.py index 5f3ca9a90..0e1e90cf0 100644 --- a/qutebrowser/browser/webpage.py +++ b/qutebrowser/browser/webpage.py @@ -61,13 +61,23 @@ class BrowserPage(QWebPage): Return: False if no error page should be displayed, True otherwise. """ + ignored_errors = [ + (QWebPage.QtNetwork, QNetworkReply.OperationCanceledError), + ] info = sip.cast(opt, QWebPage.ErrorPageExtensionOption) errpage = sip.cast(out, QWebPage.ErrorPageExtensionReturn) errpage.baseUrl = info.url - if (info.domain == QWebPage.QtNetwork and - info.error == QNetworkReply.OperationCanceledError): - return False urlstr = urlutils.urlstring(info.url) + if (info.domain, info.error) in ignored_errors: + log.webview.debug("Ignored error on {}: {} (error domain: {}, " + "error code: {})".format( + urlstr, info.errorString, info.domain, + info.error)) + return False + log.webview.error("Error while loading {}: {}".format( + urlstr, info.errorString)) + log.webview.debug("Error domain: {}, error code: {}".format( + info.domain, info.error)) title = "Error loading page: {}".format(urlstr) errpage.content = read_file('html/error.html').format( title=title, url=urlstr, error=info.errorString, icon='')