abff44def6
In Qt < 5.10 (and also sometimes on Windows), we get extra spaces or newlines when moving to the end of the document. However, this only happens *sometimes*, and manual testing confirms that with the current workaround, we actually lose the last char in the selection. I'm not sure what's happening there, but instead of making things worse with the workaround, let's just be a bit less strict with the checking there and accept both variants... This seems like some Chromium bug we can't do much about.
359 lines
11 KiB
Python
359 lines
11 KiB
Python
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et:
|
|
|
|
# Copyright 2018 Florian Bruhin (The Compiler) <mail@qutebrowser.org>
|
|
#
|
|
# This file is part of qutebrowser.
|
|
#
|
|
# qutebrowser is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# qutebrowser is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with qutebrowser. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
"""Tests for caret browsing mode."""
|
|
|
|
import textwrap
|
|
|
|
import pytest
|
|
from PyQt5.QtCore import QUrl
|
|
|
|
from qutebrowser.utils import usertypes
|
|
from helpers import utils
|
|
|
|
|
|
@pytest.fixture
|
|
def caret(web_tab, qtbot, mode_manager):
|
|
with qtbot.wait_signal(web_tab.load_finished):
|
|
web_tab.openurl(QUrl('qute://testdata/data/caret.html'))
|
|
|
|
mode_manager.enter(usertypes.KeyMode.caret)
|
|
|
|
return web_tab.caret
|
|
|
|
|
|
class Selection:
|
|
|
|
"""Helper to interact with the caret selection."""
|
|
|
|
def __init__(self, qtbot, caret):
|
|
self._qtbot = qtbot
|
|
self._caret = caret
|
|
self._callback_checker = utils.CallbackChecker(qtbot)
|
|
|
|
def check(self, expected, *, strip=False):
|
|
"""Check whether we got the expected selection.
|
|
|
|
Since (especially on Windows) the selection is empty if we're too
|
|
quickly, we try to read it multiple times.
|
|
"""
|
|
for _ in range(10):
|
|
with self._qtbot.wait_signal(
|
|
self._callback_checker.got_result) as blocker:
|
|
self._caret.selection(self._callback_checker.callback)
|
|
|
|
selection = blocker.args[0]
|
|
if selection:
|
|
if strip:
|
|
selection = selection.strip()
|
|
assert selection == expected
|
|
return
|
|
|
|
self._qtbot.wait(50)
|
|
|
|
def check_multiline(self, expected, *, strip=False):
|
|
self.check(textwrap.dedent(expected).strip(), strip=strip)
|
|
|
|
def toggle(self):
|
|
with self._qtbot.wait_signal(self._caret.selection_toggled):
|
|
self._caret.toggle_selection()
|
|
|
|
|
|
@pytest.fixture
|
|
def selection(qtbot, caret, callback_checker):
|
|
return Selection(qtbot, caret)
|
|
|
|
|
|
class TestDocument:
|
|
|
|
def test_selecting_entire_document(self, caret, selection):
|
|
selection.toggle()
|
|
caret.move_to_end_of_document()
|
|
selection.check_multiline("""
|
|
one two three
|
|
eins zwei drei
|
|
|
|
four five six
|
|
vier fünf sechs
|
|
""", strip=True)
|
|
|
|
def test_moving_to_end_and_start(self, caret, selection):
|
|
caret.move_to_end_of_document()
|
|
caret.move_to_start_of_document()
|
|
selection.toggle()
|
|
caret.move_to_end_of_word()
|
|
selection.check("one")
|
|
|
|
def test_moving_to_end_and_start_with_selection(self, caret, selection):
|
|
caret.move_to_end_of_document()
|
|
selection.toggle()
|
|
caret.move_to_start_of_document()
|
|
selection.check_multiline("""
|
|
one two three
|
|
eins zwei drei
|
|
|
|
four five six
|
|
vier fünf sechs
|
|
""", strip=True)
|
|
|
|
|
|
class TestBlock:
|
|
|
|
def test_selecting_block(self, caret, selection):
|
|
selection.toggle()
|
|
caret.move_to_end_of_next_block()
|
|
selection.check_multiline("""
|
|
one two three
|
|
eins zwei drei
|
|
""")
|
|
|
|
def test_moving_back_to_the_end_of_prev_block_with_sel(self, caret, selection):
|
|
caret.move_to_end_of_next_block(2)
|
|
selection.toggle()
|
|
caret.move_to_end_of_prev_block()
|
|
caret.move_to_prev_word()
|
|
selection.check_multiline("""
|
|
drei
|
|
|
|
four five six
|
|
""")
|
|
|
|
def test_moving_back_to_the_end_of_prev_block(self, caret, selection):
|
|
caret.move_to_end_of_next_block(2)
|
|
caret.move_to_end_of_prev_block()
|
|
selection.toggle()
|
|
caret.move_to_prev_word()
|
|
selection.check("drei")
|
|
|
|
def test_moving_back_to_the_start_of_prev_block_with_sel(self, caret, selection):
|
|
caret.move_to_end_of_next_block(2)
|
|
selection.toggle()
|
|
caret.move_to_start_of_prev_block()
|
|
selection.check_multiline("""
|
|
eins zwei drei
|
|
|
|
four five six
|
|
""")
|
|
|
|
def test_moving_back_to_the_start_of_prev_block(self, caret, selection):
|
|
caret.move_to_end_of_next_block(2)
|
|
caret.move_to_start_of_prev_block()
|
|
selection.toggle()
|
|
caret.move_to_next_word()
|
|
selection.check("eins ")
|
|
|
|
def test_moving_to_the_start_of_next_block_with_sel(self, caret, selection):
|
|
selection.toggle()
|
|
caret.move_to_start_of_next_block()
|
|
selection.check("one two three\n")
|
|
|
|
def test_moving_to_the_start_of_next_block(self, caret, selection):
|
|
caret.move_to_start_of_next_block()
|
|
selection.toggle()
|
|
caret.move_to_end_of_word()
|
|
selection.check("eins")
|
|
|
|
|
|
class TestLine:
|
|
|
|
def test_selecting_a_line(self, caret, selection):
|
|
selection.toggle()
|
|
caret.move_to_end_of_line()
|
|
selection.check("one two three")
|
|
|
|
def test_moving_and_selecting_a_line(self, caret, selection):
|
|
caret.move_to_next_line()
|
|
selection.toggle()
|
|
caret.move_to_end_of_line()
|
|
selection.check("eins zwei drei")
|
|
|
|
def test_selecting_next_line(self, caret, selection):
|
|
selection.toggle()
|
|
caret.move_to_next_line()
|
|
selection.check("one two three\n")
|
|
|
|
def test_moving_to_end_and_to_start_of_line(self, caret, selection):
|
|
caret.move_to_end_of_line()
|
|
caret.move_to_start_of_line()
|
|
selection.toggle()
|
|
caret.move_to_end_of_word()
|
|
selection.check("one")
|
|
|
|
def test_selecting_a_line_backwards(self, caret, selection):
|
|
caret.move_to_end_of_line()
|
|
selection.toggle()
|
|
caret.move_to_start_of_line()
|
|
selection.check("one two three")
|
|
|
|
def test_selecting_previous_line(self, caret, selection):
|
|
caret.move_to_next_line()
|
|
selection.toggle()
|
|
caret.move_to_prev_line()
|
|
selection.check("one two three\n")
|
|
|
|
def test_moving_to_previous_line(self, caret, selection):
|
|
caret.move_to_next_line()
|
|
caret.move_to_prev_line()
|
|
selection.toggle()
|
|
caret.move_to_next_line()
|
|
selection.check("one two three\n")
|
|
|
|
|
|
class TestWord:
|
|
|
|
def test_selecting_a_word(self, caret, selection):
|
|
selection.toggle()
|
|
caret.move_to_end_of_word()
|
|
selection.check("one")
|
|
|
|
def test_moving_to_end_and_selecting_a_word(self, caret, selection):
|
|
caret.move_to_end_of_word()
|
|
selection.toggle()
|
|
caret.move_to_end_of_word()
|
|
selection.check(" two")
|
|
|
|
def test_moving_to_next_word_and_selecting_a_word(self, caret, selection):
|
|
caret.move_to_next_word()
|
|
selection.toggle()
|
|
caret.move_to_end_of_word()
|
|
selection.check("two")
|
|
|
|
def test_moving_to_next_word_and_selecting_until_next_word(self, caret, selection):
|
|
caret.move_to_next_word()
|
|
selection.toggle()
|
|
caret.move_to_next_word()
|
|
selection.check("two ")
|
|
|
|
def test_moving_to_previous_word_and_selecting_a_word(self, caret, selection):
|
|
caret.move_to_end_of_word()
|
|
selection.toggle()
|
|
caret.move_to_prev_word()
|
|
selection.check("one")
|
|
|
|
def test_moving_to_previous_word(self, caret, selection):
|
|
caret.move_to_end_of_word()
|
|
caret.move_to_prev_word()
|
|
selection.toggle()
|
|
caret.move_to_end_of_word()
|
|
selection.check("one")
|
|
|
|
|
|
class TestChar:
|
|
|
|
def test_selecting_a_char(self, caret, selection):
|
|
selection.toggle()
|
|
caret.move_to_next_char()
|
|
selection.check("o")
|
|
|
|
def test_moving_and_selecting_a_char(self, caret, selection):
|
|
caret.move_to_next_char()
|
|
selection.toggle()
|
|
caret.move_to_next_char()
|
|
selection.check("n")
|
|
|
|
def test_selecting_previous_char(self, caret, selection):
|
|
caret.move_to_end_of_word()
|
|
selection.toggle()
|
|
caret.move_to_prev_char()
|
|
selection.check("e")
|
|
|
|
def test_moving_to_previous_char(self, caret, selection):
|
|
caret.move_to_end_of_word()
|
|
caret.move_to_prev_char()
|
|
selection.toggle()
|
|
caret.move_to_end_of_word()
|
|
selection.check("e")
|
|
|
|
|
|
def test_drop_selection(caret, selection):
|
|
selection.toggle()
|
|
caret.move_to_end_of_word()
|
|
caret.drop_selection()
|
|
selection.check("")
|
|
|
|
|
|
class TestSearch:
|
|
|
|
# https://bugreports.qt.io/browse/QTBUG-60673
|
|
|
|
@pytest.mark.qtbug60673
|
|
@pytest.mark.no_xvfb
|
|
def test_yanking_a_searched_line(self, caret, selection, mode_manager, callback_checker, web_tab, qtbot):
|
|
web_tab.show()
|
|
mode_manager.leave(usertypes.KeyMode.caret)
|
|
|
|
web_tab.search.search('fiv', result_cb=callback_checker.callback)
|
|
callback_checker.check(True)
|
|
|
|
mode_manager.enter(usertypes.KeyMode.caret)
|
|
caret.move_to_end_of_line()
|
|
selection.check('five six')
|
|
|
|
@pytest.mark.qtbug60673
|
|
@pytest.mark.no_xvfb
|
|
def test_yanking_a_searched_line_with_multiple_matches(self, caret, selection, mode_manager, callback_checker, web_tab, qtbot):
|
|
web_tab.show()
|
|
mode_manager.leave(usertypes.KeyMode.caret)
|
|
|
|
web_tab.search.search('w', result_cb=callback_checker.callback)
|
|
callback_checker.check(True)
|
|
|
|
web_tab.search.next_result(result_cb=callback_checker.callback)
|
|
callback_checker.check(True)
|
|
|
|
mode_manager.enter(usertypes.KeyMode.caret)
|
|
|
|
caret.move_to_end_of_line()
|
|
selection.check('wei drei')
|
|
|
|
|
|
class TestFollowSelected:
|
|
|
|
LOAD_STARTED_DELAY = 50
|
|
|
|
@pytest.fixture(params=[True, False], autouse=True)
|
|
def toggle_js(self, request, config_stub):
|
|
config_stub.val.content.javascript.enabled = request.param
|
|
|
|
def test_follow_selected_without_a_selection(self, qtbot, caret, selection, web_tab,
|
|
mode_manager):
|
|
caret.move_to_next_word() # Move cursor away from the link
|
|
mode_manager.leave(usertypes.KeyMode.caret)
|
|
with qtbot.wait_signal(caret.follow_selected_done):
|
|
with qtbot.assert_not_emitted(web_tab.load_started):
|
|
caret.follow_selected()
|
|
qtbot.wait(self.LOAD_STARTED_DELAY)
|
|
|
|
def test_follow_selected_with_text(self, qtbot, caret, selection, web_tab):
|
|
caret.move_to_next_word()
|
|
selection.toggle()
|
|
caret.move_to_end_of_word()
|
|
with qtbot.wait_signal(caret.follow_selected_done):
|
|
with qtbot.assert_not_emitted(web_tab.load_started):
|
|
caret.follow_selected()
|
|
qtbot.wait(self.LOAD_STARTED_DELAY)
|
|
|
|
def test_follow_selected_with_link(self, caret, selection, config_stub,
|
|
qtbot, web_tab):
|
|
selection.toggle()
|
|
caret.move_to_end_of_word()
|
|
with qtbot.wait_signal(web_tab.load_finished):
|
|
caret.follow_selected()
|
|
assert web_tab.url().path() == '/data/hello.txt'
|