qutebrowser/tests/unit/misc/test_sql.py
Ryan Roden-Corrent 56f3b3a027 Small review fixups for SQL implementation.
Respond to the low-hanging code review fruit:

- Clean up some comments
- Remove an acidentally added duplicate init_autosave
- Combine two test_history tests
- Move test_init cleanup into a fixture to ensure it gets called.
- Name the _ argument of bind(_) to _key
- Ensure index is valid for first_item/last_item
- Move SqlException to top of module
- Rename test_index to test_getitem
- Return QItemFlags.None instead of None
- Fix copyright dates (its 2017 now!)
- Use * to force some args to be keyword-only
- Make some returns explicit
- Add sql to LOGGER_NAMES
- Add a comment to explain the sql escape statement
2017-06-19 07:44:11 -04:00

127 lines
4.1 KiB
Python

# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et:
# Copyright 2016-2017 Ryan Roden-Corrent (rcorre) <ryan@rcorre.net>
#
# This file is part of qutebrowser.
#
# qutebrowser is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# qutebrowser is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with qutebrowser. If not, see <http://www.gnu.org/licenses/>.
"""Test the SQL API."""
import pytest
from qutebrowser.misc import sql
pytestmark = pytest.mark.usefixtures('init_sql')
def test_init():
sql.SqlTable('Foo', ['name', 'val', 'lucky'], primary_key='name')
with pytest.raises(sql.SqlException):
# table name collision on 'Foo'
sql.SqlTable('Foo', ['foo', 'bar'], primary_key='foo')
def test_insert(qtbot):
table = sql.SqlTable('Foo', ['name', 'val', 'lucky'], primary_key='name')
with qtbot.waitSignal(table.changed):
table.insert(['one', 1, False])
with qtbot.waitSignal(table.changed):
table.insert(['wan', 1, False])
with pytest.raises(sql.SqlException):
# duplicate primary key
table.insert(['one', 1, False])
def test_iter():
table = sql.SqlTable('Foo', ['name', 'val', 'lucky'], primary_key='name')
table.insert(['one', 1, False])
table.insert(['nine', 9, False])
table.insert(['thirteen', 13, True])
assert list(table) == [('one', 1, False),
('nine', 9, False),
('thirteen', 13, True)]
def test_replace(qtbot):
table = sql.SqlTable('Foo', ['name', 'val', 'lucky'], primary_key='name')
table.insert(['one', 1, False])
with qtbot.waitSignal(table.changed):
table.insert(['one', 1, True], replace=True)
assert list(table) == [('one', 1, True)]
def test_delete(qtbot):
table = sql.SqlTable('Foo', ['name', 'val', 'lucky'], primary_key='name')
table.insert(['one', 1, False])
table.insert(['nine', 9, False])
table.insert(['thirteen', 13, True])
with pytest.raises(KeyError):
table.delete('nope')
with qtbot.waitSignal(table.changed):
table.delete('thirteen')
assert list(table) == [('one', 1, False), ('nine', 9, False)]
with qtbot.waitSignal(table.changed):
table.delete(False, field='lucky')
assert not list(table)
def test_len():
table = sql.SqlTable('Foo', ['name', 'val', 'lucky'], primary_key='name')
assert len(table) == 0
table.insert(['one', 1, False])
assert len(table) == 1
table.insert(['nine', 9, False])
assert len(table) == 2
table.insert(['thirteen', 13, True])
assert len(table) == 3
def test_contains():
table = sql.SqlTable('Foo', ['name', 'val', 'lucky'], primary_key='name')
table.insert(['one', 1, False])
table.insert(['nine', 9, False])
table.insert(['thirteen', 13, True])
assert 'oone' not in table
assert 'ninee' not in table
assert 1 not in table
assert '*' not in table
assert 'one' in table
assert 'nine' in table
assert 'thirteen' in table
def test_getitem():
table = sql.SqlTable('Foo', ['name', 'val', 'lucky'], primary_key='name')
table.insert(['one', 1, False])
table.insert(['nine', 9, False])
table.insert(['thirteen', 13, True])
assert table['one'] == ('one', 1, False)
assert table['nine'] == ('nine', 9, False)
assert table['thirteen'] == ('thirteen', 13, True)
def test_delete_all(qtbot):
table = sql.SqlTable('Foo', ['name', 'val', 'lucky'], primary_key='name')
table.insert(['one', 1, False])
table.insert(['nine', 9, False])
table.insert(['thirteen', 13, True])
with qtbot.waitSignal(table.changed):
table.delete_all()
assert list(table) == []
def test_version():
assert isinstance(sql.version(), str)