888a1b8c57
Previously, a successful import of the text history into sqlite would move 'history' to 'history.bak'. If history.bak already existed, this would overwrite it on unix and fail on windows. With this patch, the most recently imported history is appended to history.bak to avoid data loss. Resolves #3005. A few other options I considered: 1. os.replace: - fast, simple, no error on Windows - potential data loss 2. numbered backups (.bak.1, .bak.2, ...): - fast, no data loss, but more complex 3. append each line to the backup as it is read: - more efficient than current patch (no need to read history twice) - potentially duplicate data if backup fails |
||
---|---|---|
.. | ||
webengine | ||
webkit | ||
test_adblock.py | ||
test_history.py | ||
test_pdfjs.py | ||
test_qutescheme.py | ||
test_shared.py | ||
test_signalfilter.py | ||
test_tab.py |