13e8ed53d6
Based on code review:
- import modules, not classes
- use methods, not lambdas for the mock command prompt class
- use None rather than Mock for DUMB_SORT
- autouse two fixtures and remove them from test signatures
135 lines
5.1 KiB
Python
135 lines
5.1 KiB
Python
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et:
|
|
|
|
# Copyright 2016 Ryan Roden-Corrent (rcorre) <ryan@rcorre.net>
|
|
#
|
|
# This file is part of qutebrowser.
|
|
#
|
|
# qutebrowser is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# qutebrowser is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with qutebrowser. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
"""Tests for the Completer Object."""
|
|
|
|
import pytest
|
|
from PyQt5.QtGui import QStandardItemModel
|
|
|
|
from qutebrowser.completion import completer
|
|
from qutebrowser.utils import usertypes
|
|
|
|
|
|
class FakeCompletionModel(QStandardItemModel):
|
|
|
|
"""Stub for a completion model."""
|
|
|
|
DUMB_SORT = None
|
|
|
|
def __init__(self, kind, parent=None):
|
|
super().__init__(parent)
|
|
self.kind = kind
|
|
|
|
|
|
@pytest.fixture
|
|
def cmd(stubs):
|
|
"""Create the statusbar command prompt the completer uses."""
|
|
return stubs.FakeStatusbarCommand()
|
|
|
|
|
|
@pytest.fixture
|
|
def completer_obj(qtbot, cmd, config_stub):
|
|
"""Create the completer used for testing."""
|
|
config_stub.data = {'completion': {'auto-open': False}}
|
|
return completer.Completer(cmd, 0)
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def instances(monkeypatch):
|
|
"""Mock the instances module so get returns a fake completion model."""
|
|
# populate a model for each completion type, with a nested structure for
|
|
# option and value completion
|
|
instances = {kind: FakeCompletionModel(kind)
|
|
for kind in usertypes.Completion}
|
|
instances[usertypes.Completion.option] = {
|
|
'general': FakeCompletionModel(usertypes.Completion.option),
|
|
}
|
|
instances[usertypes.Completion.value] = {
|
|
'general': {
|
|
'ignore-case': FakeCompletionModel(usertypes.Completion.value),
|
|
}
|
|
}
|
|
monkeypatch.setattr('qutebrowser.completion.completer.instances',
|
|
instances)
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def cmdutils_patch(monkeypatch, stubs):
|
|
"""Patch the cmdutils module to provide fake commands."""
|
|
cmds = {
|
|
'set': [usertypes.Completion.section, usertypes.Completion.option,
|
|
usertypes.Completion.value],
|
|
'help': [usertypes.Completion.helptopic],
|
|
'quickmark-load': [usertypes.Completion.quickmark_by_name],
|
|
'bookmark-load': [usertypes.Completion.bookmark_by_url],
|
|
'open': [usertypes.Completion.url],
|
|
'buffer': [usertypes.Completion.tab],
|
|
'session-load': [usertypes.Completion.sessions],
|
|
'bind': [usertypes.Completion.empty, usertypes.Completion.command],
|
|
}
|
|
cmd_utils = stubs.FakeCmdUtils({
|
|
name: stubs.FakeCommand(completion=compl)
|
|
for name, compl in cmds.items()
|
|
})
|
|
monkeypatch.setattr('qutebrowser.completion.completer.cmdutils',
|
|
cmd_utils)
|
|
|
|
|
|
@pytest.mark.parametrize('txt, expected', [
|
|
(':nope|', usertypes.Completion.command),
|
|
(':nope |', None),
|
|
(':set |', usertypes.Completion.section),
|
|
(':set gen|', usertypes.Completion.section),
|
|
(':set general |', usertypes.Completion.option),
|
|
(':set what |', None),
|
|
(':set general ignore-case |', usertypes.Completion.value),
|
|
(':set general huh |', None),
|
|
(':help |', usertypes.Completion.helptopic),
|
|
(':quickmark-load |', usertypes.Completion.quickmark_by_name),
|
|
(':bookmark-load |', usertypes.Completion.bookmark_by_url),
|
|
(':open |', usertypes.Completion.url),
|
|
(':buffer |', usertypes.Completion.tab),
|
|
(':session-load |', usertypes.Completion.sessions),
|
|
(':bind |', usertypes.Completion.empty),
|
|
(':bind <c-x> |', usertypes.Completion.command),
|
|
(':bind <c-x> foo|', usertypes.Completion.command),
|
|
(':bind <c-x>| foo', usertypes.Completion.empty),
|
|
(':set| general ', usertypes.Completion.command),
|
|
(':|set general ', usertypes.Completion.command),
|
|
(':set gene|ral ignore-case', usertypes.Completion.section),
|
|
(':|', usertypes.Completion.command),
|
|
(': |', usertypes.Completion.command),
|
|
(':bookmark-load |', usertypes.Completion.bookmark_by_url),
|
|
])
|
|
def test_update_completion(txt, expected, cmd, completer_obj,
|
|
completion_widget_stub):
|
|
"""Test setting the completion widget's model based on command text."""
|
|
# this test uses | as a placeholder for the current cursor position
|
|
cursor_pos = txt.index('|')
|
|
cmd.setText(txt.replace('|', ''))
|
|
cmd.setCursorPosition(cursor_pos)
|
|
completer_obj.update_completion()
|
|
if expected is None:
|
|
assert not completion_widget_stub.set_model.called
|
|
else:
|
|
assert completion_widget_stub.set_model.call_count == 1
|
|
arg = completion_widget_stub.set_model.call_args[0][0]
|
|
# the outer model is just for sorting; srcmodel is the completion model
|
|
assert arg.srcmodel.kind == expected
|