qutebrowser

rnhmjoj/qutebrowser

Fork 0

Commit Graph

Author	SHA1	Message	Date
Ryan Roden-Corrent	b9cf9d180b	Decouple Completer and CompletionView. Rather than having a CompletionView instantiate and register a Completer, instantiate both in MainWindow. The CompletionView is the parent of the Completer, and communicates by emitting selection_changed, meaning it no longer needs to contain a reference to the Completer.	2016-07-28 12:20:24 -04:00
Ryan Roden-Corrent	d836fcb118	Code review for completion tests. - clean up docstring typos - use _ to name an unused loop variable - parent the filter model to avoid an issue with disposal - use mocker.patch instead of monkeypatch to mock Completer creation - use is instead of == to compare by identity	2016-07-28 12:20:24 -04:00
Ryan Roden-Corrent	415ad7a638	Unit test completion view.	2016-07-28 12:20:24 -04:00

Author

SHA1

Message

Date

Ryan Roden-Corrent

b9cf9d180b

Decouple Completer and CompletionView.

Rather than having a CompletionView instantiate and register a
Completer, instantiate both in MainWindow. The CompletionView is the
parent of the Completer, and communicates by emitting
selection_changed, meaning it no longer needs to contain a reference to
the Completer.

2016-07-28 12:20:24 -04:00

Ryan Roden-Corrent

d836fcb118

Code review for completion tests.

- clean up docstring typos
- use _ to name an unused loop variable
- parent the filter model to avoid an issue with disposal
- use mocker.patch instead of monkeypatch to mock Completer creation
- use is instead of == to compare by identity

2016-07-28 12:20:24 -04:00

Ryan Roden-Corrent

415ad7a638

Unit test completion view.

2016-07-28 12:20:24 -04:00

3 Commits