Jay Kamat
cbb246fd0b
Update tests for new implementation
2018-04-16 23:28:32 -04:00
Jay Kamat
646e92707a
Call search command directly instead of using arguments
2018-04-16 23:15:56 -04:00
Florian Bruhin
14792472db
Merge remote-tracking branch 'origin/pr/3680'
2018-03-28 09:29:54 +02:00
Florian Bruhin
c7e5033eaa
Set MainWindow as parent of TabbedBrowser
...
If we close the MainWindow (and it gets deleted), we need to make sure to delete
the TabbedBrowser as well.
Fixes #3781
2018-03-28 08:58:07 +02:00
Jussi Timperi
046a3dc159
Add option to only show favicons for pinned tabs
...
Closes #3440
2018-03-28 00:45:57 +03:00
Florian Bruhin
bf4aab79ac
Merge remote-tracking branch 'origin/pr/3751'
2018-03-27 11:11:12 +02:00
Florian Bruhin
e5ffcbd49f
Merge remote-tracking branch 'origin/pr/3750'
2018-03-27 11:07:29 +02:00
rien333
fa21d280fa
Remove unnecessary hide operation
2018-03-24 05:09:03 +01:00
rien333
6db1ab0a58
Cosmetic changes
2018-03-23 15:21:02 +01:00
rien333
880b33fff5
Restore correct window visibility after decoration config change
2018-03-23 15:19:37 +01:00
rien333
2d2bdad2ca
Do not require restart after decoration option change
2018-03-22 23:26:45 +01:00
Jay Kamat
477da6002a
Fix minimum size for vertical tabs
2018-03-22 12:59:35 -04:00
Jay Kamat
d2c01d7ee6
Always display plain titles in tab tooltips
...
Closes #3741
2018-03-22 12:03:15 -04:00
rien333
a6b92dbbd3
General window decoration hiding option
2018-03-22 02:23:21 +01:00
Florian Bruhin
0ee9d73fe2
Merge remote-tracking branch 'origin/pr/3692'
2018-03-20 07:05:43 +01:00
Jay Kamat
f6c00babbe
Prevent minimumTabsizeHint from being called when booting on mac
...
Move workaround higher up to the start of tabSizeHint
2018-03-19 18:29:51 -04:00
Florian Bruhin
e50068021d
Use signals to update statusbar in caret mode
...
This means we don't use objreg anymore to get the status bar, and also makes the
bar more accurately reflect reality.
See #3583
2018-03-19 18:44:06 +01:00
Marc Jauvin
b7159d780a
Merge 'origin/master' into tab-input-mode
2018-03-16 14:28:36 -04:00
Florian Bruhin
f7074b80d0
Fix lint
2018-03-16 09:07:25 +01:00
Florian Bruhin
01845faac5
Set window title/icon on correct object
...
This was a regression introduced in #3613 .
Fixes #3727
2018-03-16 08:20:27 +01:00
Marc Jauvin
c9f6cd507b
address requested changes
...
- add INPUT_MODES & PROMPT_MODES constants in modeman
- use those in tabbedbrowser and modeman
- fix debug logs format to be more human readable
- fix associated tests for new debug logs
2018-03-13 23:31:48 -04:00
Jay Kamat
7278b7c2e5
Improve wording of documentation
2018-03-13 22:25:26 -04:00
Florian Bruhin
dcd6bcd2f4
Apply changes from PR review
2018-03-13 08:47:41 +01:00
Florian Bruhin
c590648077
Merge remote-tracking branch 'origin/pr/3613'
2018-03-13 08:39:36 +01:00
Jay Kamat
996561b50e
Apply tabs.min_width to all tabs when tabs are unshrunk
2018-03-09 14:36:01 -05:00
Johannes Wegener
cf4e472461
add basic completion to file dialog
2018-03-09 16:21:57 +01:00
Jay Kamat
1672995639
Clean up style issues
2018-03-09 02:19:49 -05:00
Jay Kamat
4a78b0519d
Add tabs.min_width setting
...
Controls min width in pixels of non pinned tabs
Closes #3690
2018-03-09 02:05:49 -05:00
Jay Kamat
46533c3367
Fix pinned tabs being too small in extreme situations
2018-03-09 02:02:31 -05:00
Marc Jauvin
7c2802e843
beautify code as requested
2018-03-07 11:46:14 -05:00
Florian Bruhin
9320214429
Only clear favicons on load with QtWebKit
...
QtWebEngine seems to automatically clear the favicon when loading e.g.
about:blank, and not clearing it there again fixes #3469 .
Original issue: #187
2018-03-05 18:29:01 +01:00
Florian Bruhin
01462008c9
Clearly separate yesno/prompt key modes
2018-02-26 22:49:15 +01:00
Florian Bruhin
d44ff5ba01
Don't load the URL immediately on :undo
...
On some pages like Qt's Gerrit, Indiegogo or Telegram Web, this caused a crash
with QtWebEngine and Qt 5.10.1 in
QtWebEngineCore::WebContentsAdapter::webContents().
I'm not sure what causes the crash exactly, but I'm guessing it's some kind of
race condition between loading the URL initially and deserializing the history,
which both ends up loading the URL.
Since restoring the history means we end up on the given URL anyways, let's just
not open the URL beforehand, which seems to fix this.
Fixes #3619 .
2018-02-25 15:55:20 +01:00
bttner
e169e2165d
Refactor TabbedBrowser from inheritance to composition
2018-02-19 14:29:05 +01:00
Marc Jauvin
872cff2ae1
make sure tab is not None either, had a crash because of this
2018-02-16 14:03:11 -05:00
Marc Jauvin
620a966d1e
add debug logs and adjust tests to use them
2018-02-14 09:58:23 -05:00
Marc Jauvin
b791dd3eb4
no restore while in prompt modes on tab change
2018-02-14 09:44:40 -05:00
Marc Jauvin
8a3049f09b
make sure there IS a current widget before using it
2018-02-14 08:33:32 -05:00
Marc Jauvin
fbb78f1133
hook into modeman's entered and left signals
...
- save previous mode when a prompt is shown
- restore previous mode when finished prompting
2018-02-12 21:57:53 -05:00
Marc Jauvin
d04fc29163
save input_mode when entering/leaving mode
...
instead of when changing tab
2018-02-12 18:10:22 -05:00
Florian Bruhin
c112290664
Make QtNetwork download manager great^H^H^H^Hlobal again
...
We originally made it per-window in b502280c06
for
issue #228 , but that was back when we still needed window IDs for stuff like
message.info.
Nowadays, there's no reason for it to be per-window anymore. The rest of the
download code can deal with one global download manager (because QtWebEngine has
one), and apart from QNAM code which wasn't used here anyways (as tab_id=None)
there was nothing using the window ID anymore.
Also see #3456 which was the original motivation for this change.
2018-02-11 16:15:29 +01:00
Florian Bruhin
d306f81130
Merge remote-tracking branch 'origin/pr/3525'
2018-02-11 10:44:27 +01:00
Jay Kamat
f6eb8929c3
Fix incorrect scroll offset after tab pin
2018-02-11 00:20:39 -05:00
Jay Kamat
33d9d4fe90
Improve performance of startup and shutdown
...
We call 'update_tab_titles' a lot of times which calls 'setTabText' on
every tab. 'setTabText' calls tabSizeHint and minTabSizeHint on every
tab as well, meaning this is an n^2 operation repeated many times.
First, this prevents setTabText from being called unless it's needed,
removing most of the work done.
Second, I remove tabs in reverse, to avoid recomputing the above for
every tab on shutdown (which is at least n^3)
2018-02-10 13:23:35 -05:00
Florian Bruhin
6d750aff8b
Merge remote-tracking branch 'origin/pr/3430'
2018-02-10 16:27:41 +01:00
715cc7b7dd
Make statusbar widgets configurable
2018-02-10 13:15:11 +01:00
Florian Bruhin
c7133a662c
Merge remote-tracking branch 'origin/pr/3577'
2018-02-10 11:40:49 +01:00
Marc Jauvin
c6ad23f921
address all mentionned issues except for file://
...
- re-encode url using QUrl.RemovePassword | QUrl.FullyEncoded
- improve readability for clipboard / primary selection code block
2018-02-10 00:38:27 -05:00
Florian Bruhin
80650d4c96
Merge remote-tracking branch 'origin/pr/3544'
2018-02-09 21:04:21 +01:00
Marc Jauvin
a3ce03e0bd
address requested changes
...
- syntax cleanup
- use attr.ib when declaring class attributes
- remove unnecessary comments
- code simplification
2018-02-09 10:39:02 -05:00
Marc Jauvin
fecb551c5e
shorten lines
2018-02-09 10:39:02 -05:00
Marc Jauvin
91b70fab70
fix pylint/flake8 errors
2018-02-09 10:39:02 -05:00
Marc Jauvin
21fc848839
document code a bit more
2018-02-09 10:39:02 -05:00
Marc Jauvin
9e524e4be8
use tabs.mode_on_change to persist or restore mode
2018-02-09 10:39:02 -05:00
Florian Bruhin
b6f311f4b2
Remove workaround for old pylint issue
2018-02-08 09:52:14 +01:00
Florian Bruhin
3306247ae5
Merge branch 'editor-watch'
2018-02-07 22:31:49 +01:00
Florian Bruhin
6f028e9ad0
Update copyright years
2018-02-05 12:19:50 +01:00
lufte
d8510e61aa
Use the instance attribute instead of querying the registry
2018-01-30 19:26:45 -03:00
Florian Bruhin
400e1bc7d7
Show tab titles as tooltip
...
Closes #3535
2018-01-30 07:11:48 +01:00
Ryan Roden-Corrent
a940de3717
Rename editing_finished to file_updated.
...
ExternalEditor now fires an event on save rather than on exit, so the
signal name should be updated to match the behavior.
2018-01-27 15:03:18 -05:00
Marc Jauvin
fe4dd579f9
add --sel option to prompt-yank
2018-01-26 22:06:05 -05:00
Marc Jauvin
520b473350
modify Question.yank_text to Question.url
...
error out when question.url is None
add url to yesno prompts
add default binding in prompt mode (ctrl-y)
2018-01-25 17:48:45 -05:00
Marc Jauvin
3b1fb92b11
remove extra line to satisfy flake8
2018-01-24 19:13:28 -05:00
Marc Jauvin
d77c9ae009
Add prompt-yank command
...
add yank_text property to utils.usertypes.Question class
Resolves #2591
2018-01-24 18:53:06 -05:00
Florian Bruhin
b3ebcfd394
Merge remote-tracking branch 'origin/pr/3482'
2018-01-17 15:53:47 +01:00
Florian Bruhin
923785c781
Merge remote-tracking branch 'origin/pr/3467'
2018-01-17 14:41:45 +01:00
Christian Helbling
141d020ede
import debug is not needed anymore
2018-01-13 10:47:58 +01:00
Christian Helbling
559059d244
simplify code - state_before_fullscreen seems not to be needed anymore
2018-01-12 11:21:55 +01:00
Christian Helbling
699abef159
fix regression of #2778 which reappeared with qt 5.10 in combination with up-to-date KDE
...
this should also avoid an unneccessary KDE maximize animation when exiting fullscreen into maximized
2018-01-12 10:54:05 +01:00
Argn0
d9741d56c5
removed a trailing whitespace
2018-01-11 16:38:55 +01:00
Argn0
57e8b428c3
e.accept() and return
2018-01-11 15:45:44 +01:00
Argn0
200b36bd36
review 1
2018-01-11 14:09:08 +01:00
Argn0
2d7dd391a3
review 1
2018-01-11 14:08:17 +01:00
Argn0
66d0591684
new method
2018-01-11 14:03:43 +01:00
Argn0
4932323d3b
review 1 setText
2018-01-11 12:40:20 +01:00
Argn0
860b22c0e0
review 1
2018-01-10 22:05:14 +01:00
Argn0
1db4309eec
review 1
2018-01-10 21:29:31 +01:00
Argn0
be5b8e2632
option to close commandline by deleting the prefix
2018-01-10 20:02:39 +01:00
Argn0
5003432a55
option to close commandline by deleting the prefix
2018-01-10 19:59:34 +01:00
Jay Kamat
3d508be9ff
Clear unpinned tabs before prompting user with :tab-only
2018-01-04 18:34:40 -08:00
RyanJenkins
53575aaeed
Default raise_windows() alert param to True to preserve existing
...
behavior
2017-12-27 12:40:55 -08:00
RyanJenkins
9cb25e0c76
Raise browser window after editor closes regardless of outcome of
...
inserting text and avoid calling QApplication.instance().alert() in this
scenario.
2017-12-26 20:19:39 -08:00
Florian Bruhin
26a622c46d
Disable wrong inconsistent-return-statements
2017-12-15 16:33:47 +01:00
Florian Bruhin
f4ed31b295
Add an utils.Unreachable exception
2017-12-15 16:33:47 +01:00
Florian Bruhin
016fc0ebb1
Fix some inconsistent returns
2017-12-15 16:33:47 +01:00
Florian Bruhin
3f9ded3bed
Add missing docstrings
2017-12-15 13:55:06 +01:00
Ryan Roden-Corrent
12112e0fc7
Implement command-accept --rapid.
...
command-accept --rapid will run the command without clearing the prompt,
allowing "rapid fire" commands. For example, one could open completion
for `open -t` and open several tabs in a row.
The default binding is ctrl+enter.
Resolves #588 .
2017-12-13 16:30:42 -05:00
Justin Partain
8f5394934f
Fix bad merge when rebasing incremental_search feature
2017-12-12 11:32:52 -05:00
Justin Partain
aff6510e35
Refactor _incremental_search() based on PR review
2017-12-12 11:31:28 -05:00
Justin Partain
9f511fe18c
pylint fix, change if len(text) to if text
2017-12-12 11:31:28 -05:00
Justin Partain
4eebd2a85d
Create config.search.* group with ignore_case and incremental
2017-12-12 11:31:28 -05:00
Justin Partain
bb2fcddcd4
Update incremental_search PR with changes from review
2017-12-12 11:31:28 -05:00
Justin Partain
c1094b6660
Feature - incremental_search
...
Added config option to find on a page incrementally, renewing the search
each time a new character is entered.
2017-12-12 11:31:28 -05:00
unknown
25526f00bf
fixed catch error in tabwidget
2017-12-07 15:47:03 -07:00
evanlee123
20ac618752
Simplified code in get_tab_fields
...
changed self.tab_url(idx) to url in get_tab_fields()
2017-12-07 02:04:02 -07:00
evanlee123
02b24e8dfb
Update tabwidget.py
2017-12-06 21:35:09 -07:00
unknown
94809032a4
field[protocol] gives the right protocol]
2017-12-06 13:24:27 -07:00
unknown
30b25da273
Added protocol key to field
2017-12-06 13:09:44 -07:00
Florian Bruhin
a137a29cce
Style improvements
...
This adds a blank line and makes Completer arguments keyword-only to make their
meaning more clear.
2017-12-03 22:32:17 +01:00
Ryan Roden-Corrent
b610563e7f
Don't show current window for :tab-give/:tab-take.
...
Resolves #3144 .
2017-12-03 08:03:54 -05:00