Florian Bruhin
12f44d0a5e
tox: Update astroid to 1.4.2 and pylint to 1.5.2.
2015-12-21 09:17:26 +01:00
Florian Bruhin
8fdbd94d71
userscripts: Remove on_proc_error.
...
When there was an error, the finished signal will be emitted too anyways, so if
we call cleanup here, we'll call it twice which means we'll get an exception.
Supersedes #1175 .
2015-12-21 08:45:46 +01:00
Florian Bruhin
59c8e5c3d1
Add some tests for commands.userscripts.
2015-12-21 08:45:46 +01:00
Florian Bruhin
b8727d338f
Fix DummyUserscriptRunner.
2015-12-20 20:04:00 +01:00
Daniel Schadt
6d02ef68ec
Add BDD tests for pdfjs integration
2015-12-20 20:00:56 +01:00
Daniel Schadt
4fdf318fda
pdfjs: Use "info" verbosity for pdf.js logging
2015-12-20 19:24:41 +01:00
Daniel Schadt
1279e418ee
pdfjs: Replace inline-removal with own function
...
Easier to unit-test and easier to understand for other programmers.
2015-12-20 19:24:41 +01:00
Daniel Schadt
c0b3160676
qutescheme: guess mimetype instead of 'text/html'
...
Since we're now using qute:// to serve files other than html
(see: pdfjs), it's a good idea to change the mimetype accordingly. This
also prevents warnings in the console, as QWebKit will complain e.g.
when stylesheets are served with 'text/html'.
2015-12-20 19:24:41 +01:00
Daniel Schadt
3a13e46c25
disable pdfjs by default
2015-12-20 19:24:41 +01:00
Daniel Schadt
cab1d3c666
fully encode URL before passing it to pdfjs
2015-12-20 19:24:41 +01:00
Daniel Schadt
2f34bdf9b9
Add link to pylint bug
2015-12-20 19:24:41 +01:00
Daniel Schadt
8e4ca1fc23
pdfjs: use PDFView.open instead of PDFView.load
...
Now we get a nice loading bar at the top of the page.
2015-12-20 19:24:41 +01:00
Daniel Schadt
d7d577b1fa
Fix pep8/pylint
2015-12-20 19:24:41 +01:00
Daniel Schadt
1c13a3cd68
pdfjs: search in ~/.local/share/qutebrowser
2015-12-20 19:24:41 +01:00
Daniel Schadt
623b6fba7e
pdfjs: open system file in binary read
2015-12-20 19:24:41 +01:00
Daniel Schadt
b243acf172
Add a nice error page when pdfjs is not found
2015-12-20 19:24:41 +01:00
Daniel Schadt
9eb72bf08a
pdfjs: use system-wide installation if available
2015-12-20 19:24:41 +01:00
Daniel Schadt
ef85d1af4c
Move pdfjs and use original files
...
* No modified pdfjs installation needed
-> Groundwork for using a system-wide installation
* Script update_3rdparty.py to download and upack the latest pdfjs
release
2015-12-20 19:24:41 +01:00
Daniel Schadt
60b9d7e6c3
Fix lints
2015-12-20 19:24:41 +01:00
Daniel Schadt
0811418746
pdfjs: don't embed data in html
...
We don't need more than one copy of the pdf.
2015-12-20 19:24:41 +01:00
Daniel Schadt
e6548dd9e7
reorder pdfjs generation code
2015-12-20 19:24:41 +01:00
Daniel Schadt
3dfaab6194
pdfjs: actually wait until the file is loaded
...
Otherwise we get incomplete replies and thus no pdf to view.
2015-12-20 19:24:41 +01:00
Daniel Schadt
8b141037ef
Add setting value to enable/disable pdf.js
2015-12-20 19:24:41 +01:00
Daniel Schadt
fcfc09f541
Revoke "LocalContentCanAccess*Urls"
...
Since we embed the content of the PDF directly, we no longer need the
permissions for pdf.js.
2015-12-20 19:24:41 +01:00
Daniel Schadt
ea4d9e884e
pdfjs: Remove debug output file
2015-12-20 19:24:41 +01:00
Daniel Schadt
5e0090d5b8
pdfjs: Use abosolute URLs
...
That allows us to use the "original" page URL when displaying with
pdf.js, which means yanking the URL etc works as intended.
2015-12-20 19:24:41 +01:00
Daniel Schadt
0ee13392e1
Basic pdfjs support
...
Working, but not very well.
Todo:
- remove pdf_file.html debug file
- set URL correctly
2015-12-20 19:24:41 +01:00
Florian Bruhin
fcf94fd527
Remove various deprecated commands/arguments.
2015-12-20 18:38:29 +01:00
Florian Bruhin
ffc76b2a5c
Fix spelling.
2015-12-20 17:39:36 +01:00
Florian Bruhin
6b89eb43a2
Allow any non-space char in search engine names.
...
Closes #1189 .
2015-12-20 17:22:54 +01:00
Florian Bruhin
5c769d8000
Report stdout/stderr of failed subprocesses.
2015-12-18 21:23:33 +01:00
Florian Bruhin
f787f004af
Fix _BaseUserscriptRunner when env is None.
2015-12-18 20:23:39 +01:00
Florian Bruhin
430b133c41
userscripts: Add docs for _QtFIFOReader attributes.
2015-12-13 13:11:06 +01:00
Florian Bruhin
494d48aac1
userscripts: Make fifo private in _QtFIFOReader.
2015-12-12 00:33:50 +01:00
Florian Bruhin
3a2d031479
userscripts: Move closing of fifo to _QtFIFOReader.
2015-12-12 00:33:25 +01:00
Florian Bruhin
24607fda8b
Mark tabs -> auto-hide as removed as well.
...
tabs -> hide-auto was removed in d8017a04a8
because it was easier to do so compared to transforming it correctly when tabs
-> show was introduced. However, tabs -> auto-hide (the even older version)
wasn't removed, breaking config migration from earlier versions.
Fixes #1171 .
2015-12-11 08:50:26 +01:00
Florian Bruhin
10dd1b50b9
Split ConfigManager.read from constructor.
2015-12-11 08:50:26 +01:00
dylan araps
1bc8d10ac7
Added config option to change tab title alignment
2015-12-07 19:43:43 +11:00
Florian Bruhin
c319b524bf
Merge branch 'master' of https://github.com/jcorentin/qutebrowser into jcorentin-master
2015-12-04 18:32:46 +01:00
Corentin Jule
d8d873f044
Fix typo for Pep257
2015-12-04 00:28:58 +01:00
Daniel Schadt
5acc982b44
Clean up mhtml doc and use email.message.Message
...
MIMEMultipart is not needed for the attachements, a simple Message is
enough.
Also fix the README markup and the _start_download docstring.
2015-12-03 22:51:46 +01:00
Corentin Jule
1941af8add
Fix TypeError on ConfigManager.remove_option
2015-12-03 20:48:50 +01:00
Florian Bruhin
7df01440a3
pylint: Remove unsubscriptable-object workaround.
...
https://bitbucket.org/logilab/pylint/issues/685/ was fixed in pylint 1.5.1.
2015-12-02 17:55:46 +01:00
Florian Bruhin
d418f7f9fa
Merge branch 'caret_mode_windows_osx' of https://github.com/artur-shaik/qutebrowser into artur-shaik-caret_mode_windows_osx
2015-12-02 06:22:27 +01:00
Florian Bruhin
eeadeb400c
Style fix.
2015-12-02 06:20:41 +01:00
Panagiotis Ktistakis
de3460da3e
Wrap tabs on :tab-move +/- if tabs->wrap is true.
2015-12-02 03:17:54 +02:00
Florian Bruhin
eff0e4c7cc
pylint: Enable useless-suppression globally.
...
We deactivate it locally where needed, i.e. where we are sure it's some
platform-specific thing.
2015-12-01 23:01:09 +01:00
Florian Bruhin
ad72b26b1a
Add comment why abstract-method is ignored.
2015-12-01 22:16:23 +01:00
Florian Bruhin
150a83d8f4
pylint: Remove unneeded supressions.
2015-12-01 22:03:58 +01:00
Florian Bruhin
a156d51844
Don't use for-else when returning.
2015-12-01 21:56:38 +01:00
Florian Bruhin
31265b80b6
pylint: Add WORKAROUND to some comments.
2015-12-01 21:56:38 +01:00
Artur Shaik
c9d47ae92a
More win32
workarounds
2015-12-01 16:53:07 +06:00
Artur Shaik
25545617a0
Try workaround for win32
platform.
2015-12-01 16:19:13 +06:00
Artur Shaik
3a5ce22eac
Remove unnecessary actions in block jumps.
2015-12-01 13:17:28 +06:00
Florian Bruhin
8be04e4f6c
pylint: Disable non-callable in SslError.
...
This wasn't hashable (and thus __hash__ wasn't callable) with Qt < 5.4.
2015-12-01 07:50:08 +01:00
Florian Bruhin
6f9b02741a
Switch from map() to list comprehensions.
2015-12-01 07:16:32 +01:00
Artur Shaik
d00f999dcf
move_to_end_of_prev_block
without unnecessary command.
2015-11-30 22:27:24 +06:00
Florian Bruhin
5f13fd2ece
Merge branch 'log-javascript-console' of https://github.com/flv0/qutebrowser into flv0-log-javascript-console
2015-11-30 08:08:31 +01:00
Florian Bruhin
f93785a0be
Merge branch 'conf-remove-special' of https://github.com/flv0/qutebrowser into flv0-conf-remove-special
2015-11-30 07:42:04 +01:00
Florian Bruhin
6e392f0f09
Add workarounds for pylint/astroid update.
2015-11-30 07:16:12 +01:00
Florian Bruhin
27d0c004e2
Don't reuse variable in compact_text.
2015-11-30 07:10:39 +01:00
Florian Bruhin
288bf1524e
Fix some unidiomatic comparisons.
2015-11-30 07:10:21 +01:00
Florian Bruhin
e227712e21
Don't reuse DocstringParser attribute.
2015-11-30 07:09:40 +01:00
Florian Bruhin
7e6be517e3
Simplify indicator_width code.
2015-11-30 07:09:02 +01:00
Florian Bruhin
307fe6b109
Avoid shadowing 'model'.
2015-11-30 07:03:49 +01:00
Florian Bruhin
a4f47150b4
Simplify unneeded if.
2015-11-30 07:00:51 +01:00
Patric Schmitz
a8b808819a
update log-javascript-console option documentation
2015-11-29 19:24:09 +01:00
Patric Schmitz
b9aa40ea74
remove config types special variable
2015-11-29 18:53:37 +01:00
Patric Schmitz
98a454a428
log-javascript-console -> [none, debug, info]
2015-11-29 18:37:11 +01:00
Florian Bruhin
736fd7d45e
Use os.path.join for bookmarks/urls path.
...
This should fix the tests on Windows which failed because they matched against
a message containing \.
2015-11-29 00:59:18 +01:00
Florian Bruhin
6a46aea934
Fix tests for basedir logging.
...
f5febc4
broke various tests which called standarddir.init() without a valid
basedir.
2015-11-29 00:35:18 +01:00
Florian Bruhin
f5febc4807
Log basedir and save it in QuteProcess for tests.
2015-11-28 23:35:32 +01:00
Florian Bruhin
e26c499bd6
lineparser: Log after saving is done.
...
This will make end to end tests easier as we can easily wait until saving is
done.
2015-11-28 23:35:04 +01:00
Florian Bruhin
c236e70920
Merge branch 'log-javascript-console' of https://github.com/flv0/qutebrowser into flv0-log-javascript-console
2015-11-28 21:12:25 +01:00
Florian Bruhin
8cf6ace0e7
Ignore deleted windows when saving session.
...
This hopefully helps with a crash on Windows which happens from time to time
during some multi-window tabs.feature tests:
Traceback (most recent call last):
File "...\mainwindow\mainwindow.py", line 446, in closeEvent
self._do_close()
File "...\mainwindow\mainwindow.py", line 405, in _do_close
objreg.get('session-manager').save_last_window_session()
File "...\misc\sessions.py", line 247, in save_last_window_session
self._last_window_session = self._save_all()
File "...\misc\sessions.py", line 183, in _save_all
win_data['geometry'] = bytes(main_window.saveGeometry())
RuntimeError: wrapped C/C++ object of type MainWindow has been deleted
2015-11-28 20:30:41 +01:00
Patric Schmitz
03ba38578e
set valid_values after __init__ consistently, move type validation out of class into pytest
2015-11-28 18:29:51 +01:00
Patric Schmitz
fdde05569c
remove redundant __init__ and rely on base class
2015-11-28 18:29:51 +01:00
Patric Schmitz
c322130dc0
style changes
2015-11-28 18:29:51 +01:00
Patric Schmitz
6f65397dfe
always set valid_values in __init__ instead of class scope variable
2015-11-28 18:29:51 +01:00
Patric Schmitz
9b453aaad5
revert config transformation
2015-11-28 18:29:51 +01:00
Patric Schmitz
9aaf5c18c1
set valid_values in __init__ methods, except for BaseType s.t. variable is shared across derived class scopes
2015-11-28 18:29:51 +01:00
Patric Schmitz
55edd9cda7
add valid_values = None to config basetype
2015-11-28 18:29:51 +01:00
Patric Schmitz
2867df4c21
revert log-javascript-console changes
2015-11-28 18:29:51 +01:00
Patric Schmitz
6431542eba
fixes to config types, remove unneeded derived __init__ and call base __init__
2015-11-28 18:29:51 +01:00
Patric Schmitz
2a705e2eb6
Make non-specialized config types String. Closes #1103
2015-11-28 18:29:51 +01:00
Patric Schmitz
75f9f2af8d
get rid of redundant option description
2015-11-28 18:29:51 +01:00
Patric Schmitz
ff6d3e05a6
log-javascript-console now String option: none, debug, info
...
Make BaseType.valid_values per-instance variable
2015-11-28 18:29:51 +01:00
Florian Bruhin
b79049261e
Delay :yank notification until message was yanked.
...
This should make yankpaste tests more reliable.
2015-11-27 18:32:17 +01:00
Florian Bruhin
23068e9679
Don't log yanked test with :yank-selected.
...
It makes our tests fail (invalid log line) and is probably not needed.
2015-11-26 21:23:11 +01:00
Florian Bruhin
8e7a76280b
Use cmdutils.check_exclusive for :tab-clone.
2015-11-26 20:11:53 +01:00
Florian Bruhin
7f5e07d7cc
bdd: Add some tests for :tab-move.
2015-11-26 18:37:47 +01:00
Florian Bruhin
f56e7b1220
Simplify :tab-move code.
2015-11-26 17:44:34 +01:00
Florian Bruhin
987ee59f58
:tab-move: Fix tab index shown in error message.
2015-11-26 16:37:54 +01:00
Florian Bruhin
5a95cfdc7a
Change CommandError to ValueError for :tab-move.
...
This should never happen.
2015-11-26 16:37:29 +01:00
Daniel Schadt
d082c248a8
Disallow empty values in url-incdec-segments
2015-11-25 19:35:37 +01:00
Florian Bruhin
951c2e8eb6
Fix qflags_key comparison.
2015-11-25 18:54:03 +01:00
Florian Bruhin
a6045ab551
Handle invalid select-on-remove case.
2015-11-25 18:47:36 +01:00
Florian Bruhin
73e9fd1118
Handle BOM (\ufeff) for webelem.javascript_escape.
2015-11-25 18:14:52 +01:00
Florian Bruhin
24a71e5c2e
Fix webelem.javascript_escape with U+2028/U+2029.
2015-11-25 10:32:22 +01:00
Florian Bruhin
027a10c04b
bdd: Add some tests for :navigate.
2015-11-24 21:32:45 +01:00