Commit Graph

1758 Commits

Author SHA1 Message Date
Florian Bruhin
01485a2f9e Always display statusbar red on errors, even in insert mode 2014-07-02 23:08:29 +02:00
Florian Bruhin
b22ebb7778 Escape & in tab titles properly 2014-07-02 23:05:42 +02:00
Florian Bruhin
c18027f3ae Override QWebPage::acceptNavigationRequest.
We now do this instead of using linkDelegationPolicy and the linkClicked signal
of QWebView, as we are unable to get the target frame with linkClicked, causing
frames to open full-page instead of where they should.

See https://bugs.webkit.org/show_bug.cgi?id=37847
2014-07-02 22:17:36 +02:00
Florian Bruhin
4aab32cc5d Move asking of questions away from Prompt widget 2014-07-02 07:07:03 +02:00
Florian Bruhin
a466b672b3 Prompt comment cleanup 2014-07-02 06:52:30 +02:00
Florian Bruhin
5c84616ff4 Rename visible to _busy and make it private. 2014-07-02 06:42:23 +02:00
Florian Bruhin
3f85f63546 Remove unneeded hide_prompt. 2014-07-02 06:42:11 +02:00
Florian Bruhin
708d0a2885 Fix lint 2014-07-02 06:35:00 +02:00
Florian Bruhin
6d2dfc5758 Clear message properly in on_mode_left. 2014-07-02 06:34:59 +02:00
Florian Bruhin
8945befcb6 Prompt queue bugfixes. 2014-07-02 06:34:59 +02:00
Florian Bruhin
e5e4790e30 Add question prompt 2014-07-02 06:34:59 +02:00
Florian Bruhin
1b9bcbf56f Save old question correctly 2014-07-02 06:34:59 +02:00
Florian Bruhin
4cdf4fc45f Start fixing foo 2014-07-02 06:34:59 +02:00
Florian Bruhin
0d037c74d4 Fix lint 2014-07-01 07:57:19 +02:00
Florian Bruhin
29064850c7 Begin using unittest.mock.patch 2014-06-30 20:35:43 +02:00
Florian Bruhin
66f0ef8009 Adjust test_basekeyparser for the named Timer. 2014-06-29 22:15:01 +02:00
Florian Bruhin
dd125cd0be Mock out logging instead of disabling in test_basekeyparser. 2014-06-29 22:14:46 +02:00
Florian Bruhin
8d237229f5 Add __init__.py in test/keyinput 2014-06-29 21:17:38 +02:00
Florian Bruhin
400f619903 Handle user variables in path correctly 2014-06-28 01:15:31 +02:00
Florian Bruhin
1a73a90515 Fix downloading with relative filepaths 2014-06-27 18:30:20 +02:00
Florian Bruhin
07e799acff Disable messagehandler workaround on recent enough PyQt versions 2014-06-27 16:57:39 +02:00
Florian Bruhin
c6ad5622b4 Clean up earlyinit 2014-06-27 12:25:27 +02:00
Florian Bruhin
b79cdbc416 Clean up Question objects correctly 2014-06-27 07:56:16 +02:00
Florian Bruhin
cb6550debb Set WA_DeleteOnClose in report dialogs 2014-06-27 07:39:01 +02:00
Florian Bruhin
2aa756d96a Increase HTML log font size 2014-06-26 14:11:27 +02:00
Florian Bruhin
e95ef9ab4a Don't log scrolling 2014-06-26 14:10:53 +02:00
Florian Bruhin
46d621629f Fix download/question crashes 2014-06-26 13:36:00 +02:00
Florian Bruhin
ca3df5e169 Highlight and select text when searching 2014-06-26 11:10:31 +02:00
Florian Bruhin
d9f4d88b88 Revert "Fix lint"
This reverts commit 6d0db2af00.

For some reason this doesn't fix the warning at all...
2014-06-26 10:57:45 +02:00
Florian Bruhin
4ade32777d Revert "Add search-highlight-all option"
There's a better solution: Calling the function twice, once with highlight,
once with mark.

This reverts commit 8812672d7d.
2014-06-26 10:57:12 +02:00
Florian Bruhin
6d0db2af00 Fix lint 2014-06-26 10:09:56 +02:00
Florian Bruhin
8812672d7d Add search-highlight-all option 2014-06-26 10:08:26 +02:00
Florian Bruhin
eeef9aa930 Fix inverted ignore-case setting. 2014-06-26 10:04:08 +02:00
Florian Bruhin
92ff957543 Clean up message API 2014-06-26 07:58:00 +02:00
Florian Bruhin
15ca1b7f59 Add __repr__ to CrashDialog 2014-06-25 23:03:33 +02:00
Florian Bruhin
a083fe69db Add a :report command 2014-06-25 22:22:30 +02:00
Florian Bruhin
b8556bab00 Fix closing </b> 2014-06-25 22:07:22 +02:00
Florian Bruhin
7073d14cb8 Handle absolute paths for downloads better 2014-06-25 22:06:16 +02:00
Florian Bruhin
37ccac39d6 Fix lint 2014-06-25 21:23:22 +02:00
Florian Bruhin
09641d96f3 Fix HTML log output 2014-06-25 21:11:03 +02:00
Florian Bruhin
fcc0d8e911 Better workaround for hang-with-warnings bug 2014-06-25 20:18:00 +02:00
Florian Bruhin
a03d209cb0 Fix missing import 2014-06-25 18:38:41 +02:00
Florian Bruhin
2f3b1faeb9 Add workaround for freeze on mouser.com 2014-06-25 17:59:24 +02:00
Florian Bruhin
9238135867 Fix crashes after completion refactoring 2014-06-25 16:48:28 +02:00
Florian Bruhin
5c143da40b Don't update completion twice 2014-06-25 15:52:51 +02:00
Florian Bruhin
b72306ffe6 Reduce logging for completions 2014-06-25 15:52:40 +02:00
Florian Bruhin
36d032c330 Don't resize completion while typing when unnecessary 2014-06-25 15:31:00 +02:00
Florian Bruhin
158301d3df Reduce logging from modemanager 2014-06-25 15:26:59 +02:00
Florian Bruhin
3c82724d10 Don't die on invalid quickmarks 2014-06-25 11:03:26 +02:00
Florian Bruhin
46a3e2af92 Queue messages to the end of the eventloop.
When not doing this, error messages sent before the signals get connected (i.e.
during init) get lost.
2014-06-25 11:02:34 +02:00
Florian Bruhin
ab99669b4a Remove unused import 2014-06-25 10:03:13 +02:00
Florian Bruhin
c8cc92e8c2 Add basic HTML log 2014-06-25 10:00:27 +02:00
Florian Bruhin
411d57e539 Fix download-page 2014-06-25 10:00:09 +02:00
Florian Bruhin
efd34455b5 Shutdown tabs before removing 2014-06-25 07:45:01 +02:00
Florian Bruhin
daee57b37d Saner default values for some QWebSettings 2014-06-25 06:54:34 +02:00
Florian Bruhin
9b4cc6ab76 Nicer downloads when size is unknown 2014-06-24 17:57:52 +02:00
Florian Bruhin
c7f2b45cbd Always yank to clipboard if primary selection is unavailable 2014-06-24 12:04:36 +02:00
Florian Bruhin
24dbfc30cb Fix jumping of tabs when selected 2014-06-24 11:03:44 +02:00
Florian Bruhin
f849710df4 Strip URL for URL recognition 2014-06-24 08:40:53 +02:00
Florian Bruhin
af14e8bf94 Keep GPL closer to the original 2014-06-24 07:58:48 +02:00
Florian Bruhin
a114b46b81 Get colorama version correctly 2014-06-24 07:56:17 +02:00
Florian Bruhin
be75f45312 Add info if executable is frozen to version output 2014-06-24 07:46:01 +02:00
Florian Bruhin
4b95f369a4 Get rid of ipdb/IPython.
This caused more problems than it's worth really, and it does some black magic
I'm not comfortable with.
2014-06-24 07:42:49 +02:00
Florian Bruhin
3ce9945bc9 Merge branch 'restart' 2014-06-24 07:11:05 +02:00
Florian Bruhin
f1c0153409 Don't die when getting signals for invalid tabs 2014-06-24 07:01:15 +02:00
Florian Bruhin
f3f04b6f21 Make restart work when frozen 2014-06-24 06:52:49 +02:00
Florian Bruhin
65353773d1 First fix for :restart 2014-06-24 06:43:52 +02:00
Florian Bruhin
43bcb2a746 Remove mouse focus indicator on Windows in completion view 2014-06-23 21:02:55 +02:00
Florian Bruhin
b1f9139fd7 Fix lint 2014-06-23 20:33:41 +02:00
Florian Bruhin
ba9b846a20 Lower-case HTML attributes. 2014-06-23 20:32:40 +02:00
Florian Bruhin
9afab112aa Move select tag to non-configurable is_editable types. 2014-06-23 20:32:07 +02:00
Florian Bruhin
31e0cde35b Add tests for is_editable. 2014-06-23 20:31:47 +02:00
Florian Bruhin
2065f17cb5 Clean up tests 2014-06-23 19:44:21 +02:00
Florian Bruhin
fa95c24d7d Accept events properly 2014-06-23 18:21:12 +02:00
Florian Bruhin
81990f792f Avoid using QApplication for downloads 2014-06-23 17:30:28 +02:00
Florian Bruhin
da0bfb4861 Set window title based on page 2014-06-23 17:18:36 +02:00
Florian Bruhin
277bac618a Color statusbar in insert mode 2014-06-23 16:43:59 +02:00
Florian Bruhin
359e4bab6f Fix value models when config changed. 2014-06-23 16:43:04 +02:00
Florian Bruhin
b6ddda8f17 Show git timestamp in version 2014-06-23 16:19:43 +02:00
Florian Bruhin
98a2e80b38 Fix quickmarks 2014-06-23 16:12:35 +02:00
Florian Bruhin
70f224ba32 Make tab close on right click configurable 2014-06-23 15:47:31 +02:00
Florian Bruhin
914f7ace81 Fix Content-Disposition tests on Linux 2014-06-23 14:54:12 +02:00
Florian Bruhin
e5e49ed858 Split _is_object_editable from is_editable. 2014-06-23 14:48:18 +02:00
Florian Bruhin
c71e9e4c83 Add missing config import. 2014-06-23 14:48:07 +02:00
Florian Bruhin
dc91bcdf91 Don't crash if URLs are invalid in commands 2014-06-23 14:26:47 +02:00
Florian Bruhin
e5e466f6d1 Don't restore keyboard focus when hinting 2014-06-23 14:26:44 +02:00
Florian Bruhin
cf17af147e Fix and clean up insertmode checks 2014-06-23 14:26:34 +02:00
Florian Bruhin
fdb4b24148 Remove excess newlines 2014-06-23 12:28:55 +02:00
Florian Bruhin
f12d243f03 Clean up import 2014-06-23 12:17:13 +02:00
Florian Bruhin
19688f5055 Add tests for parse_content_disposition 2014-06-23 12:16:01 +02:00
Florian Bruhin
e4b10af41a Move filename checking to utils.misc 2014-06-23 12:15:10 +02:00
Florian Bruhin
752422c351 Add missing returns after calling superclass events.
We fscked that up in 9668994046.
2014-06-23 10:18:27 +02:00
Florian Bruhin
6774445497 Fix lint 2014-06-23 08:26:35 +02:00
Florian Bruhin
be68f98ce7 Don't crash on invalid icon rect 2014-06-23 08:20:40 +02:00
Florian Bruhin
0a205071be Add username to contact info 2014-06-23 08:16:00 +02:00
Florian Bruhin
593a2fe4ec Make it configurable whether to leave insertmode on click 2014-06-23 08:05:52 +02:00
Florian Bruhin
0028bd94cc Go to insertmode in google docs 2014-06-23 08:02:10 +02:00
Florian Bruhin
35ffc2c2c0 Don't crash if url is None in tabopen 2014-06-23 07:48:45 +02:00
Florian Bruhin
5efc9de434 Add comment about leaving insertmode 2014-06-23 07:47:42 +02:00
Florian Bruhin
8a8ca0c34f Split utils.misc into utils.{qt,misc} 2014-06-23 07:45:04 +02:00
Florian Bruhin
3443364de1 Fix lint 2014-06-23 07:12:19 +02:00
Florian Bruhin
5996651a2f Merge utils.signals into utils.debug 2014-06-23 07:11:15 +02:00
Florian Bruhin
6aff5fd374 Document js/qt loggers 2014-06-23 07:00:21 +02:00
Florian Bruhin
2690891cbe Better init logging 2014-06-23 06:37:47 +02:00
Florian Bruhin
4eeeb13927 Fix resizing completion on init 2014-06-23 06:23:33 +02:00
Florian Bruhin
ca576a1c82 Add some logging when restoring mainwindow size. 2014-06-23 06:20:37 +02:00
Florian Bruhin
c21fad491a Don't shut down before crash dialog 2014-06-22 23:57:48 +02:00
Florian Bruhin
c77ad57a42 Don't log missing config descriptions 2014-06-22 23:55:48 +02:00
Florian Bruhin
03098f861e Add logging for completion resizing 2014-06-22 23:52:50 +02:00
Florian Bruhin
d5834e0cf0 Don't crash on completion items without icon 2014-06-22 23:46:43 +02:00
Florian Bruhin
9668994046 Don't return values from events. 2014-06-22 23:37:16 +02:00
Florian Bruhin
8f85149c96 Don't accidentally call superclass event twice. 2014-06-22 23:37:06 +02:00
Florian Bruhin
983a0da520 Use toDisplayString for URL text. 2014-06-22 23:35:20 +02:00
Florian Bruhin
ba20300a2c Check if hit test result is null 2014-06-22 23:35:01 +02:00
Florian Bruhin
15126dfb3c Don't leave insert mode on non-insert clicks.
This proved to be a bad idea, as we only can guess what's an insert mode and
what isn't.
2014-06-22 23:34:19 +02:00
Florian Bruhin
7aea12ad35 Add comment about CodeMirror. 2014-06-22 23:34:05 +02:00
Florian Bruhin
46c19012ab Fix spelling in comment. 2014-06-22 23:33:55 +02:00
Florian Bruhin
231aa6f9b8 Add FIXME for QTime. 2014-06-22 23:33:43 +02:00
Florian Bruhin
4bd8a596f1 Check return values (e.g. indexOf) 2014-06-22 23:33:32 +02:00
Florian Bruhin
ef5b16556b More validity checks. 2014-06-22 23:32:49 +02:00
Florian Bruhin
bf9e829d4d Don't use .warn on loggers, use .warning instead. 2014-06-22 23:30:44 +02:00
Florian Bruhin
49fd08b30d Leave URLs encoded when setting commandline 2014-06-21 23:19:59 +02:00
Florian Bruhin
4d6dd808b1 Make ErrorNetworkReply readable 2014-06-21 23:14:18 +02:00
Florian Bruhin
fa9dd97f13 Improve qute:foo error message 2014-06-21 23:10:47 +02:00
Florian Bruhin
e0bb09cbce Set URL for special network replies 2014-06-21 23:10:22 +02:00
Florian Bruhin
d695baf355 Reply with error reply on invalid qute:* URLs. 2014-06-21 23:05:26 +02:00
Florian Bruhin
800fa381b1 Set request for ErrorNetworkReply. 2014-06-21 23:05:13 +02:00
Florian Bruhin
e8ded0a32a Cleanup 2014-06-21 23:04:03 +02:00
Florian Bruhin
3f37c0bb0b Use a list for pending requests 2014-06-21 23:03:51 +02:00
Florian Bruhin
5ab9755ac4 Fix vim modeline in models.completion 2014-06-21 22:41:04 +02:00
Florian Bruhin
a64775a0f9 Improve logging messages 2014-06-21 22:40:31 +02:00
Florian Bruhin
a3e5a20063 Don't log missing config descriptions 2014-06-21 17:56:46 +02:00
Florian Bruhin
14bcdafe47 Fix completion coloring 2014-06-21 17:50:29 +02:00
Florian Bruhin
664079c728 Don't raise CommandError in HintManager.fire 2014-06-21 17:41:25 +02:00
Florian Bruhin
e1aabc974c Remove completion bg from stylesheet 2014-06-21 17:38:04 +02:00
Florian Bruhin
cd8bca7e3b Catch QColors passed to ColorDict 2014-06-21 17:37:54 +02:00
Florian Bruhin
7a6e2b3242 Ensure validity of Qt objects 2014-06-21 17:02:30 +02:00
Florian Bruhin
0dc2ecef46 Check QUrl objects for validity 2014-06-20 23:57:52 +02:00
Florian Bruhin
16758354e8 Fix missing return 2014-06-20 23:57:14 +02:00
Florian Bruhin
113221c731 Log some exceptions 2014-06-20 23:26:19 +02:00
Florian Bruhin
736f559afa Fix URL handling for quickmarks. 2014-06-20 22:57:32 +02:00
Florian Bruhin
2d2ee71bee Remove passwords from URLs going out via an insecure channel. 2014-06-20 22:57:04 +02:00
Florian Bruhin
03b69c5527 Print debug information if config saving failed. 2014-06-20 22:56:29 +02:00
Florian Bruhin
d6fb0f7774 Fix crash when pasting an URL 2014-06-20 22:31:39 +02:00
Florian Bruhin
9a33efdb3f Fix is_special_url (use QUrl). 2014-06-20 20:27:24 +02:00
Florian Bruhin
7de637baea Add a none argument to every config type and cleanup.
- Rename none to none_ok (because of "None")
- Fix File class.
2014-06-20 20:27:24 +02:00
Florian Bruhin
8b6af23b13 Make sure we don't display passwords in URLs to the user 2014-06-20 19:50:44 +02:00
Florian Bruhin
d3196fe683 Rename Url in statusbar to UrlText 2014-06-20 17:40:36 +02:00
Florian Bruhin
91416e345d Treat CodeMirror instances as editable 2014-06-20 16:55:42 +02:00
Florian Bruhin
0fd64419da Remove urlutils.{urlstring,qurl}.
The idea of treating an URL-string and a QUrl as essentially the same data type
got us into all kinds of problems. Now we use QUrl everywhere except at the
borders to the user interface.
2014-06-20 16:33:01 +02:00
Florian Bruhin
4909f3f0fe Add LeplFilter to RAM, not twice to console.
Fixes exception when sys.stderr is None.
2014-06-20 08:50:37 +02:00
Florian Bruhin
0fa309e2a4 Add a test for init_log if sys.stderr is None. 2014-06-20 08:50:04 +02:00
Florian Bruhin
e1ae4cb54c Add a base class for logging tests. 2014-06-20 08:49:48 +02:00
Florian Bruhin
2fac5aa0a0 Update comment 2014-06-20 06:53:41 +02:00
Florian Bruhin
5f86357ae8 Fix rfc6266 check 2014-06-20 06:45:52 +02:00
Florian Bruhin
d443e585d3 Add missing test_debug.py 2014-06-20 06:23:41 +02:00
Florian Bruhin
3c9b4369cd Don't crash on Content-Disposition with wrong enc.
When declaring UTF-8 but encoding RFC2231 ISO-8859-1, rfc2259 raises an
UnicodeDecodeError.

Test case: http://greenbytes.de/tech/tc2231/#attwithfn2231iso-bad
2014-06-19 23:14:20 +02:00
Florian Bruhin
7690e918a2 Handle early download errors correctly 2014-06-19 21:37:22 +02:00
Florian Bruhin
0dfdd422a2 Prevent double-deleting file in downloads 2014-06-19 21:27:57 +02:00
Florian Bruhin
684154dd7d Remove set_trace 2014-06-19 21:26:01 +02:00
Florian Bruhin
2fd475b1a4 Fix downloading without content-disposition 2014-06-19 21:09:33 +02:00
Florian Bruhin
6ce5afccbe Use rfc6266 to handle Content-Disposition in downloads 2014-06-19 21:06:19 +02:00
Florian Bruhin
52d1645479 Revert "Clean up styles"
This reverts commit f821d9e211.

This causes all methods to be applied from QCommonStyle, thus resulting in
right-click menus being blank...
2014-06-19 21:05:41 +02:00
Florian Bruhin
6b12572fb0 Add dwb download keybindings. 2014-06-19 17:58:46 +02:00
Florian Bruhin
9c26eba761 Catch weird TypeError when aborting question 2014-06-19 17:56:41 +02:00
Florian Bruhin
f821d9e211 Clean up styles 2014-06-19 15:43:34 +02:00
Florian Bruhin
d642aa48c1 Fix reparenting issues with layouts 2014-06-19 14:13:44 +02:00
Florian Bruhin
3de113ee8c Don't double-connect tabCloseRequested 2014-06-19 13:43:43 +02:00
Florian Bruhin
6f4b2e872b Don't restore focus to unfocused widget 2014-06-19 13:43:16 +02:00
Florian Bruhin
cd68d04067 Add missing space 2014-06-19 13:19:02 +02:00
Florian Bruhin
b70657eb53 Validate configs properly.
We inherited custom types from String which is wrong and not validated against
ValidValues.
2014-06-19 13:18:25 +02:00
Florian Bruhin
c56c7c0394 Support cancelling a javascript confirm dialog 2014-06-19 12:21:22 +02:00
Florian Bruhin
3435aef78c Add commandline argument for debug log buffer size 2014-06-19 12:11:46 +02:00
Florian Bruhin
fdda1dd3a0 Forward unbound non-alphanumeric keys by default.
We do this so we benefit from some default WebKit keybindings users would
expect. For example, we'd need to bind Ctrl+X/C/V by default without this.

We also remove the custom-bound scrolling keybindings as they're redundant now.

The forward-unbound-keys setting now isn't a bool anymore, instead it can be
set to all/auto/none.
2014-06-19 11:51:25 +02:00
Florian Bruhin
e6f9c0ccea Fix keyboard focus issues. 2014-06-19 11:50:31 +02:00
Florian Bruhin
d42e71a5d5 Use QApplication (not QCoreApplication) to call activeWindow 2014-06-19 11:22:17 +02:00
Florian Bruhin
1ed70bfef7 Fix utils.log so it works with sys.stderr == None 2014-06-19 10:19:00 +02:00
Florian Bruhin
d65587128f Add vim modelines to all files. 2014-06-19 09:04:37 +02:00
Florian Bruhin
4eebf24775 Improve crash dialog 2014-06-19 07:53:17 +02:00
Florian Bruhin
b25b3c3786 Remove accidentally commited set_trace 2014-06-19 07:52:32 +02:00
Florian Bruhin
6e59b0ab3a Parse Content-Disposition header properly 2014-06-18 22:52:49 +02:00
Florian Bruhin
36d31efe13 Fix lint 2014-06-17 23:16:06 +02:00
Florian Bruhin
2b5a1cc322 Add wiget/object list to crash dialog 2014-06-17 23:04:58 +02:00
Florian Bruhin
87ddfc418e Remove unneeded informations from segfault crash dialog 2014-06-17 22:37:20 +02:00
Florian Bruhin
6cc178aa52 Do some emergency shutdown on an exception. 2014-06-17 22:37:06 +02:00
Florian Bruhin
e6866f7d85 Don't go to insert mode on disabled/readonly fields 2014-06-17 15:32:18 +02:00
Florian Bruhin
8971d2ac18 Don't rename set_trace 2014-06-17 15:28:06 +02:00
Florian Bruhin
4a0e34fca7 Delete print dialogs on close 2014-06-17 14:33:15 +02:00
Florian Bruhin
2388874e82 Delete question if download as cancelled 2014-06-17 11:26:45 +02:00
Florian Bruhin
61e8940ccb Clean up debug methods 2014-06-17 11:12:55 +02:00
Florian Bruhin
52bbabd91a Clean up downloads properly 2014-06-17 11:06:59 +02:00
Florian Bruhin
1fef2d02b9 Add an :all-objects command and __repr__s 2014-06-17 11:03:42 +02:00
Florian Bruhin
fe99cbc331 Fix crashes after parent-child cleanup. 2014-06-17 10:20:15 +02:00
Florian Bruhin
7dfd7d018b pylint: completely disable unnecessary-lambda 2014-06-17 07:19:16 +02:00
Florian Bruhin
af9e4ae072 Fix parent/child relationships 2014-06-17 07:17:21 +02:00
Florian Bruhin
17cd86d564 Add an :all-widgets command and useful __repr__s 2014-06-17 06:37:56 +02:00
Florian Bruhin
177e2945b6 Use currying instead of self.sender() where applicable 2014-06-16 22:49:22 +02:00
Florian Bruhin
c6d875f8df Name --qt-widgetcount properly 2014-06-16 14:42:01 +02:00
Florian Bruhin
6554b995d1 Fix comment 2014-06-16 13:54:47 +02:00
Florian Bruhin
7325cefdae Fix lint 2014-06-16 12:11:10 +02:00