Patric Schmitz
a8b808819a
update log-javascript-console option documentation
2015-11-29 19:24:09 +01:00
Patric Schmitz
98a454a428
log-javascript-console -> [none, debug, info]
2015-11-29 18:37:11 +01:00
Florian Bruhin
736fd7d45e
Use os.path.join for bookmarks/urls path.
...
This should fix the tests on Windows which failed because they matched against
a message containing \.
2015-11-29 00:59:18 +01:00
Florian Bruhin
6a46aea934
Fix tests for basedir logging.
...
f5febc4
broke various tests which called standarddir.init() without a valid
basedir.
2015-11-29 00:35:18 +01:00
Florian Bruhin
f5febc4807
Log basedir and save it in QuteProcess for tests.
2015-11-28 23:35:32 +01:00
Florian Bruhin
e26c499bd6
lineparser: Log after saving is done.
...
This will make end to end tests easier as we can easily wait until saving is
done.
2015-11-28 23:35:04 +01:00
Florian Bruhin
c236e70920
Merge branch 'log-javascript-console' of https://github.com/flv0/qutebrowser into flv0-log-javascript-console
2015-11-28 21:12:25 +01:00
Florian Bruhin
8cf6ace0e7
Ignore deleted windows when saving session.
...
This hopefully helps with a crash on Windows which happens from time to time
during some multi-window tabs.feature tests:
Traceback (most recent call last):
File "...\mainwindow\mainwindow.py", line 446, in closeEvent
self._do_close()
File "...\mainwindow\mainwindow.py", line 405, in _do_close
objreg.get('session-manager').save_last_window_session()
File "...\misc\sessions.py", line 247, in save_last_window_session
self._last_window_session = self._save_all()
File "...\misc\sessions.py", line 183, in _save_all
win_data['geometry'] = bytes(main_window.saveGeometry())
RuntimeError: wrapped C/C++ object of type MainWindow has been deleted
2015-11-28 20:30:41 +01:00
Patric Schmitz
03ba38578e
set valid_values after __init__ consistently, move type validation out of class into pytest
2015-11-28 18:29:51 +01:00
Patric Schmitz
fdde05569c
remove redundant __init__ and rely on base class
2015-11-28 18:29:51 +01:00
Patric Schmitz
c322130dc0
style changes
2015-11-28 18:29:51 +01:00
Patric Schmitz
6f65397dfe
always set valid_values in __init__ instead of class scope variable
2015-11-28 18:29:51 +01:00
Patric Schmitz
9b453aaad5
revert config transformation
2015-11-28 18:29:51 +01:00
Patric Schmitz
9aaf5c18c1
set valid_values in __init__ methods, except for BaseType s.t. variable is shared across derived class scopes
2015-11-28 18:29:51 +01:00
Patric Schmitz
55edd9cda7
add valid_values = None to config basetype
2015-11-28 18:29:51 +01:00
Patric Schmitz
2867df4c21
revert log-javascript-console changes
2015-11-28 18:29:51 +01:00
Patric Schmitz
6431542eba
fixes to config types, remove unneeded derived __init__ and call base __init__
2015-11-28 18:29:51 +01:00
Patric Schmitz
2a705e2eb6
Make non-specialized config types String. Closes #1103
2015-11-28 18:29:51 +01:00
Patric Schmitz
75f9f2af8d
get rid of redundant option description
2015-11-28 18:29:51 +01:00
Patric Schmitz
ff6d3e05a6
log-javascript-console now String option: none, debug, info
...
Make BaseType.valid_values per-instance variable
2015-11-28 18:29:51 +01:00
Florian Bruhin
b79049261e
Delay :yank notification until message was yanked.
...
This should make yankpaste tests more reliable.
2015-11-27 18:32:17 +01:00
Florian Bruhin
23068e9679
Don't log yanked test with :yank-selected.
...
It makes our tests fail (invalid log line) and is probably not needed.
2015-11-26 21:23:11 +01:00
Florian Bruhin
8e7a76280b
Use cmdutils.check_exclusive for :tab-clone.
2015-11-26 20:11:53 +01:00
Florian Bruhin
7f5e07d7cc
bdd: Add some tests for :tab-move.
2015-11-26 18:37:47 +01:00
Florian Bruhin
f56e7b1220
Simplify :tab-move code.
2015-11-26 17:44:34 +01:00
Florian Bruhin
987ee59f58
:tab-move: Fix tab index shown in error message.
2015-11-26 16:37:54 +01:00
Florian Bruhin
5a95cfdc7a
Change CommandError to ValueError for :tab-move.
...
This should never happen.
2015-11-26 16:37:29 +01:00
Daniel Schadt
d082c248a8
Disallow empty values in url-incdec-segments
2015-11-25 19:35:37 +01:00
Florian Bruhin
951c2e8eb6
Fix qflags_key comparison.
2015-11-25 18:54:03 +01:00
Florian Bruhin
a6045ab551
Handle invalid select-on-remove case.
2015-11-25 18:47:36 +01:00
Florian Bruhin
73e9fd1118
Handle BOM (\ufeff) for webelem.javascript_escape.
2015-11-25 18:14:52 +01:00
Florian Bruhin
24a71e5c2e
Fix webelem.javascript_escape with U+2028/U+2029.
2015-11-25 10:32:22 +01:00
Florian Bruhin
027a10c04b
bdd: Add some tests for :navigate.
2015-11-24 21:32:45 +01:00
Florian Bruhin
8faf4717e5
Make :debug-console toggle the console.
2015-11-24 18:32:18 +01:00
Florian Bruhin
35de87f973
Expand ~ with :dump-page.
2015-11-24 18:04:10 +01:00
Florian Bruhin
b37dac7bfa
Handle errors in :dump-page.
2015-11-24 18:03:39 +01:00
Florian Bruhin
e405492667
Ignore errors when removing temp basedir.
2015-11-24 17:50:39 +01:00
Florian Bruhin
3905884a84
Disable all QWebSettings storage when quitting.
...
This hopefully helps with issues on the Windows buildbot:
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
File "C:\Users\florian\buildbot\slave\win8\build\.tox\py34\lib\shutil.py", line 371, in _rmtree_unsafe
os.unlink(fullname)
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\florian\\AppData\\Local\\Temp\\qutebrowser-basedir-ixuexfeu\\data\\local-storage\\qrc__0.localstorage'
2015-11-24 17:24:14 +01:00
Florian Bruhin
43d7b139e8
Ignore another libpng warning.
...
This happened here:
https://ci.appveyor.com/project/The-Compiler/qutebrowser/build/master-1536/job/k8es4nh719cc27hf
2015-11-24 16:59:35 +01:00
Florian Bruhin
922fdc0526
Fix :fake-key with no focused webview.
2015-11-24 16:28:56 +01:00
Florian Bruhin
75178b0cdc
Log when the focus object changed.
...
This is mainly needed for tests to synchronize things properly.
2015-11-24 15:24:45 +01:00
Florian Bruhin
c73de6ea4d
Change "Added binding ..." logs to vdebug.
2015-11-23 21:41:31 +01:00
Florian Bruhin
b0d4ebe844
Don't log VDEBUG messages with --debug.
...
This reduces the log spam quite a bit, which also makes things easier when
dealing with CI output.
2015-11-23 21:40:11 +01:00
Florian Bruhin
607ca0f478
tests: Wait until page is dumped for header check.
...
If we don't do this, it's possible for the test process to delete the temporary
directory before qutebrowser actually writes the file.
2015-11-23 20:12:52 +01:00
Florian Bruhin
31892b437e
Add :debug-dump-page command.
...
This can probably be merged into :download later, when the mess is cleaned up.
2015-11-23 14:35:46 +01:00
Florian Bruhin
16e1a65448
Merge branch 'download-page' of https://github.com/Kingdread/qutebrowser into Kingdread-download-page
2015-11-23 13:16:16 +01:00
Daniel Schadt
89c9b5959e
Don't ask the user twice for a filename
...
Fixes a bug where the user would be asked twice for a filename when
using :download without a dest-argument.
The problem was that we unconditionally overwrote filename, even if one
was given, thus discarding any "filename-finding-process" that we had
and asking the user again.
2015-11-23 12:32:58 +01:00
Florian Bruhin
efa745b53f
Fix indent.
2015-11-23 11:26:01 +01:00
Florian Bruhin
f4cccdf13f
Merge branch 'patch-1' of https://github.com/larryhynes/qutebrowser into larryhynes-patch-1
2015-11-23 11:23:10 +01:00
Florian Bruhin
ee0627128a
Merge branch 'argparse-usage' of https://github.com/forkbong/qutebrowser into forkbong-argparse-usage
2015-11-23 11:20:49 +01:00